Menu
▾
▴
#865 Extend Jbpm extension reader with more JFire properties
DO NOT EDIT OR ANSWER THIS ISSUE. SEE THE ORIGINAL ISSUE INSTEAD:
https://www.jfire.org/modules/bugs/view.php?id=1087
ORIGINAL REPORTER: alex
Seems we have missed two properties in the extensions that are needed by JFire:
* It should be possible to mark a state/node as 'publicState'. See JavaDoc of org.nightlabs.jfire.jbpm.graph.def.StateDefinition#isPublicState() for an explanation. The default value of 'publicState' should be false if not defined.
* It should be possible to mark a transition as 'userExecutable'. See JavaDoc of org.nightlabs.jfire.jbpm.graph.def.Transition#isUserExecutable() for an explanation. The default value of 'userExecutable' should be true if not defined.
Both properties can be modeled as attributes in the extension file:
<state name="dev.jfire.org:finalized" publicState="true">
...
</state>
<state ...>
<transition name="dev.jfire.org:bookImplicitely" to="dev.jfire.org:bookedImplicitely" userExecutable="false"></transition>
</state>
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
added the necessary tags using my own XML extension generator that can be found at projects experimental folder i had to the add the optional tag standalone="no" also in the file.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
Sorry, have to reopen.
The new properties are not transfered to the JFire objects on ProcessDefinition#storeProcessDefinition(). This needs to be done before closing the issue.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
whole clean-up was done in the trader and recurring trader and store and accounting, also the xml extension reader sets the properties in the method ProcessDefinition#storeProcessDefinition().
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
added the necessary tags using my own XML extension generator that can be found at projects experimental folder i had to the add the optional tag standalone="no" also in the file.
ORIGINAL COMMENT BY daniel, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
I just saw/realized that sth. must be wrong with the way the processdefinition-extension.xml is read or assigned to the statedefinition names.
I'm sure because in my database in the table jfirejbpm_statedefinitionname_names the entry (Invoice.Vendor/dev.jfire.org/created) has the name (en:book-implicitly, de:buchen-implizit) although in the corresponding processdefinition-extension.xml (JFireTrade/../jpbm/invoice/vendor/processdefinition-extension.xml) the entry is declared right:
<start-state name="dev.jfire.org:created" publicState="true">
<name language="de">erzeugt</name>
<description language="de">erzeugt</description>
<name language="en">created</name>
<description language="en">created</description>
Please fix that, because now in the UI the wrong names are written, which makes the user thing that the state is wrong.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
thanks for reporting the bug, the reader s parser was adding the sub children nodes, so I added a control to prevent the addition of sub children nodes in the reader, I ve took a look at the resulted created database and the names was created successfully.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
added the necessary tags using my own XML extension generator that can be found at projects experimental folder i had to the add the optional tag standalone="no" also in the file.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
Sorry, have to reopen.
The new properties are not transfered to the JFire objects on ProcessDefinition#storeProcessDefinition(). This needs to be done before closing the issue.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
whole clean-up was done in the trader and recurring trader and store and accounting, also the xml extension reader sets the properties in the method ProcessDefinition#storeProcessDefinition().
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
added the necessary tags using my own XML extension generator that can be found at projects experimental folder i had to the add the optional tag standalone="no" also in the file.
ORIGINAL COMMENT BY daniel, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
I just saw/realized that sth. must be wrong with the way the processdefinition-extension.xml is read or assigned to the statedefinition names.
I'm sure because in my database in the table jfirejbpm_statedefinitionname_names the entry (Invoice.Vendor/dev.jfire.org/created) has the name (en:book-implicitly, de:buchen-implizit) although in the corresponding processdefinition-extension.xml (JFireTrade/../jpbm/invoice/vendor/processdefinition-extension.xml) the entry is declared right:
<start-state name="dev.jfire.org:created" publicState="true">
<name language="de">erzeugt</name>
<description language="de">erzeugt</description>
<name language="en">created</name>
<description language="en">created</description>
Please fix that, because now in the UI the wrong names are written, which makes the user thing that the state is wrong.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1087
thanks for reporting the bug, the reader s parser was adding the sub children nodes, so I added a control to prevent the addition of sub children nodes in the reader, I ve took a look at the resulted created database and the names was created successfully.