Menu

#404 Edit FRU information update problem

version-1.8.15
closed-fixed
fru (2)
5
2015-12-14
2015-12-06
No

There seems to be some problem with the fru edit function. to be more
exactly its the update of the header which seems to be wrong. if I edit
a valid fru

ipmitool -H xxxx -U yyyy -P yyy -T 0x20 -B 0 -t 0x78 -b 7 fru edit 0
field b 0 "Uni Mainz"

the header is not correctly updated.

You can notice that all data is moved 8 bytes and the offset for the
first record after the edited one is correctly modified. but the second
offset for the multirecord area) is not modified.

Patch is attached.
It is supposed to modify the header offset to muti-record area if any of the three previous areas has been edited.

Remark: this has to occur before the new header crc is calculated. thats the reson the modification is not close to the actual movement of the data. maybe it would be nicer to change the order in the code here. but I do not want to add undesired behaviour, thus keeping a clear and small patch.

1 Attachments

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2015-12-09

    Ticket moved from /p/ipmitool/patches/108/

     
  • Zdenek Styblik

    Zdenek Styblik - 2015-12-09

    Please, don't put { at extra line. Please, use % git format-patch; to generate patch.

    Thank you,
    Z.

     
  • Zdenek Styblik

    Zdenek Styblik - 2015-12-14
    • status: open --> closed-fixed
    • assigned_to: Zdenek Styblik
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.