IPMItool / Bugs (use GitHub instead) / #369 Fix lanplus interface bridging and response matching.

#369 Fix lanplus interface bridging and response matching.

Milestone: version-1.8.16

Status: closed-fixed

Owner: Zdenek Styblik

Labels: None

Priority: 5

Updated: 2017-05-04

Created: 2015-02-06

Creator: Dmitry Bazhenov

Private: No

Request/response matching for bridged and double-bridged requests is broken.
This patch reworks the sending and command construction code, and fixes the response matching problems.
Since the polling code is retried several times, it was moved into a separate function in order to make the code more readable.

1 Attachments

lanplus-bridging-fix.diff

Discussion

Zdenek Styblik - 2015-02-17

Dmitry, please, review your code formatting in this and previous bug, I think.
I haven't tested/run through Coverity those changes as I'm waiting for iface safe reopen to be in first.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dmitry Bazhenov - 2015-03-19

Corrected some formatting issues.

369.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jim Mankovich - 2015-03-23

How did you go about testing this change? Was it tested on more than one vendor platform that supports bridging?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dmitry Bazhenov - 2015-03-24

We have several PigeonPoint-based products, implementing PICMG 3.0, AMC.0 and MTCA.0 IPMI-based specification. These are the only products where the LAN+ bridging and double beidging was tested on.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zdenek Styblik - 2015-07-25

status: open --> closed-fixed

assigned_to: Zdenek Styblik
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zdenek Styblik - 2015-07-25

This has been committed into git. Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcin Juszkiewicz - 2017-05-04

This change breaks IPMI on HPE Moonshot systems.

I bisected from 1.8.15 (good) to 1.8.18 (bad) and this change was first when I got:

Running Get PICMG Properties my_addr 0x20, transit 0, target 0x20
Discovered PICMG Extension Version 2.3
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
IPMI Request Match NOT FOUND
Unable to get Chassis Power Status

Instead of:

Discovered IPMB-0 address 0x20
Discovered Target IPMB-0 address 0x72
Chassis Power is on

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.