Menu

#33 memcpy overrun

Unstable (example)
closed-fixed
None
5
2014-10-16
2010-03-20
No

Original string has X bytes and duplicate string has X+1 bytes, therefore need to limit read to X bytes to try and stay inside your own boundaries when reading.

Discussion

  • Jose Da Silva

    Jose Da Silva - 2010-03-20

    csutil.c.diff

     
  • Jose Da Silva

    Jose Da Silva - 2010-03-20

    csutil.cxx.diff

     
  • caolan mcnamara

    caolan mcnamara - 2010-04-07

    The csutil.c.diff changes to hyphen are already in the cvs version, and *some* of the csutil.cxx.diff changes are already in there. Some seem like some micro opts, which it doesn't hurt to add, but which chunk does the title of this patch relate to ?

     
  • Jose Da Silva

    Jose Da Silva - 2010-04-08

    I should have noted the bugs before sending the initial patches, but looking at memcpy, realized afterwards you need to copy using the shorter string length and not the longer value.

    The patches are based on what is currently inside the cvs, for example, now csutil.cxx was at 1.8 when I used it as a reverence, but is now at rev 1.9.,Looking at what 1.9 fixed, you could still apply this patch to it. this is where I found csutil.cxx
    http://hunspell.cvs.sourceforge.net/viewvc/hunspell/hunspell/src/hunspell/

    while csutil.c is located here:
    http://hunspell.cvs.sourceforge.net/viewvc/hunspell/hyphen/

     
  • caolan mcnamara

    caolan mcnamara - 2014-10-16
    • status: open --> closed-fixed
    • assigned_to: caolan mcnamara
    • Group: --> Unstable (example)