HLBR - Hogwash Light BR / Bugs / #1 Check return codes everywhere

#1 Check return codes everywhere

Status: open-postponed

Owner: André Bertelli Araújo

Labels: None

Priority: 2

Updated: 2007-04-19

Created: 2007-02-20

Creator: Markus Elfring

Private: No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "malloc" in functions like "DecodeTCP" and from "DecodeEthernet"?
http://hlbr.svn.sourceforge.net/viewvc/hlbr/trunk/hlbr/decoders/decode_ethernet.c?revision=111&view=markup
http://hlbr.svn.sourceforge.net/viewvc/hlbr/trunk/hlbr/decoders/decode_tcp.c?revision=111&view=markup

Discussion

André Bertelli Araújo - 2007-04-19

priority: 5 --> 2

status: open --> open-postponed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

André Bertelli Araújo - 2007-04-19

Logged In: YES
user_id=1357472
Originator: NO

Lots of places in the code needs more checking... I've been adding some every time I see one missing check like this, but it would be nice to check all the code specifically for malloc/calloc's and add error handling for them.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2007-04-19

assigned_to: nobody --> arkanoid_
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2007-04-19

Logged In: YES
user_id=572001
Originator: YES

Can the tool "http://splint.org/" help to find any remaining issues?

Would you like to reduce the efforts for error code checking by an exception class hierarchy?
http://dietmar-kuehl.de/mirror/c++-faq/exceptions.html#faq-17.1
http://cexcept.sourceforge.net/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.