Menu

#5 some small improvements to visual appearance

closed-accepted
None
2015-05-12
2014-08-22
No

Hi,

replace the clear() in gui.c:659/generate_screen() by erase() and the screen does not longer flicker while scrolling.

Another change, that would be nice, is to compute the length of the offset number from the largset possible address, so the panels do not move to the right in full view when scrolling downwards through a larger file.

Discussion

  • Maëlys McArdle

    Maëlys McArdle - 2014-10-01

    Hi Rene,

    Thank you very much for the input. I'll amend the file and compute the offset ahead of time (great idea!) I haven't touched this code in three years, so I might give it a clean now too.

     
  • Mateusz Viste

    Mateusz Viste - 2015-05-12

    hello Rene, this has been quite a long time :)
    I'm not sure where this bug report is, since it's still in the 'open' state. I see that gui.c still contain a call to clear(), but I do not see any flicker here. could you be so kind and confirm whether this still needs fixing for you?

    about the highest offset: this is a good idea indeed, and this I see is not done, I will work on that very soon.

     
  • Mateusz Viste

    Mateusz Viste - 2015-05-12

    hello, I replaced clear() with erase() - I don't see any difference, but it might be different on other systems. the erase() man says it makes more sense to use it anyway.

    I also adapted hexcompare to make the left margin sufficiently large as to accomodate the largest offset of the file. it's all on the svn trunk, and will be publicly released in the next future version.

     
  • Mateusz Viste

    Mateusz Viste - 2015-05-12
    • status: open --> closed-accepted
    • assigned_to: Mateusz Viste
     

Log in to post a comment.