From: Benno <fw...@ro...> - 2013-02-15 16:30:46
Attachments:
gtkpod-sorttab.patch
|
Hello, I'd like to submit a patch fixing an issue on 64Bit Linux, which was introduced after the stable release gtkpod-2.1.2, and is contained in the stable release gtkpod-2.1.3! It was not possible to make any selection with the "track filter", at least it hadn't any effect on the "playlist tracks". (Normally if you select an artist, the "playlist tracks" would only show the tracks of that artist) The reason was the comparison of different sized(at least in 64 bit systems) unsigned types, that were set to "-1" 1)in _NormalSortTabPagePrivate guint selection_changed_idle_id; 2)in _st_selection_changed() gulong idleId Hope, this patch helps! Greetings, Benno |
From: Daniele F. <df...@gm...> - 2013-02-15 18:16:27
|
2013/2/15 Benno: > The reason was the comparison of different sized(at least in 64 bit systems) > unsigned types, that were set to "-1" > 1)in _NormalSortTabPagePrivate > guint selection_changed_idle_id; > 2)in _st_selection_changed() > gulong idleId I committed your fix http://sourceforge.net/mailarchive/message.php?msg_id=30490651 but now I think I misunderstood and I think I should revert it and change idelId to guint instead because struct member selection_changed_idle_id is assigned the return value from gdk_threads_add_idle_full() which indeed is a guint. What do you think? -- Daniele Forsi |
From: phantomjinx <p.g...@ph...> - 2013-03-01 21:02:04
|
On 02/15/2013 06:16 PM, Daniele Forsi wrote: > 2013/2/15 Benno: > >> The reason was the comparison of different sized(at least in 64 bit systems) >> unsigned types, that were set to "-1" >> 1)in _NormalSortTabPagePrivate >> guint selection_changed_idle_id; >> 2)in _st_selection_changed() >> gulong idleId > > I committed your fix > http://sourceforge.net/mailarchive/message.php?msg_id=30490651 > > but now I think I misunderstood and I think I should revert it and > change idelId to guint instead because struct member > selection_changed_idle_id is assigned the return value from > gdk_threads_add_idle_full() which indeed is a guint. What do you > think? > Hey Daniele, Did anything come from this in the end? PGR -- Paul Richardson * p.g...@ph... * p.g...@re... * pgr...@li... "I know exactly who reads the papers ... * The Daily Mirror is read by people who think they run the country. * The Guardian is read by people who think they ought to run the country. * The Times is read by people who do actually run the country. * The Daily Mail is read by the wives of the people who run the country. * The Financial Times is read by the people who own the country. * The Morning Star is read by the people who think the country ought to be run by another country. * The Daily Telegraph is read by the people who think it is." Jim Hacker, Yes Minister |
From: Daniele F. <df...@gm...> - 2013-03-01 00:10:45
|
2013/2/28 phantomjinx: > On 02/15/2013 06:16 PM, Daniele Forsi wrote: >> 2013/2/15 Benno: >> >>> The reason was the comparison of different sized(at least in 64 bit systems) >>> unsigned types, that were set to "-1" >>> 1)in _NormalSortTabPagePrivate >>> guint selection_changed_idle_id; >>> 2)in _st_selection_changed() >>> gulong idleId >> >> I committed your fix >> http://sourceforge.net/mailarchive/message.php?msg_id=30490651 >> >> but now I think I misunderstood and I think I should revert it and >> change idelId to guint instead because struct member >> selection_changed_idle_id is assigned the return value from >> gdk_threads_add_idle_full() which indeed is a guint. What do you >> think? >> > > Hey Daniele, > > Did anything come from this in the end? thank you for reminding this, hopefully now I have committed a fix changing the type of the variable and the value of NO_IDLE_SELECTION_CALLBACK to zero which according to the docs is never returned by gdk_threads_add_idle_full () -- Daniele Forsi |
From: Benno <fw...@ro...> - 2013-03-02 18:37:18
|
On 28.02.2013 22:17, Daniele Forsi wrote: > 2013/2/28 phantomjinx: >> On 02/15/2013 06:16 PM, Daniele Forsi wrote: >>> 2013/2/15 Benno: >>> >>>> The reason was the comparison of different sized(at least in 64 bit systems) >>>> unsigned types, that were set to "-1" >>>> 1)in _NormalSortTabPagePrivate >>>> guint selection_changed_idle_id; >>>> 2)in _st_selection_changed() >>>> gulong idleId >>> >>> I committed your fix >>> http://sourceforge.net/mailarchive/message.php?msg_id=30490651 >>> >>> but now I think I misunderstood and I think I should revert it and >>> change idelId to guint instead because struct member >>> selection_changed_idle_id is assigned the return value from >>> gdk_threads_add_idle_full() which indeed is a guint. What do you >>> think? >>> >> >> Hey Daniele, >> >> Did anything come from this in the end? > > thank you for reminding this, hopefully now I have committed a fix > changing the type of the variable and the value of > NO_IDLE_SELECTION_CALLBACK to zero which according to the docs is > never returned by gdk_threads_add_idle_full () > I've just tested the patch on my 64bit system. It works! Thanks! |