From: Andrea <mar...@go...> - 2008-11-16 10:26:19
Attachments:
gtkpod.diff
|
Hi, I would like to post again the patch to fix a bug when using the track filter and selecting a different playlist. I've already posted a description of the issue: Here is a quick descriptions. The GUI removes from the tree_filter all the tracks, but the underlying tree might contain more tracks that are currently filtered out. So, if I change playlist and then remove the filter, I get all the tracks of the original playlist (that were originally filtered out). The patch basically removes all tracks from the tree and not only the ones that are currently visible. Let me know what you think. Andrea |
From: Jorg S. <Jor...@gm...> - 2008-11-30 13:55:27
|
Andrea wrote: > Hi, > > I would like to post again the patch to fix a bug when using the track filter and selecting a > different playlist. > > I've already posted a description of the issue: > > Here is a quick descriptions. > > The GUI removes from the tree_filter all the tracks, but the underlying tree might contain more > tracks that are currently filtered out. > So, if I change playlist and then remove the filter, I get all the tracks of the original playlist > (that were originally filtered out). > The patch basically removes all tracks from the tree and not only the ones that are currently visible. > > Let me know what you think. > > Andrea I'm not too familiar with the filtering option (shame on me...) -- but wouldn't your patch imply that other parts of the code where gtk_tree_view_get_model (track_treeview) is being used should have to be modified as well? (Most prominently tm_delete_track()). I'd appreciate your comments. Cheers, JCS. |
From: Andrea <mar...@go...> - 2008-12-06 12:05:16
|
Jorg Schuler wrote: > I'm not too familiar with the filtering option (shame on me...) -- but > wouldn't your patch imply that other parts of the code where > gtk_tree_view_get_model (track_treeview) is being used should have to be > modified as well? (Most prominently tm_delete_track()). > > I'd appreciate your comments. > > Cheers, I have not found any other function that misbehaves. tm_delete_track() is called on a track (so it must be visible). There is an option to delete all tracks from an iPod and that works too. I will keep searching. Andrea |
From: Jorg S. <Jor...@gm...> - 2008-12-07 12:18:02
|
Andrea wrote: > Jorg Schuler wrote: > >> I'm not too familiar with the filtering option (shame on me...) -- but >> wouldn't your patch imply that other parts of the code where >> gtk_tree_view_get_model (track_treeview) is being used should have to be >> modified as well? (Most prominently tm_delete_track()). >> >> I'd appreciate your comments. >> >> Cheers, >> > > I have not found any other function that misbehaves. > tm_delete_track() is called on a track (so it must be visible). > > There is an option to delete all tracks from an iPod and that works too. > > I will keep searching. > > Andrea > Thanks. I've finally found some time to work on it. It turned out that there were a number of more issues with the filter, but I hope I have addressed all of them. Committed to SVN. Thanks for the pointer! Cheers, JCS. |