From: Alex C. <aco...@gm...> - 2007-05-22 16:52:56
|
Hi, I believe I found a bug in python-gpod. It seems that the function "itdb_thumb_get_gdk_pixbuf" is made to return a "gpointer *", however it should return a gdk.pixbuf object instance, otherwise there is a memory leak in swig/python. Each this function is called (when I am debugging python programs from the console) the following error is printed: swig/python detected a memory leak of type 'gpointer *', no destructor found. I believe the bug severity to be medium/serious since for ipods with large databases (>10,000 songs, which is not uncommon at all) this leak could potentially result in leaking almost 1GB of memory (each thumbnail occupies 80k in the ipod, 10,000*80k=800mb). Regards, Alex PS: I dont know where to submit this bug report, I sent it to the python-gpod package mantainers, and they requested to submit a formal bug report, however I dont know if I should simply post a bug report on ubuntu's launchpad (I am using ubuntu, but this bug is not ubuntu specific). |
From: Nicholas P. <nic...@ni...> - 2007-05-22 17:16:27
|
Alex, On Tue, 22 May 2007, Alex Cornejo wrote: > Hi, I believe I found a bug in python-gpod. > It seems that the function "itdb_thumb_get_gdk_pixbuf" is made to > return a "gpointer *", however it should return a gdk.pixbuf object > instance, otherwise there is a memory leak in swig/python. The gdk.pixbuf would also be much more useful too :-) > Each this function is called (when I am debugging python programs from > the console) the following error is printed: > > swig/python detected a memory leak of type 'gpointer *', no destructor found. > I believe the bug severity to be medium/serious since for ipods with > large databases (>10,000 songs, which is not uncommon at all) this > leak could potentially result in leaking almost 1GB of memory (each > thumbnail occupies 80k in the ipod, 10,000*80k=800mb). > PS: I dont know where to submit this bug report, I sent it to the > python-gpod package mantainers, and they requested to submit a formal > bug report, however I dont know if I should simply post a bug report > on ubuntu's launchpad (I am using ubuntu, but this bug is not ubuntu > specific). I believe you should post to http://sourceforge.net/tracker/?atid=519273&group_id=67873&func=browse and assign it to me, "nicholas". I'm afraid I can't say when I shall fix it though. Nick -- Nick Piper, Developer, LogicaCMG http://www.nickpiper.co.uk/ GPG Encrypted mail welcome! 1024D/3ED8B27F Choose life. Be Vegan :-) Please reduce needless cruelty & suffering ! |
From: Todd Z. <tm...@po...> - 2007-05-22 17:44:15
|
Nicholas Piper wrote: > I believe you should post to > http://sourceforge.net/tracker/?atid=3D519273&group_id=3D67873&func=3Dbro= wse Would it be useful to populate the categories for the tracker with something like the following: Category Assigned To gtkpod jcsjcs libgpod jcsjcs, teuf[1] python-gpod nicolas[2] Or perhaps this would be better if libgpod and gtkpod had their own projects and then the categories could be divided more on functional areas (gtkpod/{gui, coverart, i18n, mounting, etc}, libgpod/{iTunesDB, PhotoDB, python})? I have no idea if that's worth the hassle. I'd be willing to help out with the setup and maintenance to help keep the folks doing the real work from being burdened by it, FWIW. [1] If it's possible to assign to both, that is. [2] I don't mind being listed here also, though I don't know how many bugs I'd be able to actually fix. :) --=20 Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Nothing is so simple that it cannot be misunderstood. -- Teague's Paradox |
From: Jorg S. <Jor...@gm...> - 2007-05-31 14:51:39
|
Hi Todd, as long as we don't really have more than 2-3 people actively working on this assigning to people won't make any difference :-( General call: anyone, please feel free to have a look at the bugs and feature-request lists and start fixing things. Please! And there's the much longer "TODOandBUGS.txt" in the gtkpod directory... Cheers, JCS. Todd Zullinger wrote: > Nicholas Piper wrote: >> I believe you should post to >> http://sourceforge.net/tracker/?atid=519273&group_id=67873&func=browse > > Would it be useful to populate the categories for the tracker with > something like the following: > > Category Assigned To > gtkpod jcsjcs > libgpod jcsjcs, teuf[1] > python-gpod nicolas[2] > > Or perhaps this would be better if libgpod and gtkpod had their own > projects and then the categories could be divided more on functional > areas (gtkpod/{gui, coverart, i18n, mounting, etc}, libgpod/{iTunesDB, > PhotoDB, python})? I have no idea if that's worth the hassle. I'd be > willing to help out with the setup and maintenance to help keep the > folks doing the real work from being burdened by it, FWIW. > > [1] If it's possible to assign to both, that is. > [2] I don't mind being listed here also, though I don't know how many > bugs I'd be able to actually fix. :) |
From: Todd Z. <tm...@po...> - 2007-05-22 17:29:26
|
Hi Alex, Alex Cornejo wrote: > Hi, I believe I found a bug in python-gpod. >=20 > It seems that the function "itdb_thumb_get_gdk_pixbuf" is made to > return a "gpointer *", however it should return a gdk.pixbuf object > instance, otherwise there is a memory leak in swig/python. >=20 > Each this function is called (when I am debugging python programs > from the console) the following error is printed: >=20 > swig/python detected a memory leak of type 'gpointer *', no > destructor found. This might need another helper function. There is sw_save_itdb_thumb, which is meant to save a thumbnail to a file. I don't know if it's possible to coerce itdb_thumb_get_gdk_pixbuf to return a gdb.pixbuf object from swig or not (but I'm not very knowledgeable about the low-level swig stuff). This is probably partly due to the fact that in the main library, itdb_thumb_get_gdk_pixbuf returns a gpointer which needs to be manually cast to a gdk pixbuf so that the dependence on gdk pixbuf can remain optional. :-/ > PS: I dont know where to submit this bug report, I sent it to the > python-gpod package mantainers, and they requested to submit a > formal bug report, however I dont know if I should simply post a bug > report on ubuntu's launchpad (I am using ubuntu, but this bug is not > ubuntu specific). Here or the SF tracker for the gtkpod project would be good. Of course, if the folks at Ubuntu want to help out with a patch, that'd be great. :) --=20 Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I may kid around about drugs, but really, I take them seriously. -- Doctor Graper |