From: Juergen H. <jue...@ch...> - 2004-12-09 15:31:18
|
Hi! I'd like to compile the latest gtkpod version 0.85 including m4a support on a MDK 10.1 machine. I have the mp4v2 libs installed needed for that (version 1.2) and the configuration script is picking them up: GTK2 version .........: 2.5.6 GLib2/GThread version : 2.5.7 id3tag lib ...........: yes mp4v2 ................: yes -- will build with aac support NLS/gettext ..........: yes Now type 'make' to build gtkpod 0.85.0, and then 'make install' for installation. so far so good. On compilation I get the same error somebody posted here when trying to compile the 0.73 version: mp4file.c: In function `mp4_get_file_info': mp4file.c:230: error: `PACKAGE' undeclared (first use in this function) mp4file.c:230: error: (Each undeclared identifier is reported only once mp4file.c:230: error: for each function it appears in.) mp4file.c: In function `mp4_write_file_info': mp4file.c:349: error: `PACKAGE' undeclared (first use in this function) make[2]: *** [mp4file.o] Error 1 I tried the suggestions made in that thread: edit config.h to change "#define ENABLE_NLS 1" to "#define ENABLE_NLS 0" doesn't do it, same error. Adding /* Name of package */ #define PACKAGE "gtkpod" doesn't do it either. I also tried the suggestion to change src/support.h and change the line # define _(String) dgettext (PACKAGE, String) to # define _(String) dgettext (gtkpod, String) which doesn't work as well compilation fails on the first file. charset.c: In function `charset_init_combo': charset.c:160: error: `gtkpod' undeclared (first use in this function) charset.c:160: error: (Each undeclared identifier is reported only once charset.c:160: error: for each function it appears in.) charset.c: In function `charset_from_description': charset.c:222: error: `gtkpod' undeclared (first use in this function) charset.c: In function `charset_to_description': charset.c:255: error: `gtkpod' undeclared (first use in this function) make[2]: *** [charset.o] Error 1 make[2]: Leaving directory `/home/helmerj/Documents/gtkpod-0.85.0/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/helmerj/Documents/gtkpod-0.85.0' make: *** [all] Error 2 Does anybody have any suggestions? I got the mp4v2 libs from http://www.mpeg4ip.net/ and the compilation of the whole package fails but the libs are build (lib/mp4v2) and can be installed. Do I need anything else from that package to successfully build gtkpod? Thanks Juergen |
From: David Le B. <da...@dy...> - 2004-12-09 20:37:07
|
Hey, I've encountered the same problem with FreeBSD. You have to edit src/support.h and replace PACKAGE by "gtkpod". Here is the patch : --- src/support.h.old Thu Dec 9 21:35:24 2004 +++ src/support.h Thu Dec 9 21:35:39 2004 @@ -14,7 +14,7 @@ #ifdef ENABLE_NLS # include <libintl.h> # undef _ -# define _(String) dgettext (PACKAGE, String) +# define _(String) dgettext ("gtkpod", String) # define Q_(String) g_strip_context ((String), gettext (String)) # ifdef gettext_noop # define N_(String) gettext_noop (String) Regards, David Juergen Helmers wrote: > Hi! > > I'd like to compile the latest gtkpod version 0.85 including m4a support on a > MDK 10.1 machine. I have the mp4v2 libs installed needed for that (version > 1.2) and the configuration script is picking them up: > > > > GTK2 version .........: 2.5.6 > GLib2/GThread version : 2.5.7 > id3tag lib ...........: yes > mp4v2 ................: yes -- will build with aac support > NLS/gettext ..........: yes > > Now type 'make' to build gtkpod 0.85.0, > and then 'make install' for installation. > > > so far so good. On compilation I get the same error somebody posted here when > trying to compile the 0.73 version: > > mp4file.c: In function `mp4_get_file_info': > mp4file.c:230: error: `PACKAGE' undeclared (first use in this function) > mp4file.c:230: error: (Each undeclared identifier is reported only once > mp4file.c:230: error: for each function it appears in.) > mp4file.c: In function `mp4_write_file_info': > mp4file.c:349: error: `PACKAGE' undeclared (first use in this function) > make[2]: *** [mp4file.o] Error 1 > > I tried the suggestions made in that thread: > > edit config.h to change "#define ENABLE_NLS 1" to "#define ENABLE_NLS 0" > doesn't do it, same error. Adding > > /* Name of package */ > #define PACKAGE "gtkpod" > > doesn't do it either. > > I also tried the suggestion to change src/support.h and change the line > > # define _(String) dgettext (PACKAGE, String) > to > # define _(String) dgettext (gtkpod, String) > > which doesn't work as well compilation fails on the first file. > > charset.c: In function `charset_init_combo': > charset.c:160: error: `gtkpod' undeclared (first use in this function) > charset.c:160: error: (Each undeclared identifier is reported only once > charset.c:160: error: for each function it appears in.) > charset.c: In function `charset_from_description': > charset.c:222: error: `gtkpod' undeclared (first use in this function) > charset.c: In function `charset_to_description': > charset.c:255: error: `gtkpod' undeclared (first use in this function) > make[2]: *** [charset.o] Error 1 > make[2]: Leaving directory `/home/helmerj/Documents/gtkpod-0.85.0/src' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/home/helmerj/Documents/gtkpod-0.85.0' > make: *** [all] Error 2 > > > > Does anybody have any suggestions? I got the mp4v2 libs from > http://www.mpeg4ip.net/ and the compilation of the whole package fails but the > libs are build (lib/mp4v2) and can be installed. Do I need anything else from > that package to successfully build gtkpod? > > Thanks Juergen > > > > > > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel > |
From: Juergen H. <jue...@ch...> - 2004-12-10 12:22:04
|
David Le Brun <david <at> dyn-ns.net> writes: > > Hey, > > I've encountered the same problem with FreeBSD. > You have to edit src/support.h and replace PACKAGE by "gtkpod". > > Here is the patch : > --- src/support.h.old Thu Dec 9 21:35:24 2004 > +++ src/support.h Thu Dec 9 21:35:39 2004 > <at> <at> -14,7 +14,7 <at> <at> > #ifdef ENABLE_NLS > # include <libintl.h> > # undef _ > -# define _(String) dgettext (PACKAGE, String) > +# define _(String) dgettext ("gtkpod", String) > # define Q_(String) g_strip_context ((String), gettext (String)) > # ifdef gettext_noop > # define N_(String) gettext_noop (String) > > Regards, > David > Hi David! Thanks again for the patch! Using this patch, the compilation went just fine. Unfortunately gtkpod is not able to import any m4a files. Upon importing a playlist containing m4a files, or importing a single file directly I get this error and gtkpod crashes at once: gtkpod: symbol lookup error: gtkpod: undefined symbol: MP4GetTrackBitRate So there seems to be a problem with the mp4v2 lib I use. Could people report the version number of their lib that works with gtkpod? I do use the version 1.2 which is the latest... Thanks Juergen |
From: Chris M. <cdm...@al...> - 2004-12-10 13:06:08
Attachments:
mp4.patch
|
I run Linux (Debian/unstable), and dpkg reports that libmp4 is version 2.0.0-0.0. Note, however, that for some reason autoconf fails in the check for mp4.h, so I have to edit config.h manually after running it to enable mp4/aac support. I'm still trying to determine why. On a related topic, I've written a small patch to allow drag and drop of mp4 files (just a copy of the dnd for mp3 files). You can find it attached to this message, if you'd like to try it. -- Chris On Fri, 2004-10-12 at 12:21 +0000, Juergen Helmers wrote: > > Hi David! > > Thanks again for the patch! Using this patch, the compilation went just fine. > Unfortunately gtkpod is not able to import any m4a files. Upon importing a > playlist containing m4a files, or importing a single file directly I get this > error and gtkpod crashes at once: > > gtkpod: symbol lookup error: gtkpod: undefined symbol: MP4GetTrackBitRate > > So there seems to be a problem with the mp4v2 lib I use. Could people report > the version number of their lib that works with gtkpod? I do use the version > 1.2 which is the latest... > > Thanks Juergen > > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel |
From: Jorg S. <Jor...@gm...> - 2004-12-11 07:52:03
|
Hi Chris, On Fri, Dec 10, 2004 at 08:05:56AM -0500, Chris Micacchi wrote: > I run Linux (Debian/unstable), and dpkg reports that libmp4 is version > 2.0.0-0.0. where did you get a package of libmp4 for Debian -- I didn't find any on the Debian servers. > Note, however, that for some reason autoconf fails in the check for > mp4.h, so I have to edit config.h manually after running it to enable > mp4/aac support. I'm still trying to determine why. The logfile (config.log) should give more details on why the autodetect did not work. > On a related topic, I've written a small patch to allow drag and drop of > mp4 files (just a copy of the dnd for mp3 files). You can find it > attached to this message, if you'd like to try it. Thanks! I really have overlooked that part. I appreciate your patch, but I opted for something more generic: --- misc.orig 2004-12-11 15:53:12.000000000 +0900 +++ misc.c 2004-12-11 15:53:39.000000000 +0900 @@ -373,33 +373,35 @@ } if (g_file_test (decoded_file, G_FILE_TEST_IS_REGULAR)) { /* regular file */ - gint decoded_len = strlen (decoded_file); - if (decoded_len >= 4) + gint ftype = determine_file_type (decoded_file); + switch (ftype) { - if (strcasecmp (&decoded_file[decoded_len-4], - ".mp3") == 0) - { /* mp3 file */ - if (!pl) - { /* no playlist yet -- create new one */ - pl = add_new_pl_user_name (NULL, - pl_pos); - if (!pl) break; /* while (*filesp) */ - } - add_track_by_filename (decoded_file, pl, - prefs_get_add_recursively (), - trackaddfunc, data); - added = TRUE; - } - else if ((strcasecmp (&decoded_file[decoded_len-4], - ".plu") == 0) || - (strcasecmp (&decoded_file[decoded_len-4], - ".m3u") == 0)) - { - add_playlist_by_filename (decoded_file, - pl_playlist, - trackaddfunc, data); - added = TRUE; + case FILE_TYPE_MP3: + case FILE_TYPE_M4A: + case FILE_TYPE_M4P: + case FILE_TYPE_M4B: + case FILE_TYPE_WAV: + if (!pl) + { /* no playlist yet -- create new one */ + pl = add_new_pl_user_name (NULL, + pl_pos); + if (!pl) break; /* while (*filesp) */ } + add_track_by_filename (decoded_file, pl, + prefs_get_add_recursively (), + trackaddfunc, data); + added = TRUE; + break; + case FILE_TYPE_M3U: + case FILE_TYPE_PLS: + add_playlist_by_filename (decoded_file, + pl_playlist, + trackaddfunc, data); + added = TRUE; + break; + case FILE_TYPE_ERROR: + case FILE_TYPE_UNKNOWN: + break; } } g_free (decoded_file); Cheers, JCS. |
From: Chris M. <cdm...@al...> - 2004-12-12 06:23:47
|
On Sat, 2004-11-12 at 16:04 +0900, Jorg Schuler wrote: > Hi Chris, > > where did you get a package of libmp4 for Debian -- I didn't find any on the > Debian servers. I just checked where my apt is fetching the package from, and it seems to be getting it from the marillat source (where mplayer and other media stuff can be found). If you don't have that source, it is deb http://marillat.free.fr/ unstable main I find that a mirror works better for that source, since marillat.free.fr seems to have problems resolving a lot of the time. I use this one: deb ftp://ftp.nerim.net/debian-marillat/ unstable main > > Note, however, that for some reason autoconf fails in the check for > > mp4.h, so I have to edit config.h manually after running it to enable > > mp4/aac support. I'm still trying to determine why. > > The logfile (config.log) should give more details on why the autodetect did > not work. config.log says: configure:6867: gcc -E conftest.c In file included from /usr/include/mpeg4ip.h:28, from /usr/include/mp4.h:27, from conftest.c:35: /usr/include/systems.h:34:20: config.h: No such file or directory so it appears to be a problem with this "systems.h" file, which is part of the libmp4-dev package, and not something with gtkpod. > Thanks! I really have overlooked that part. I appreciate your patch, but I > opted for something more generic: Excellent, that looks much cleaner. -- Chris |