From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:14
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Summary: Update Gtk2 to gtk+ 2.18 Classification: Bindings Product: gnome-perl Version: unspecified OS/Version: All Status: NEW Severity: normal Priority: Normal Component: Gtk2 AssignedTo: gtk...@li... ReportedBy: eb...@gm... QAContact: gtk...@li... GNOME target: --- GNOME version: --- The following patches add the missing 2.16 and 2.18 API wrappers for gtk+. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:15
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #1 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:06 UTC --- Created an attachment (id=159409) View: https://bugzilla.gnome.org/attachment.cgi?id=159409 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159409 Add GtkAction block/unblock activate methods Use a version check, as these methods were added in gtk+ 2.16 -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:20
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #2 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:11 UTC --- Created an attachment (id=159410) View: https://bugzilla.gnome.org/attachment.cgi?id=159410 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159410 Add missing 2.16 API for GtkEntry -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:28
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #4 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:18 UTC --- Created an attachment (id=159412) View: https://bugzilla.gnome.org/attachment.cgi?id=159412 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159412 Add GtkEntryBuffer bindings In gtk+ 2.18, GtkEntry gained the GtkEntryBuffer object which provides a model similar to GtkTextBuffer for GtkTextView. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:31
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #3 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:15 UTC --- Created an attachment (id=159411) View: https://bugzilla.gnome.org/attachment.cgi?id=159411 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159411 Add missing to GtkIMMultiContext::set_context_id() -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:33
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #5 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:22 UTC --- Created an attachment (id=159413) View: https://bugzilla.gnome.org/attachment.cgi?id=159413 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159413 Add GtkEntryBuffer-related methods to GtkEntry -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:36:40
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #6 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:36:26 UTC --- Created an attachment (id=159414) View: https://bugzilla.gnome.org/attachment.cgi?id=159414 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159414 Add missing Gtk2::Widget accessors added in gtk+ 2.18 -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:50:37
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #7 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:50:24 UTC --- Created an attachment (id=159417) View: https://bugzilla.gnome.org/attachment.cgi?id=159417 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159417 Add GtkEntryBuffer bindings In gtk+ 2.18, GtkEntry gained the GtkEntryBuffer object which provides a model similar to GtkTextBuffer for GtkTextView. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:50:53
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Emmanuele Bassi <ebassi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159412|0 |1 is obsolete| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:51:40
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Emmanuele Bassi <ebassi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159413|0 |1 is obsolete| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-23 11:52:14
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #8 from Emmanuele Bassi <eb...@gm...> 2010-04-23 11:51:59 UTC --- Created an attachment (id=159418) View: https://bugzilla.gnome.org/attachment.cgi?id=159418 Review: https://bugzilla.gnome.org/review?bug=616634&attachment=159418 Add GtkEntryBuffer-related methods to GtkEntry -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 18:04:49
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified André Klapper <a9016009> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a90...@gm... -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 19:10:27
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159409|none |committed status| | --- Comment #9 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 19:10:14 UTC --- Review of attachment 159409: --> (https://bugzilla.gnome.org/review?bug=616634&attachment=159409) Looks good. Committed with slight changes and tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 19:24:02
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159410|none |committed status| | --- Comment #10 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 19:23:47 UTC --- Review of attachment 159410: --> (https://bugzilla.gnome.org/review?bug=616634&attachment=159410) Looks good. Committed with tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 19:42:58
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159411|none |committed status| | --- Comment #11 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 19:42:47 UTC --- Review of attachment 159411: --> (https://bugzilla.gnome.org/review?bug=616634&attachment=159411) Looks good. Committed with tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 20:01:11
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159414|none |needs-work status| | --- Comment #12 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 20:00:57 UTC --- Review of attachment 159414: --> (https://bugzilla.gnome.org/review?bug=616634&attachment=159414) These new methods need to integrate with those that are already there (defined in GtkWidget.xs starting at line 173). For example, the allocation() accessor should get a get_allocation() alias and should use gtk_widget_get_allocation inside an #ifdef. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 20:16:13
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159417|none |needs-work status| | --- Comment #13 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 20:16:01 UTC --- Review of attachment 159417: --> (https://bugzilla.gnome.org/review?bug=616634&attachment=159417) Looks good in general. A few comments: ::: xs/GtkEntryBuffer.xs @@ +45,3 @@ +MAX_SIZE (class) + CODE: + RETVAL = GTK_ENTRY_BUFFER_MAX_SIZE; I think it is better to use the constants wrapping machinery for this. Just adding a line "GTK_ENTRY_BUFFER_MAX_SIZE newSVuv" to a newly created "constants-2.18" file should do the trick. @@ +50,3 @@ + +GtkEntryBuffer_noinc * +gtk_entry_buffer_new (class, const gchar *initial_chars=NULL, gint n_initial_chars=-1) I don't think there is any precedence of having such a string length argument in the Perl API. Is it really necessary? Or can you just use the gchar_length typemap as in GtkTextBuffer.xs? If a user wants to show only a substring, he can still use substr(). Similar comments apply to insert_text() and emit_inserted_text() below. @@ +75,3 @@ +void gtk_entry_buffer_insert_text (GtkEntryBuffer *buffer, guint position, const gchar *chars, gint n_chars=-1); + +guint gtk_entry_buffer_delete_text (GtkEntryBuffer *buffer, guint position=0, gint n_chars=-1); I don't think the default -1 for n_chars makes sense here. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-29 23:15:17
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159414|needs-work |committed status| | --- Comment #14 from Torsten Schoenfeld <kaf...@gm...> 2010-12-29 23:15:02 UTC --- (From update of attachment 159414) Committed with additions and tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-29 23:15:48
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159417|needs-work |committed status| | --- Comment #15 from Torsten Schoenfeld <kaf...@gm...> 2010-12-29 23:15:34 UTC --- (From update of attachment 159417) Committed with slight changes. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-29 23:16:14
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified --- Comment #16 from Torsten Schoenfeld <kaf...@gm...> 2010-12-29 23:16:05 UTC --- (From update of attachment 159418) Committed with tests. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-29 23:16:26
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159418|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-29 23:17:03
|
https://bugzilla.gnome.org/show_bug.cgi?id=616634 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kaf...@gm... Resolution| |FIXED --- Comment #17 from Torsten Schoenfeld <kaf...@gm...> 2010-12-29 23:16:49 UTC --- So, everything is now committed. Thanks for the patches! -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |