#236 Visual Progress Bar Configurable Colors

Future
open
GUI (32)
1
2004-12-21
2004-12-09
John Foerch
No

I did read comments in visual_progress.c that mention
that the colors of the download progress meter should
be configurable. I want to suggest that they be
configurable as a style in gtkrc (or gtkrc-2.0) theme
rather than as settings within the program itself.

Discussion

    • priority: 5 --> 1
     
  • Logged In: YES
    user_id=643728

    Could you elaborate on the reasons? I think it's much
    simpler and consistent to use GUI properties.

     
  • Logged In: YES
    user_id=643728

    Could you elaborate on the reasons? I think it's much
    simpler and consistent to use GUI properties.

     
  • John Foerch
    John Foerch
    2004-12-21

    Logged In: YES
    user_id=983545

    Is the progress meter technically a widget? I have various
    theme customizations in my gtkrc* files for gtk-gnutella and
    other gtk programs. So my line of thought is that if I
    could customize this progress meter in the theme files I
    already have, that is one less file to hunt down for backup
    of my themes. If the progress meter is not a widget, might
    it be useful as one?

     
    • assigned_to: nobody --> graaff
     
  • Hans de Graaff
    Hans de Graaff
    2005-01-09

    Logged In: YES
    user_id=162593

    The progress bar is not actually a widget. We just draw the
    graphics on a blank canvas. I don't think that it makes
    sense to make this into a widget, since it is quite specific
    to the circumstances of downloading a p2p file in gtk-gnutella.

    When I get around to making the colors configurable I'd be
    happy to have a look at doing this as part of a style.
    Having no knowledge on gtkrc styles yet I'm concerned to put
    gtk-gnutella specific settings into another file, though,
    and I do not think it is likely that all the colors we use
    map onto generic, abstract, colors in the style.