From: <tp...@fr...> - 2005-02-18 20:30:35
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Fri Feb 18 2005 12:30:33 PST Log message: Fix inline docs: tag setter vararg functions are NULL-termianted, GST_TAG_INVALID doesn't exist any more Modified files: . : ChangeLog gst : gsttaginterface.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.968&r2=1.969 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaginterface.c.diff?r1=1.7&r2=1.8 ====Begin Diffs==== Index: gsttaginterface.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gsttaginterface.c,v retrieving revision 1.7 retrieving revision 1.8 diff -u -d -r1.7 -r1.8 --- gsttaginterface.c 7 May 2004 02:36:27 -0000 1.7 +++ gsttaginterface.c 18 Feb 2005 20:30:21 -0000 1.8 @@ -132,7 +132,7 @@ * @...: more tag / value pairs to set * * Adds the given tag / value pairs on the setter using the given merge mode. - * The list must be terminated with GST_TAG_INVALID. + * The list must be terminated with %NULL. */ void gst_tag_setter_add (GstTagSetter * setter, GstTagMergeMode mode, @@ -156,7 +156,7 @@ * @...: more tag / GValue pairs to set * Adds the given tag / GValue pairs on the setter using the given merge mode. gst_tag_setter_add_values (GstTagSetter * setter, GstTagMergeMode mode, @@ -180,7 +180,7 @@ * @var_args: tag / value pairs to set gst_tag_setter_add_valist (GstTagSetter * setter, GstTagMergeMode mode, @@ -206,7 +206,7 @@ * @var_args: tag / GValue pairs to set gst_tag_setter_add_valist_values (GstTagSetter * setter, GstTagMergeMode mode, Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.968 retrieving revision 1.969 diff -u -d -r1.968 -r1.969 --- ChangeLog 18 Feb 2005 13:58:35 -0000 1.968 +++ ChangeLog 18 Feb 2005 20:30:21 -0000 1.969 @@ -1,3 +1,9 @@ +2005-02-18 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gsttaginterface.c: + Fix inline docs: tag setter vararg functions are NULL-terminated, + GST_TAG_INVALID doesn't exist any more. 2005-02-18 Zaheer Abbas Merali <zaheerabbas at merali dot org> * libs/gst/dataprotocol/dataprotocol.c: (gst_dp_dump_byte_array): |
From: <tp...@fr...> - 2005-03-21 15:43:54
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Mar 21 2005 07:43:53 PST Branch: BRANCH-GSTREAMER-0_8 Log message: Handle escaped spaces in structure string, so that gst_parse_launch() can deal with spaces in filtered link caps (fixes #164479) Modified files: . : ChangeLog gst : gststructure.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.966.2.26&r2=1.966.2.27 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gststructure.c.diff?r1=1.39&r2=1.39.4.1 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.966.2.26 retrieving revision 1.966.2.27 diff -u -d -r1.966.2.26 -r1.966.2.27 --- ChangeLog 20 Mar 2005 20:20:52 -0000 1.966.2.26 +++ ChangeLog 21 Mar 2005 15:43:40 -0000 1.966.2.27 @@ -1,3 +1,11 @@ +2005-03-21 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gststructure.c: (gst_structure_parse_field), + (gst_structure_from_string): + Handle escaped spaces in structure string, so that + gst_parse_launch() can deal with spaces in filtered + link caps (fixes #164479). 2005-03-20 Benjamin Otte <in...@pu...> * gst/gstbuffer.h: Index: gststructure.c RCS file: /cvs/gstreamer/gstreamer/gst/gststructure.c,v retrieving revision 1.39 retrieving revision 1.39.4.1 diff -u -d -r1.39 -r1.39.4.1 --- gststructure.c 2 Nov 2004 15:02:12 -0000 1.39 +++ gststructure.c 21 Mar 2005 15:43:41 -0000 1.39.4.1 @@ -1352,14 +1352,14 @@ s = str; - while (g_ascii_isspace (*s)) + while (g_ascii_isspace (*s) || (s[0] == '\\' && g_ascii_isspace (s[1]))) s++; name = s; if (!gst_structure_parse_simple_string (s, &name_end)) return FALSE; s = name_end; if (*s != '=') @@ -1492,7 +1492,7 @@ if (!gst_structure_parse_string (r, &w, &r)) goto error; - while (g_ascii_isspace (*r)) + while (g_ascii_isspace (*r) || (r[0] == '\\' && g_ascii_isspace (r[1]))) r++; if (*r != 0 && *r != ';' && *r != ',') @@ -1506,14 +1506,16 @@ if (*r != ',') goto error; - while (*r && g_ascii_isspace (*r)) + while (*r && (g_ascii_isspace (*r) || (r[0] == '\\' + && g_ascii_isspace (r[1])))) r++; memset (&field, 0, sizeof (field)); if (!gst_structure_parse_field (r, &r, &field)) gst_structure_set_field (structure, &field); } |
From: <tp...@fr...> - 2005-06-20 11:32:29
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Jun 20 2005 04:32:26 PDT Log message: * gst/gsturi.c: (gst_element_make_from_uri): Fix potential endless loop. Modified files: . : ChangeLog gst : gsturi.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1134&r2=1.1135 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsturi.c.diff?r1=1.22&r2=1.23 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1134 retrieving revision 1.1135 diff -u -d -r1.1134 -r1.1135 --- ChangeLog 19 Jun 2005 11:32:38 -0000 1.1134 +++ ChangeLog 20 Jun 2005 11:32:14 -0000 1.1135 @@ -1,3 +1,8 @@ +2005-06-20 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gsturi.c: (gst_element_make_from_uri): + Fix potential endless loop. 2005-06-19 Thomas Vander Stichele <thomas at apestaart dot org> * check/Makefile.am: Index: gsturi.c RCS file: /cvs/gstreamer/gstreamer/gst/gsturi.c,v retrieving revision 1.22 retrieving revision 1.23 diff -u -d -r1.22 -r1.23 --- gsturi.c 11 Oct 2004 09:44:05 -0000 1.22 +++ gsturi.c 20 Jun 2005 11:32:14 -0000 1.23 @@ -488,6 +488,7 @@ gst_object_unref (GST_OBJECT (ret)); ret = NULL; } + walk = walk->next; } g_list_free (possibilities); |
From: <tp...@fr...> - 2005-06-21 08:41:06
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Tue Jun 21 2005 01:41:00 PDT Branch: BRANCH-GSTREAMER-0_8 Log message: * gst/gstformat.c: * gst/gstquery.c: Fix two typos in the inline documentation. * gst/gsttag.c: (gst_tag_register): Don't spew out an assertion warning if a tag is already registered, unless the new type differs from the old one (fixes #308438). Modified files: . : ChangeLog gst : gstformat.c gstquery.c gsttag.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.966.2.88&r2=1.966.2.89 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstformat.c.diff?r1=1.10&r2=1.10.4.1 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstquery.c.diff?r1=1.6&r2=1.6.4.1 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttag.c.diff?r1=1.26.4.1&r2=1.26.4.2 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.966.2.88 retrieving revision 1.966.2.89 diff -u -d -r1.966.2.88 -r1.966.2.89 --- ChangeLog 19 Jun 2005 10:55:41 -0000 1.966.2.88 +++ ChangeLog 21 Jun 2005 08:40:48 -0000 1.966.2.89 @@ -1,3 +1,14 @@ +2005-06-21 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstformat.c: + * gst/gstquery.c: + Fix two typos in the inline documentation. + * gst/gsttag.c: (gst_tag_register): + Don't spew out an assertion warning if a tag is + already registered, unless the new type differs + from the old one (fixes #308438). 2005-06-19 Luca Ognibene <lu...@ti...> * gst/registries/gstlibxmlregistry.c (gst_xml_registry_get_property): Index: gstformat.c RCS file: /cvs/gstreamer/gstreamer/gst/gstformat.c,v retrieving revision 1.10 retrieving revision 1.10.4.1 diff -u -d -r1.10 -r1.10.4.1 --- gstformat.c 3 May 2004 16:03:24 -0000 1.10 +++ gstformat.c 21 Jun 2005 08:40:48 -0000 1.10.4.1 @@ -66,7 +66,7 @@ * @description: The description of the new format * * Create a new GstFormat based on the nick or return an - * allrady registered format with that nick + * already registered format with that nick * Returns: A new GstFormat or an already registered format * with the same nick. Index: gstquery.c RCS file: /cvs/gstreamer/gstreamer/gst/gstquery.c,v retrieving revision 1.6 retrieving revision 1.6.4.1 diff -u -d -r1.6 -r1.6.4.1 --- gstquery.c 7 May 2004 02:36:27 -0000 1.6 +++ gstquery.c 21 Jun 2005 08:40:48 -0000 1.6.4.1 @@ -68,7 +68,7 @@ * @description: The description of the new query * Create a new GstQueryType based on the nick or return an - * allrady registered query with that nick + * already registered query with that nick * Returns: A new GstQueryType or an already registered query Index: gsttag.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttag.c,v retrieving revision 1.26.4.1 retrieving revision 1.26.4.2 diff -u -d -r1.26.4.1 -r1.26.4.2 --- gsttag.c 17 Apr 2005 20:43:54 -0000 1.26.4.1 +++ gsttag.c 21 Jun 2005 08:40:48 -0000 1.26.4.2 @@ -280,7 +280,11 @@ key = g_quark_from_string (name); info = gst_tag_lookup (key); - g_return_if_fail (info == NULL); + if (info) { + g_return_if_fail (info->type == type); + return; + } info = g_new (GstTagInfo, 1); info->flag = flag; |
From: <tp...@fr...> - 2005-07-02 12:34:20
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Sat Jul 02 2005 05:34:13 PDT Branch: BRANCH-GSTREAMER-0_8 Log message: * gst/gstelement.c: Improve inline API docs for gst_element_remove_pad(). Modified files: . : ChangeLog gst : gstelement.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.966.2.97&r2=1.966.2.98 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstelement.c.diff?r1=1.310.2.5&r2=1.310.2.6 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.966.2.97 retrieving revision 1.966.2.98 diff -u -d -r1.966.2.97 -r1.966.2.98 --- ChangeLog 1 Jul 2005 16:36:31 -0000 1.966.2.97 +++ ChangeLog 2 Jul 2005 12:34:00 -0000 1.966.2.98 @@ -1,3 +1,8 @@ +2005-07-02 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstelement.c: + Improve inline API docs for gst_element_remove_pad(). 2005-07-01 Ronald S. Bultje <rb...@ro...> * gst/schedulers/gstoptimalscheduler.c: Index: gstelement.c RCS file: /cvs/gstreamer/gstreamer/gst/gstelement.c,v retrieving revision 1.310.2.5 retrieving revision 1.310.2.6 diff -u -d -r1.310.2.5 -r1.310.2.6 --- gstelement.c 16 Jun 2005 08:09:43 -0000 1.310.2.5 +++ gstelement.c 2 Jul 2005 12:34:01 -0000 1.310.2.6 @@ -1239,7 +1239,10 @@ * @pad: the #GstPad to remove from the element. * * Removes @pad from @element. @pad will be destroyed if it has not been - * referenced elsewhere. + * referenced elsewhere. Normally, only elements remove pads. The only + * exception to this are ghost pads which were created by the application + * and request pads, which applications can remove using + * gst_element_release_request_pad(). */ void gst_element_remove_pad (GstElement * element, GstPad * pad) |
From: <tp...@fr...> - 2005-08-08 13:56:19
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Aug 08 2005 06:55:49 PDT Log message: * gst/gstiterator.h: Fix wrong include and 'make distcheck'. Modified files: . : ChangeLog gst : gstiterator.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1339&r2=1.1340 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstiterator.h.diff?r1=1.5&r2=1.6 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1339 retrieving revision 1.1340 diff -u -d -r1.1339 -r1.1340 --- ChangeLog 8 Aug 2005 13:38:33 -0000 1.1339 +++ ChangeLog 8 Aug 2005 13:55:36 -0000 1.1340 @@ -1,3 +1,8 @@ +2005-08-08 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstiterator.h: + Fix wrong include and 'make distcheck'. 2005-08-08 Ronald S. Bultje <rb...@ro...> * gst/gstbin.c: (bin_bus_handler): Index: gstiterator.h RCS file: /cvs/gstreamer/gstreamer/gst/gstiterator.h,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- gstiterator.h 8 Aug 2005 13:31:09 -0000 1.5 +++ gstiterator.h 8 Aug 2005 13:55:37 -0000 1.6 @@ -23,7 +23,7 @@ #define __GST_ITERATOR_H__ #include <glib-object.h> /* for GValue in the fold */ -#include "gstconfig.h" +#include <gst/gstconfig.h> G_BEGIN_DECLS |
From: <tp...@fr...> - 2005-08-10 21:19:16
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Wed Aug 10 2005 14:19:13 PDT Log message: * gst/gst.c: (gst_init_check_with_popt_table), (init_pre): Check whether GST_DEBUG_NO_COLOR environment variable is set and disable coloured debug output if that is the case. Modified files: . : ChangeLog gst : gst.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1343&r2=1.1344 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.158&r2=1.159 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1343 retrieving revision 1.1344 diff -u -d -r1.1343 -r1.1344 --- ChangeLog 10 Aug 2005 15:08:02 -0000 1.1343 +++ ChangeLog 10 Aug 2005 21:19:01 -0000 1.1344 @@ -1,5 +1,11 @@ 2005-08-10 Tim-Philipp Müller <tim at centricular dot net> + * gst/gst.c: (gst_init_check_with_popt_table), (init_pre): + Check whether GST_DEBUG_NO_COLOR environment variable is + set and disable coloured debug output if that is the case. + +2005-08-10 Tim-Philipp Müller <tim at centricular dot net> * gst/base/gsttypefindhelper.c: (helper_find_peek), (gst_type_find_helper): The memory returned by gst_type_find_peek() needs to Index: gst.c RCS file: /cvs/gstreamer/gstreamer/gst/gst.c,v retrieving revision 1.158 retrieving revision 1.159 diff -u -d -r1.158 -r1.159 --- gst.c 18 Jul 2005 12:49:52 -0000 1.158 +++ gst.c 10 Aug 2005 21:19:01 -0000 1.159 @@ -346,6 +346,10 @@ context = poptGetContext ("GStreamer", *argc, (const char **) *argv, options, 0); + /* check for GST_DEBUG_NO_COLOR environment variable */ + if (g_getenv ("GST_DEBUG_NO_COLOR") != NULL) + gst_debug_set_colored (FALSE); /* check for GST_DEBUG environment variable */ gst_debug_env = g_getenv ("GST_DEBUG"); if (gst_debug_env) @@ -468,6 +472,9 @@ { const gchar *debug_list; + if (g_getenv ("GST_DEBUG_NO_COLOR") != NULL) + gst_debug_set_colored (FALSE); debug_list = g_getenv ("GST_DEBUG"); if (debug_list) { parse_debug_list (debug_list); |
From: <tp...@fr...> - 2005-08-10 21:30:37
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Wed Aug 10 2005 14:30:30 PDT Branch: BRANCH-GSTREAMER-0_8 Log message: * gst/gst.c: (gst_init_check_with_popt_table), (init_pre): Check whether GST_DEBUG_NO_COLOR environment variable is set and disable coloured debug output if so. Modified files: . : ChangeLog gst : gst.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.966.2.101&r2=1.966.2.102 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.146.2.3&r2=1.146.2.4 ====Begin Diffs==== Index: gst.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gst.c,v retrieving revision 1.146.2.3 retrieving revision 1.146.2.4 diff -u -d -r1.146.2.3 -r1.146.2.4 --- gst.c 14 May 2005 23:55:20 -0000 1.146.2.3 +++ gst.c 10 Aug 2005 21:30:17 -0000 1.146.2.4 @@ -346,6 +346,10 @@ } if (popt_options == NULL) { + /* check for GST_DEBUG_NO_COLOR environment variable */ + if (g_getenv ("GST_DEBUG_NO_COLOR") != NULL) + gst_debug_set_colored (FALSE); + options = options_without; } else { options = options_with; @@ -469,6 +473,9 @@ { const gchar *debug_list; debug_list = g_getenv ("GST_DEBUG"); if (debug_list) { parse_debug_list (debug_list); Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.966.2.101 retrieving revision 1.966.2.102 diff -u -d -r1.966.2.101 -r1.966.2.102 --- ChangeLog 4 Aug 2005 16:26:08 -0000 1.966.2.101 +++ ChangeLog 10 Aug 2005 21:30:17 -0000 1.966.2.102 @@ -1,3 +1,9 @@ +2005-08-10 Tim-Philipp Müller <tim at centricular dot net> + * gst/gst.c: (gst_init_check_with_popt_table), (init_pre): + Check whether GST_DEBUG_NO_COLOR environment variable is + set and disable coloured debug output if so. 2005-08-04 Benjamin Otte <ot...@gn...> * docs/libs/gstreamer-libs-docs.sgml: |
From: <tp...@fr...> - 2005-09-21 21:36:44
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Wed Sep 21 2005 14:36:12 PDT Branch: BRANCH-GSTREAMER-0_8 Log message: Reviewed by: Tim-Philipp Müller <tim at centricular dot net> * gst/gstinfo.c: (_gst_debug_nameof_funcptr), (_gst_debug_register_funcptr): Add mutex to serialise access to the hash table with the function pointer => function name string mapping; make that hash table static scope (#316809). Modified files: . : ChangeLog gst : gstinfo.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.966.2.114&r2=1.966.2.115 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstinfo.c.diff?r1=1.96.2.2&r2=1.96.2.3 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.966.2.114 retrieving revision 1.966.2.115 diff -u -d -r1.966.2.114 -r1.966.2.115 --- ChangeLog 13 Sep 2005 15:03:05 -0000 1.966.2.114 +++ ChangeLog 21 Sep 2005 21:36:00 -0000 1.966.2.115 @@ -1,8 +1,19 @@ -2005-09-13 Steve Lhomme <ste...@fr...> +2005-09-21 Francis Labonte <francis_labonte at hotmail dot com> + + Reviewed by: Tim-Philipp Müller <tim at centricular dot net> + * gst/gstinfo.c: (_gst_debug_nameof_funcptr), + (_gst_debug_register_funcptr): + Add mutex to serialise access to the hash table with + the function pointer => function name string mapping; + make that hash table static scope (#316809). +2005-09-13 Steve Lhomme <ste...@fr...> * win32/config.h: - update some defines for cleaner and better compilation + update some defines for cleaner and better compilation * win32/gst-typefind.vcproj: - added gst-typefind to the MSVC7 build + added gst-typefind to the MSVC7 build 2005-09-13 Julien MOUTTE <ju...@mo...> Index: gstinfo.c RCS file: /cvs/gstreamer/gstreamer/gst/gstinfo.c,v retrieving revision 1.96.2.2 retrieving revision 1.96.2.3 diff -u -d -r1.96.2.2 -r1.96.2.3 --- gstinfo.c 16 Jun 2005 08:09:43 -0000 1.96.2.2 +++ gstinfo.c 21 Sep 2005 21:36:00 -0000 1.96.2.3 @@ -1038,7 +1038,9 @@ /*** FUNCTION POINTERS ********************************************************/ -GHashTable *__gst_function_pointers = NULL; +static GHashTable *__gst_function_pointers; /* NULL */ +static GStaticMutex __dbg_functions_mutex = G_STATIC_MUTEX_INIT; const gchar * _gst_debug_nameof_funcptr (void *ptr) G_GNUC_NO_INSTRUMENT; @@ -1052,9 +1054,12 @@ Dl_info dlinfo; #endif - if (__gst_function_pointers - && (ptrname = g_hash_table_lookup (__gst_function_pointers, ptr))) { - return ptrname; + if (__gst_function_pointers) { + g_static_mutex_lock (&__dbg_functions_mutex); + ptrname = g_hash_table_lookup (__gst_function_pointers, ptr); + g_static_mutex_unlock (&__dbg_functions_mutex); + if (ptrname) + return ptrname; } /* we need to create an entry in the hash table for this one so we don't leak * the name */ @@ -1077,11 +1082,15 @@ void * _gst_debug_register_funcptr (void *ptr, gchar * ptrname) { + g_static_mutex_lock (&__dbg_functions_mutex); if (!__gst_function_pointers) __gst_function_pointers = g_hash_table_new (g_direct_hash, g_direct_equal); if (!g_hash_table_lookup (__gst_function_pointers, ptr)) g_hash_table_insert (__gst_function_pointers, ptr, ptrname); + g_static_mutex_unlock (&__dbg_functions_mutex); return ptr; } |
From: <tp...@fr...> - 2005-09-27 09:29:19
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Tue Sep 27 2005 02:29:16 PDT Log message: * gst/gsterror.h: Remove comment. GST_TYPE_G_ERROR is here to stay, G_TYPE_ERROR has been WONTFIX'ed by the GLib folks (#316961, #300610). Modified files: . : ChangeLog gst : gsterror.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1573&r2=1.1574 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsterror.h.diff?r1=1.18&r2=1.19 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1573 retrieving revision 1.1574 diff -u -d -r1.1573 -r1.1574 --- ChangeLog 26 Sep 2005 18:22:06 -0000 1.1573 +++ ChangeLog 27 Sep 2005 09:29:04 -0000 1.1574 @@ -1,3 +1,10 @@ +2005-09-27 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gsterror.h: + Remove comment. GST_TYPE_G_ERROR is here to stay, + G_TYPE_ERROR has been WONTFIX'ed by the GLib folks + (#316961, #300610). 2005-09-26 Wim Taymans <wi...@fl...> * check/gst/gstbin.c: (GST_START_TEST), (gst_bin_suite): Index: gsterror.h RCS file: /cvs/gstreamer/gstreamer/gst/gsterror.h,v retrieving revision 1.18 retrieving revision 1.19 diff -u -d -r1.18 -r1.19 --- gsterror.h 31 Aug 2005 14:08:45 -0000 1.18 +++ gsterror.h 27 Sep 2005 09:29:04 -0000 1.19 @@ -185,7 +185,6 @@ GST_STREAM_ERROR_NUM_ERRORS } GstStreamError; -/* This should go away once we convinced glib people to register GError */ #define GST_TYPE_G_ERROR (gst_g_error_get_type ()) #define GST_LIBRARY_ERROR gst_library_error_quark () |
From: <tp...@fr...> - 2005-10-02 23:01:24
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Sat Oct 01 2005 10:11:19 PDT Log message: Reviewed by: Tim-Philipp Müller <tim at centricular dot net> * gst/gstutils.c: (gst_pad_query_convert): Add assertion that makes sure src_val is >=0, just like gst_query_new_convert() has. (#315895) Modified files: . : ChangeLog gst : gstutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1609&r2=1.1610 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.92&r2=1.93 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1609 retrieving revision 1.1610 diff -u -d -r1.1609 -r1.1610 --- ChangeLog 30 Sep 2005 15:43:03 -0000 1.1609 +++ ChangeLog 1 Oct 2005 17:11:07 -0000 1.1610 @@ -1,3 +1,11 @@ +2005-10-01 Alessandro Decina <alessandro at nnva dot org> + + Reviewed by: Tim-Philipp Müller <tim at centricular dot net> + * gst/gstutils.c: (gst_pad_query_convert): + Add assertion that makes sure src_val is >=0, just like + gst_query_new_convert() has. (#315895) 2005-09-30 Edward Hervey <ed...@fl...> * gst/elements/gsttee.c: (gst_tee_do_push), (gst_tee_handle_buffer): Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.92 retrieving revision 1.93 diff -u -d -r1.92 -r1.93 --- gstutils.c 30 Sep 2005 08:00:12 -0000 1.92 +++ gstutils.c 1 Oct 2005 17:11:07 -0000 1.93 @@ -2409,6 +2409,7 @@ gboolean ret; g_return_val_if_fail (GST_IS_PAD (pad), FALSE); + g_return_val_if_fail (src_val >= 0, FALSE); g_return_val_if_fail (dest_format != NULL, FALSE); g_return_val_if_fail (dest_val != NULL, FALSE); |
From: <tp...@fr...> - 2005-10-10 15:27:21
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Oct 10 2005 08:27:24 PDT Log message: Reviewed by: Tim-Philipp Müller <tim at centricular dot net> * gst/gstbin.c: (gst_bin_iterate_sorted): Pass GType and size arguments to gst_iterator_new() in the right order (maybe we should make _new() take the GType as first argument just like _new_list()?) (#318447). Modified files: . : ChangeLog gst : gstbin.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1677&r2=1.1678 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstbin.c.diff?r1=1.280&r2=1.281 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1677 retrieving revision 1.1678 diff -u -d -r1.1677 -r1.1678 --- ChangeLog 10 Oct 2005 15:17:35 -0000 1.1677 +++ ChangeLog 10 Oct 2005 15:27:11 -0000 1.1678 @@ -1,3 +1,13 @@ +2005-10-10 Josef Zlomek <josef dot zlomek at xeris dot cz> + + Reviewed by: Tim-Philipp Müller <tim at centricular dot net> + * gst/gstbin.c: (gst_bin_iterate_sorted): + Pass GType and size arguments to gst_iterator_new() in the right + order (maybe we should make _new() take the GType as first argument + just like _new_list()?) (#318447). + 2005-10-10 Wim Taymans <wi...@fl...> * gst/gstelement.c: (gst_element_finalize): Index: gstbin.c RCS file: /cvs/gstreamer/gstreamer/gst/gstbin.c,v retrieving revision 1.280 retrieving revision 1.281 diff -u -d -r1.280 -r1.281 --- gstbin.c 10 Oct 2005 11:52:58 -0000 1.280 +++ gstbin.c 10 Oct 2005 15:27:12 -0000 1.281 @@ -1286,8 +1286,8 @@ /* we don't need a NextFunction because we ref the items in the _next * method already */ result = (GstBinSortIterator *) - gst_iterator_new (GST_TYPE_ELEMENT, - sizeof (GstBinSortIterator), + gst_iterator_new (sizeof (GstBinSortIterator), + GST_TYPE_ELEMENT, GST_GET_LOCK (bin), &bin->children_cookie, (GstIteratorNextFunction) gst_bin_sort_iterator_next, |
From: <tp...@fr...> - 2005-10-10 15:30:54
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Oct 10 2005 08:30:57 PDT Log message: * gst/gstiterator.c: (gst_iterator_new): Add assertions to make sure passed GType is likely to really be a GType (as the compiler won't catch it if the size and GType arguments get mixed up, see #318447). Modified files: . : ChangeLog gst : gstiterator.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1678&r2=1.1679 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstiterator.c.diff?r1=1.9&r2=1.10 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1678 retrieving revision 1.1679 diff -u -d -r1.1678 -r1.1679 --- ChangeLog 10 Oct 2005 15:27:11 -0000 1.1678 +++ ChangeLog 10 Oct 2005 15:30:45 -0000 1.1679 @@ -1,3 +1,10 @@ +2005-10-10 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstiterator.c: (gst_iterator_new): + Add assertions to make sure passed GType is likely to really + be a GType (as the compiler won't catch it if the size and + GType arguments get mixed up, see #318447). 2005-10-10 Josef Zlomek <josef dot zlomek at xeris dot cz> Reviewed by: Tim-Philipp Müller <tim at centricular dot net> Index: gstiterator.c RCS file: /cvs/gstreamer/gstreamer/gst/gstiterator.c,v retrieving revision 1.9 retrieving revision 1.10 diff -u -d -r1.9 -r1.10 --- gstiterator.c 7 Oct 2005 00:14:45 -0000 1.9 +++ gstiterator.c 10 Oct 2005 15:30:45 -0000 1.10 @@ -87,6 +87,8 @@ GstIterator *result; g_return_val_if_fail (size >= sizeof (GstIterator), NULL); + g_return_val_if_fail (G_TYPE_IS_FUNDAMENTAL (type) == FALSE, NULL); + g_return_val_if_fail (g_type_qname (type) != 0, NULL); g_return_val_if_fail (master_cookie != NULL, NULL); g_return_val_if_fail (next != NULL, NULL); g_return_val_if_fail (resync != NULL, NULL); |
From: <tp...@fr...> - 2005-10-10 15:58:47
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Oct 10 2005 08:58:44 PDT Log message: * gst/gstiterator.c: (gst_iterator_new): Fix my previous commit: GTypes passed to gst_iterator_new() can be fundamental types. Modified files: . : ChangeLog gst : gstiterator.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1681&r2=1.1682 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstiterator.c.diff?r1=1.10&r2=1.11 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1681 retrieving revision 1.1682 diff -u -d -r1.1681 -r1.1682 --- ChangeLog 10 Oct 2005 15:55:36 -0000 1.1681 +++ ChangeLog 10 Oct 2005 15:58:32 -0000 1.1682 @@ -1,3 +1,9 @@ +2005-10-10 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstiterator.c: (gst_iterator_new): + Fix my previous commit: GTypes passed to gst_iterator_new() + can be fundamental types. 2005-10-10 Wim Taymans <wi...@fl...> * gst/gstelement.c: (gst_element_iterate_pad_list), Index: gstiterator.c RCS file: /cvs/gstreamer/gstreamer/gst/gstiterator.c,v retrieving revision 1.10 retrieving revision 1.11 diff -u -d -r1.10 -r1.11 --- gstiterator.c 10 Oct 2005 15:30:45 -0000 1.10 +++ gstiterator.c 10 Oct 2005 15:58:32 -0000 1.11 @@ -87,7 +87,6 @@ GstIterator *result; g_return_val_if_fail (size >= sizeof (GstIterator), NULL); - g_return_val_if_fail (G_TYPE_IS_FUNDAMENTAL (type) == FALSE, NULL); g_return_val_if_fail (g_type_qname (type) != 0, NULL); g_return_val_if_fail (master_cookie != NULL, NULL); g_return_val_if_fail (next != NULL, NULL); |
From: <tp...@fr...> - 2005-10-15 22:24:34
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Sat Oct 15 2005 15:24:33 PDT Log message: * gst/gstevent.h: Oops, add missing closing bracket. Modified files: . : ChangeLog gst : gstevent.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1741&r2=1.1742 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstevent.h.diff?r1=1.78&r2=1.79 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1741 retrieving revision 1.1742 diff -u -d -r1.1741 -r1.1742 --- ChangeLog 15 Oct 2005 21:41:20 -0000 1.1741 +++ ChangeLog 15 Oct 2005 22:24:20 -0000 1.1742 @@ -1,3 +1,8 @@ +2005-10-15 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstevent.h: + Oops, add missing closing bracket. 2005-10-15 Thomas Vander Stichele <thomas at apestaart dot org> * configure.ac: Index: gstevent.h RCS file: /cvs/gstreamer/gstreamer/gst/gstevent.h,v retrieving revision 1.78 retrieving revision 1.79 diff -u -d -r1.78 -r1.79 --- gstevent.h 15 Oct 2005 20:33:09 -0000 1.78 +++ gstevent.h 15 Oct 2005 22:24:20 -0000 1.79 @@ -135,7 +135,7 @@ * * Get a constant string representation of the #GstEventType of the event. */ -#define GST_EVENT_TYPE_NAME(event) (gst_event_type_get_name(GST_EVENT_TYPE(event)) +#define GST_EVENT_TYPE_NAME(event) (gst_event_type_get_name(GST_EVENT_TYPE(event))) /** * GST_EVENT_TIMESTAMP: |
From: <tp...@fr...> - 2005-11-03 12:17:08
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Thu Nov 03 2005 04:17:01 PST Log message: * gst/gstbus.c: (gst_bus_class_init): Fix some typos. * gst/gstqueue.c: (gst_queue_loop): Don't assume a miniobject that isn't a buffer is an event (it could be that there is a refcounting problem somewhere and the pointer is stale and refers to an already destroyed miniobject). Modified files: . : ChangeLog gst : gstbus.c gstqueue.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1821&r2=1.1822 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstbus.c.diff?r1=1.44&r2=1.45 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstqueue.c.diff?r1=1.158&r2=1.159 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1821 retrieving revision 1.1822 diff -u -d -r1.1821 -r1.1822 --- ChangeLog 3 Nov 2005 10:56:23 -0000 1.1821 +++ ChangeLog 3 Nov 2005 12:16:49 -0000 1.1822 @@ -1,3 +1,14 @@ +2005-11-03 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstbus.c: (gst_bus_class_init): + Fix some typos. + + * gst/gstqueue.c: (gst_queue_loop): + Don't assume a miniobject that isn't a buffer is an + event (it could be that there is a refcounting + problem somewhere and the pointer is stale and + refers to an already destroyed miniobject). 2005-11-03 Julien MOUTTE <ju...@mo...> * gst/gstpad.c: (gst_pad_alloc_buffer): Fix some typos. Index: gstbus.c RCS file: /cvs/gstreamer/gstreamer/gst/gstbus.c,v retrieving revision 1.44 retrieving revision 1.45 diff -u -d -r1.44 -r1.45 --- gstbus.c 28 Oct 2005 18:18:23 -0000 1.44 +++ gstbus.c 3 Nov 2005 12:16:49 -0000 1.45 @@ -172,7 +172,7 @@ * @bus: the object which received the signal * @message: the message that has been posted synchronously * - * A message has been posted on the bus. This signal is emited from the + * A message has been posted on the bus. This signal is emitted from the * thread that posted the message so one has to be carefull with locking. */ gst_bus_signals[SYNC_MESSAGE] = @@ -186,7 +186,7 @@ * @message: the message that has been posted asynchronously - * A message has been posted on the bus. This signal is emited from a + * A message has been posted on the bus. This signal is emitted from a * GSource added to the mainloop. gst_bus_signals[ASYNC_MESSAGE] = Index: gstqueue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstqueue.c,v retrieving revision 1.158 retrieving revision 1.159 diff -u -d -r1.158 -r1.159 --- gstqueue.c 31 Oct 2005 09:52:13 -0000 1.158 +++ gstqueue.c 3 Nov 2005 12:16:49 -0000 1.159 @@ -824,7 +824,7 @@ GST_DEBUG_OBJECT (queue, "pausing queue, reason %s", flowname); gst_pad_pause_task (queue->srcpad); } - } else { + } else if (GST_IS_EVENT (data)) { if (GST_EVENT_TYPE (data) == GST_EVENT_EOS) { queue->cur_level.buffers = 0; queue->cur_level.bytes = 0; @@ -841,6 +841,9 @@ GST_QUEUE_MUTEX_LOCK_CHECK (queue, out_flushing); if (restart == TRUE) goto restart; + } else { + g_warning ("Unexpected object in queue %s (refcounting problem?)", + GST_OBJECT_NAME (queue)); } STATUS (queue, "after _get()"); |
From: <tp...@fr...> - 2005-11-03 13:53:15
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Thu Nov 03 2005 05:53:11 PST Log message: * gst/gstminiobject.h: * gst/gstobject.h: Add !! to _FLAG_IS_SET macros to make the result boolean. Modified files: . : ChangeLog gst : gstminiobject.h gstobject.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1823&r2=1.1824 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstminiobject.h.diff?r1=1.9&r2=1.10 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstobject.h.diff?r1=1.67&r2=1.68 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1823 retrieving revision 1.1824 diff -u -d -r1.1823 -r1.1824 --- ChangeLog 3 Nov 2005 12:48:29 -0000 1.1823 +++ ChangeLog 3 Nov 2005 13:52:59 -0000 1.1824 @@ -1,3 +1,9 @@ +2005-11-03 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstminiobject.h: + * gst/gstobject.h: + Add !! to _FLAG_IS_SET macros to make the result boolean. 2005-11-03 Edward Hervey <ed...@fl...> * gst/gstpad.c: (gst_pad_set_blocked_async): Index: gstminiobject.h RCS file: /cvs/gstreamer/gstreamer/gst/gstminiobject.h,v retrieving revision 1.9 retrieving revision 1.10 diff -u -d -r1.9 -r1.10 --- gstminiobject.h 28 Oct 2005 16:46:58 -0000 1.9 +++ gstminiobject.h 3 Nov 2005 13:52:59 -0000 1.10 @@ -72,7 +72,7 @@ * * This macro checks to see if the given flag is set. */ -#define GST_MINI_OBJECT_FLAG_IS_SET(obj,flag) (GST_MINI_OBJECT_FLAGS (obj) & (flag)) +#define GST_MINI_OBJECT_FLAG_IS_SET(obj,flag) !!(GST_MINI_OBJECT_FLAGS (obj) & (flag)) /** * GST_MINI_OBJECT_FLAG_SET: * @obj: MiniObject to set flag in. Index: gstobject.h RCS file: /cvs/gstreamer/gstreamer/gst/gstobject.h,v retrieving revision 1.67 retrieving revision 1.68 diff -u -d -r1.67 -r1.68 --- gstobject.h 15 Oct 2005 16:33:09 -0000 1.67 +++ gstobject.h 3 Nov 2005 13:52:59 -0000 1.68 @@ -147,7 +147,7 @@ -#define GST_OBJECT_FLAG_IS_SET(obj,flag) (GST_OBJECT_FLAGS (obj) & (flag)) +#define GST_OBJECT_FLAG_IS_SET(obj,flag) !!(GST_OBJECT_FLAGS (obj) & (flag)) * GST_OBJECT_FLAG_SET: * @obj: Object to set flag in. |
From: <tp...@fr...> - 2005-11-15 19:25:02
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Tue Nov 15 2005 11:24:58 PST Log message: Reviewed by: Tim-Philipp Müller <tim at centricular dot net> * gst/gstpad.c: (gst_pad_get_property): GST_PAD_PAD_TEMPLATE(pad) gets the pad template, while GST_PAD_TEMPLATE(pad) does a cast. We want the former here. (#321452) Modified files: . : ChangeLog gst : gstpad.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1889&r2=1.1890 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpad.c.diff?r1=1.474&r2=1.475 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1889 retrieving revision 1.1890 diff -u -d -r1.1889 -r1.1890 --- ChangeLog 15 Nov 2005 18:34:28 -0000 1.1889 +++ ChangeLog 15 Nov 2005 19:24:45 -0000 1.1890 @@ -1,3 +1,12 @@ +2005-11-15 Daniel Fischer <dan at f3c dot com> + + Reviewed by: Tim-Philipp Müller <tim at centricular dot net> + * gst/gstpad.c: (gst_pad_get_property): + GST_PAD_PAD_TEMPLATE(pad) gets the pad template, while + GST_PAD_TEMPLATE(pad) does a cast. We want the former here. + (#321452) 2005-11-15 Wim Taymans <wi...@fl...> * gst/gstevent.c: Index: gstpad.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpad.c,v retrieving revision 1.474 retrieving revision 1.475 diff -u -d -r1.474 -r1.475 --- gstpad.c 14 Nov 2005 12:43:43 -0000 1.474 +++ gstpad.c 15 Nov 2005 19:24:46 -0000 1.475 @@ -440,7 +440,7 @@ g_value_set_enum (value, GST_PAD_DIRECTION (object)); break; case PAD_PROP_TEMPLATE: - g_value_set_object (value, GST_PAD_TEMPLATE (object)); + g_value_set_object (value, GST_PAD_PAD_TEMPLATE (object)); default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); |
From: <tp...@fr...> - 2005-11-17 09:38:09
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Thu Nov 17 2005 01:38:07 PST Log message: Reviewed by: Tim-Philipp Müller <tim at centricular dot net> * gst/gstmessage.c: (gst_message_parse_clock_lost): Assertion should check for CLOCK_LOST, not NEW_CLOCK (#321648). * gst/gstpadtemplate.h: * gst/gstpluginfeature.h: Don't use c++ style comments in headers (#321638). Modified files: . : ChangeLog gst : gstmessage.c gstpadtemplate.h gstpluginfeature.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1908&r2=1.1909 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstmessage.c.diff?r1=1.48&r2=1.49 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpadtemplate.h.diff?r1=1.4&r2=1.5 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpluginfeature.h.diff?r1=1.22&r2=1.23 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1908 retrieving revision 1.1909 diff -u -d -r1.1908 -r1.1909 --- ChangeLog 16 Nov 2005 18:37:57 -0000 1.1908 +++ ChangeLog 17 Nov 2005 09:37:54 -0000 1.1909 @@ -1,3 +1,14 @@ +2005-11-17 Torsten Schoenfeld <kaffeetisch at gmx dot net> + + Reviewed by: Tim-Philipp Müller <tim at centricular dot net> + * gst/gstmessage.c: (gst_message_parse_clock_lost): + Assertion should check for CLOCK_LOST, not NEW_CLOCK (#321648). + * gst/gstpadtemplate.h: + * gst/gstpluginfeature.h: + Don't use c++ style comments in headers (#321638). 2005-11-16 Andy Wingo <wi...@po...> * gst/net/gstnettimepacket.c (gst_net_time_packet_send): Free Index: gstmessage.c RCS file: /cvs/gstreamer/gstreamer/gst/gstmessage.c,v retrieving revision 1.48 retrieving revision 1.49 diff -u -d -r1.48 -r1.49 --- gstmessage.c 9 Nov 2005 16:00:04 -0000 1.48 +++ gstmessage.c 17 Nov 2005 09:37:55 -0000 1.49 @@ -770,7 +770,7 @@ const GValue *clock_gvalue; g_return_if_fail (GST_IS_MESSAGE (message)); - g_return_if_fail (GST_MESSAGE_TYPE (message) == GST_MESSAGE_NEW_CLOCK); + g_return_if_fail (GST_MESSAGE_TYPE (message) == GST_MESSAGE_CLOCK_LOST); clock_gvalue = gst_structure_get_value (message->structure, "clock"); g_return_if_fail (clock_gvalue != NULL); Index: gstpadtemplate.h RCS file: /cvs/gstreamer/gstreamer/gst/gstpadtemplate.h,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- gstpadtemplate.h 15 Oct 2005 15:30:22 -0000 1.4 +++ gstpadtemplate.h 17 Nov 2005 09:37:55 -0000 1.5 @@ -36,7 +36,7 @@ G_BEGIN_DECLS /* FIXME: this awful circular dependency need to be resolved properly (see pad.h) */ -//typedef struct _GstPadTemplate GstPadTemplate; +/*typedef struct _GstPadTemplate GstPadTemplate; */ typedef struct _GstPadTemplateClass GstPadTemplateClass; typedef struct _GstStaticPadTemplate GstStaticPadTemplate; Index: gstpluginfeature.h RCS file: /cvs/gstreamer/gstreamer/gst/gstpluginfeature.h,v retrieving revision 1.22 retrieving revision 1.23 diff -u -d -r1.22 -r1.23 --- gstpluginfeature.h 14 Oct 2005 11:09:29 -0000 1.22 +++ gstpluginfeature.h 17 Nov 2005 09:37:55 -0000 1.23 @@ -77,7 +77,7 @@ gchar *name; guint rank; - //struct _GstPlugin *plugin; + /* struct _GstPlugin *plugin; */ gchar *plugin_name; /*< private >*/ |
From: <tp...@fr...> - 2005-11-21 10:41:25
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Nov 21 2005 02:41:15 PST Log message: * gst/gstmessage.c: Improve docs for DURATION message (usage of duration parameter) (#320113) Modified files: . : ChangeLog gst : gstmessage.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1946&r2=1.1947 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstmessage.c.diff?r1=1.49&r2=1.50 ====Begin Diffs==== Index: gstmessage.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gstmessage.c,v retrieving revision 1.49 retrieving revision 1.50 diff -u -d -r1.49 -r1.50 --- gstmessage.c 17 Nov 2005 09:37:55 -0000 1.49 +++ gstmessage.c 21 Nov 2005 10:41:03 -0000 1.50 @@ -637,7 +637,10 @@ * Create a new duration message. This message is posted by elements that * know the duration of a stream in a specific format. This message * is received by bins and is used to calculate the total duration of a - * pipeline. + * pipeline. Elements may post a duration message with a duration of + * GST_CLOCK_TIME_NONE to indicate that the duration has changed and the + * cached duration should be discarded. The new duration can then be + * retrieved via a query. * * Returns: The new duration message. @@ -932,7 +935,10 @@ * @format: Result location for the format * @duration: Result location for the duration - * Extracts the duration and format from the duration message. + * Extracts the duration and format from the duration message. The duration + * might be GST_CLOCK_TIME_NONE, which indicates that the duration has + * changed. Applications should always use a query to retrieve the duration + * of a pipeline. * MT safe. */ Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1946 retrieving revision 1.1947 diff -u -d -r1.1946 -r1.1947 --- ChangeLog 20 Nov 2005 19:11:08 -0000 1.1946 +++ ChangeLog 21 Nov 2005 10:41:02 -0000 1.1947 @@ -1,3 +1,9 @@ +2005-11-21 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstmessage.c: + Improve docs for DURATION message (usage of duration parameter) + (#320113) 2005-11-20 Wim Taymans <wi...@fl...> * check/Makefile.am: |
From: <tp...@fr...> - 2005-11-21 12:42:55
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Nov 21 2005 04:42:53 PST Log message: * gst/gstvalue.c: (gst_value_is_fixed): Should handle both value arrays and value lists. Modified files: . : ChangeLog gst : gstvalue.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1951&r2=1.1952 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.89&r2=1.90 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1951 retrieving revision 1.1952 diff -u -d -r1.1951 -r1.1952 --- ChangeLog 21 Nov 2005 12:27:00 -0000 1.1951 +++ ChangeLog 21 Nov 2005 12:42:40 -0000 1.1952 @@ -1,3 +1,8 @@ +2005-11-21 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstvalue.c: (gst_value_is_fixed): + Should handle both value arrays and value lists. 2005-11-21 Andy Wingo <wi...@po...> patch by: Alessandro Dessina <alessandro nnva org> Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.89 retrieving revision 1.90 diff -u -d -r1.89 -r1.90 --- gstvalue.c 21 Nov 2005 12:27:01 -0000 1.89 +++ gstvalue.c 21 Nov 2005 12:42:41 -0000 1.90 @@ -2691,6 +2691,21 @@ return fixed; } + if (type == GST_TYPE_LIST) { + gboolean fixed = TRUE; + gint size, n; + const GValue *kid; + /* check recursively */ + size = gst_value_list_get_size (value); + for (n = 0; n < size; n++) { + kid = gst_value_list_get_value (value, n); + fixed &= gst_value_is_fixed (kid); + } + return fixed; + } return gst_type_is_fixed (type); } |
From: <tp...@fr...> - 2005-11-21 13:12:44
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Nov 21 2005 05:12:30 PST Log message: * gst/gstvalue.c: (gst_value_is_fixed): Revert previous commit. Value lists are by definition not fixed, as they are a list of possible values. Modified files: . : ChangeLog gst : gstvalue.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1953&r2=1.1954 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.90&r2=1.91 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1953 retrieving revision 1.1954 diff -u -d -r1.1953 -r1.1954 --- ChangeLog 21 Nov 2005 13:03:36 -0000 1.1953 +++ ChangeLog 21 Nov 2005 13:12:18 -0000 1.1954 @@ -1,3 +1,9 @@ +2005-11-21 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstvalue.c: (gst_value_is_fixed): + Revert previous commit. Value lists are by definition + not fixed, as they are a list of possible values. 2005-11-21 Andy Wingo <wi...@po...> * gst/gstevent.h (GST_EVENT_FILLER): Removed. Can be added back Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.90 retrieving revision 1.91 diff -u -d -r1.90 -r1.91 --- gstvalue.c 21 Nov 2005 12:42:41 -0000 1.90 +++ gstvalue.c 21 Nov 2005 13:12:18 -0000 1.91 @@ -2691,21 +2691,6 @@ return fixed; } - if (type == GST_TYPE_LIST) { - gboolean fixed = TRUE; - gint size, n; - const GValue *kid; - - /* check recursively */ - size = gst_value_list_get_size (value); - for (n = 0; n < size; n++) { - kid = gst_value_list_get_value (value, n); - fixed &= gst_value_is_fixed (kid); - } - return fixed; - } return gst_type_is_fixed (type); } |
From: <tp...@fr...> - 2005-11-21 13:26:55
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Mon Nov 21 2005 05:26:53 PST Log message: * gst/gstvalue.c: (gst_value_transform_fourcc_string), (gst_value_serialize_fourcc): * gst/gstvalue.h: Drop leading '%' from GST_FOURCC_FORMAT, thus making it consistent with our other format defines (#320324). Modified files: . : ChangeLog gst : gstvalue.c gstvalue.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.1954&r2=1.1955 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.91&r2=1.92 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.h.diff?r1=1.38&r2=1.39 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.1954 retrieving revision 1.1955 diff -u -d -r1.1954 -r1.1955 --- ChangeLog 21 Nov 2005 13:12:18 -0000 1.1954 +++ ChangeLog 21 Nov 2005 13:26:40 -0000 1.1955 @@ -1,5 +1,13 @@ 2005-11-21 Tim-Philipp Müller <tim at centricular dot net> + * gst/gstvalue.c: (gst_value_transform_fourcc_string), + (gst_value_serialize_fourcc): + * gst/gstvalue.h: + Drop leading '%' from GST_FOURCC_FORMAT, thus making it + consistent with our other format defines (#320324). + +2005-11-21 Tim-Philipp Müller <tim at centricular dot net> * gst/gstvalue.c: (gst_value_is_fixed): Revert previous commit. Value lists are by definition not fixed, as they are a list of possible values. Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.91 retrieving revision 1.92 diff -u -d -r1.91 -r1.92 --- gstvalue.c 21 Nov 2005 13:12:18 -0000 1.91 +++ gstvalue.c 21 Nov 2005 13:26:40 -0000 1.92 @@ -580,7 +580,7 @@ g_ascii_isprint ((fourcc >> 16) & 0xff) && g_ascii_isprint ((fourcc >> 24) & 0xff)) { dest_value->data[0].v_pointer = - g_strdup_printf (GST_FOURCC_FORMAT, GST_FOURCC_ARGS (fourcc)); + g_strdup_printf ("%" GST_FOURCC_FORMAT, GST_FOURCC_ARGS (fourcc)); } else { dest_value->data[0].v_pointer = g_strdup_printf ("0x%08x", fourcc); } @@ -603,7 +603,7 @@ g_ascii_isalnum ((fourcc >> 8) & 0xff) && g_ascii_isalnum ((fourcc >> 16) & 0xff) && g_ascii_isalnum ((fourcc >> 24) & 0xff)) { - return g_strdup_printf (GST_FOURCC_FORMAT, GST_FOURCC_ARGS (fourcc)); + return g_strdup_printf ("%" GST_FOURCC_FORMAT, GST_FOURCC_ARGS (fourcc)); return g_strdup_printf ("0x%08x", fourcc); Index: gstvalue.h RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.h,v retrieving revision 1.38 retrieving revision 1.39 diff -u -d -r1.38 -r1.39 --- gstvalue.h 19 Nov 2005 16:46:30 -0000 1.38 +++ gstvalue.h 21 Nov 2005 13:26:40 -0000 1.39 @@ -69,7 +69,7 @@ * </programlisting> * </informalexample> */ -#define GST_FOURCC_FORMAT "%c%c%c%c" +#define GST_FOURCC_FORMAT "c%c%c%c" /** * GST_FOURCC_ARGS: |
From: <tp...@fr...> - 2005-11-27 18:11:25
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Sun Nov 27 2005 10:11:14 PST Log message: * gst/gstvalue.c: (gst_value_serialize_any_list), (gst_value_transform_any_list_string), (gst_value_deserialize_list), (gst_value_deserialize_array), (gst_value_set_int_range), (gst_value_deserialize_int_range), (gst_value_set_double_range), (gst_value_deserialize_double_range), (gst_value_set_fraction_range_full), (gst_value_deserialize_fraction_range), (gst_value_deserialize_caps), (gst_value_deserialize_buffer), (gst_value_deserialize_boolean), (gst_value_deserialize_int_helper), (gst_value_deserialize_double), (gst_value_serialize_float), (gst_value_deserialize_float), (gst_string_wrap), (gst_value_deserialize_string), (gst_value_deserialize_enum), (gst_value_deserialize_flags), (gst_value_union_int_range_int_range), (gst_value_intersect_int_range_int_range), (gst_value_intersect_double_range_double_range), (gst_value_create_new_range), (gst_value_subtract_int_range_int), (gst_value_subtract_int_range_int_range), (gst_value_subtract_double_double_range), (gst_value_subtract_double_range_double_range), (gst_value_deserialize_fraction): * gst/gstvalue.h: Use gint, gdouble and gchar in our API instead of int, double and char (and make usage in gstvalue.c more consistent). Modified files: . : ChangeLog gst : gstvalue.c gstvalue.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.2022&r2=1.2023 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.102&r2=1.103 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.h.diff?r1=1.41&r2=1.42 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.2022 retrieving revision 1.2023 diff -u -d -r1.2022 -r1.2023 --- ChangeLog 27 Nov 2005 16:46:47 -0000 1.2022 +++ ChangeLog 27 Nov 2005 18:11:02 -0000 1.2023 @@ -1,3 +1,30 @@ +2005-11-27 Tim-Philipp Müller <tim at centricular dot net> + + * gst/gstvalue.c: (gst_value_serialize_any_list), + (gst_value_transform_any_list_string), + (gst_value_deserialize_list), (gst_value_deserialize_array), + (gst_value_set_int_range), (gst_value_deserialize_int_range), + (gst_value_set_double_range), (gst_value_deserialize_double_range), + (gst_value_set_fraction_range_full), + (gst_value_deserialize_fraction_range), + (gst_value_deserialize_caps), (gst_value_deserialize_buffer), + (gst_value_deserialize_boolean), + (gst_value_deserialize_int_helper), (gst_value_deserialize_double), + (gst_value_serialize_float), (gst_value_deserialize_float), + (gst_string_wrap), (gst_value_deserialize_string), + (gst_value_deserialize_enum), (gst_value_deserialize_flags), + (gst_value_union_int_range_int_range), + (gst_value_intersect_int_range_int_range), + (gst_value_intersect_double_range_double_range), + (gst_value_create_new_range), (gst_value_subtract_int_range_int), + (gst_value_subtract_int_range_int_range), + (gst_value_subtract_double_double_range), + (gst_value_subtract_double_range_double_range), + (gst_value_deserialize_fraction): + * gst/gstvalue.h: + Use gint, gdouble and gchar in our API instead of int, double and + char (and make usage in gstvalue.c more consistent). 2005-11-27 Thomas Vander Stichele <thomas at apestaart dot org> * check/Makefile.am: Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.102 retrieving revision 1.103 diff -u -d -r1.102 -r1.103 --- gstvalue.c 24 Nov 2005 09:44:06 -0000 1.102 +++ gstvalue.c 27 Nov 2005 18:11:02 -0000 1.103 @@ -77,7 +77,7 @@ /* Forward declarations */ static gint gst_greatest_common_divisor (gint a, gint b); -static char *gst_value_serialize_fraction (const GValue * value); +static gchar *gst_value_serialize_fraction (const GValue * value); /******** * list * @@ -86,9 +86,9 @@ /* two helper functions to serialize/stringify any type of list * regular lists are done with { }, arrays with < > */ -static char * -gst_value_serialize_any_list (const GValue * value, const char *begin, - const char *end) +static gchar * +gst_value_serialize_any_list (const GValue * value, const gchar * begin, + const gchar * end) { guint i; GArray *array = value->data[0].v_pointer; @@ -112,13 +112,13 @@ static void gst_value_transform_any_list_string (const GValue * src_value, - GValue * dest_value, const char *begin, const char *end) + GValue * dest_value, const gchar * begin, const gchar * end) GValue *list_value; GArray *array; GString *s; - char *list_s; + gchar *list_s; array = src_value->data[0].v_pointer; @@ -480,27 +480,27 @@ return GST_VALUE_EQUAL; } gst_value_serialize_list (const GValue * value) return gst_value_serialize_any_list (value, "{ ", " }"); static gboolean -gst_value_deserialize_list (GValue * dest, const char *s) +gst_value_deserialize_list (GValue * dest, const gchar * s) g_warning ("unimplemented"); return FALSE; gst_value_serialize_array (const GValue * value) return gst_value_serialize_any_list (value, "< ", " >"); -gst_value_deserialize_array (GValue * dest, const char *s) +gst_value_deserialize_array (GValue * dest, const gchar * s) @@ -594,7 +594,7 @@ } -static int +static gint gst_value_compare_fourcc (const GValue * value1, const GValue * value2) if (value2->data[0].v_int == value1->data[0].v_int) @@ -602,7 +602,7 @@ return GST_VALUE_UNORDERED; gst_value_serialize_fourcc (const GValue * value) guint32 fourcc = value->data[0].v_int; @@ -695,7 +695,7 @@ * Sets @value to the range specified by @start and @end. void -gst_value_set_int_range (GValue * value, int start, int end) +gst_value_set_int_range (GValue * value, gint start, gint end) g_return_if_fail (GST_VALUE_HOLDS_INT_RANGE (value)); g_return_if_fail (start < end); @@ -712,7 +712,7 @@ * * Returns: the minimum of the range -int +gint gst_value_get_int_range_min (const GValue * value) g_return_val_if_fail (GST_VALUE_HOLDS_INT_RANGE (value), 0); @@ -728,7 +728,7 @@ * Returns: the maxumum of the range gst_value_get_int_range_max (const GValue * value) @@ -744,7 +744,7 @@ (int) src_value->data[0].v_int, (int) src_value->data[1].v_int); gst_value_compare_int_range (const GValue * value1, const GValue * value2) if (value2->data[0].v_int == value1->data[0].v_int && @@ -753,7 +753,7 @@ gst_value_serialize_int_range (const GValue * value) return g_strdup_printf ("[ %d, %d ]", value->data[0].v_int, @@ -761,7 +761,7 @@ -gst_value_deserialize_int_range (GValue * dest, const char *s) +gst_value_deserialize_int_range (GValue * dest, const gchar * s) @@ -824,7 +824,7 @@ -gst_value_set_double_range (GValue * value, double start, double end) +gst_value_set_double_range (GValue * value, gdouble start, gdouble end) g_return_if_fail (GST_VALUE_HOLDS_DOUBLE_RANGE (value)); @@ -840,7 +840,7 @@ * Returns: the minumum of the range -double +gdouble gst_value_get_double_range_min (const GValue * value) g_return_val_if_fail (GST_VALUE_HOLDS_DOUBLE_RANGE (value), 0); @@ -856,7 +856,7 @@ gst_value_get_double_range_max (const GValue * value) @@ -877,7 +877,7 @@ src_value->data[1].v_double)); gst_value_compare_double_range (const GValue * value1, const GValue * value2) if (value2->data[0].v_double == value1->data[0].v_double && @@ -886,7 +886,7 @@ gst_value_serialize_double_range (const GValue * value) char d1[G_ASCII_DTOSTR_BUF_SIZE]; @@ -898,7 +898,7 @@ -gst_value_deserialize_double_range (GValue * dest, const char *s) +gst_value_deserialize_double_range (GValue * dest, const gchar * s) @@ -1048,8 +1048,8 @@ gst_value_set_fraction_range_full (GValue * value, - int numerator_start, int denominator_start, - int numerator_end, int denominator_end) + gint numerator_start, gint denominator_start, + gint numerator_end, gint denominator_end) GValue start = { 0 }; GValue end = { 0 }; @@ -1141,7 +1141,7 @@ gst_value_serialize_fraction_range (src_value); gst_value_compare_fraction_range (const GValue * value1, const GValue * value2) GValue *vals1, *vals2; @@ -1162,7 +1162,7 @@ -gst_value_deserialize_fraction_range (GValue * dest, const char *s) +gst_value_deserialize_fraction_range (GValue * dest, const gchar * s) @@ -1213,7 +1213,7 @@ -gst_value_deserialize_caps (GValue * dest, const char *s) +gst_value_deserialize_caps (GValue * dest, const gchar * s) GstCaps *caps; @@ -1272,7 +1272,7 @@ -gst_value_deserialize_buffer (GValue * dest, const char *s) +gst_value_deserialize_buffer (GValue * dest, const gchar * s) GstBuffer *buffer; gboolean ret = TRUE; @@ -1330,7 +1330,7 @@ -gst_value_deserialize_boolean (GValue * dest, const char *s) +gst_value_deserialize_boolean (GValue * dest, const gchar * s) gboolean ret = FALSE; @@ -1379,8 +1379,8 @@ * bytes. -gst_value_deserialize_int_helper (gint64 * to, const char *s, - gint64 min, gint64 max, int size) +gst_value_deserialize_int_helper (gint64 * to, const gchar * s, + gint64 min, gint64 max, gint size) char *end; @@ -1440,7 +1440,7 @@ CREATE_SERIALIZATION_START(_type,_macro) \ \ static gboolean \ -gst_value_deserialize_ ## _type (GValue * dest, const char *s) \ +gst_value_deserialize_ ## _type (GValue * dest, const gchar *s) \ { \ gint64 x; \ @@ -1457,7 +1457,7 @@ char *end; \ @@ -1546,7 +1546,7 @@ -gst_value_deserialize_double (GValue * dest, const char *s) +gst_value_deserialize_double (GValue * dest, const gchar * s) double x; @@ -1574,7 +1574,7 @@ * float * *********/ gst_value_compare_float (const GValue * value1, const GValue * value2) if (value1->data[0].v_float > value2->data[0].v_float) @@ -1586,17 +1586,17 @@ gst_value_serialize_float (const GValue * value) - char d[G_ASCII_DTOSTR_BUF_SIZE]; + gchar d[G_ASCII_DTOSTR_BUF_SIZE]; g_ascii_dtostr (d, G_ASCII_DTOSTR_BUF_SIZE, value->data[0].v_float); return g_strdup (d); -gst_value_deserialize_float (GValue * dest, const char *s) +gst_value_deserialize_float (GValue * dest, const gchar * s) @@ -1626,7 +1626,7 @@ * string * **********/ gst_value_compare_string (const GValue * value1, const GValue * value2) int x = strcmp (value1->data[0].v_pointer, value2->data[0].v_pointer); @@ -1643,7 +1643,7 @@ ((c) == '.')) static gchar * -gst_string_wrap (const char *s) +gst_string_wrap (const gchar * s) const gchar *t; int len; @@ -1705,7 +1705,7 @@ * the input string must be \0 terminated. gst_string_unwrap (const gchar * s) gchar *ret; @@ -1778,14 +1778,14 @@ return NULL; gst_value_serialize_string (const GValue * value) return gst_string_wrap (value->data[0].v_pointer); -gst_value_deserialize_string (GValue * dest, const char *s) +gst_value_deserialize_string (GValue * dest, const gchar * s) if (*s != '"') { if (!g_utf8_validate (s, -1, NULL)) @@ -1807,7 +1807,7 @@ * enum * ********/ gst_value_compare_enum (const GValue * value1, const GValue * value2) GEnumValue *en1, *en2; @@ -1830,7 +1830,7 @@ gst_value_serialize_enum (const GValue * value) GEnumValue *en; @@ -1844,7 +1844,7 @@ -gst_value_deserialize_enum (GValue * dest, const char *s) +gst_value_deserialize_enum (GValue * dest, const gchar * s) gchar *endptr = NULL; @@ -1871,7 +1871,7 @@ /* we just compare the value here */ gst_value_compare_flags (const GValue * value1, const GValue * value2) guint fl1, fl2; @@ -1895,7 +1895,7 @@ /* the different flags are serialized separated with a + */ gst_value_serialize_flags (const GValue * value) guint flags; @@ -1925,7 +1925,7 @@ -gst_value_deserialize_flags (GValue * dest, const char *s) +gst_value_deserialize_flags (GValue * dest, const gchar * s) GFlagsValue *fl; @@ -1985,8 +1985,8 @@ gst_value_union_int_range_int_range (GValue * dest, const GValue * src1, const GValue * src2) - int min; - int max; + gint min; + gint max; min = MAX (src1->data[0].v_int, src2->data[0].v_int); max = MIN (src1->data[1].v_int, src2->data[1].v_int); @@ -2023,8 +2023,8 @@ gst_value_intersect_int_range_int_range (GValue * dest, const GValue * src1, @@ -2060,8 +2060,8 @@ gst_value_intersect_double_range_double_range (GValue * dest, const GValue * src1, const GValue * src2) - double min; - double max; + gdouble min; + gdouble max; min = MAX (src1->data[0].v_double, src2->data[0].v_double); max = MIN (src1->data[1].v_double, src2->data[1].v_double); @@ -2236,8 +2236,8 @@ /* creates a new int range based on input values. -gst_value_create_new_range (GValue * dest, int min1, int max1, int min2, - int max2) +gst_value_create_new_range (GValue * dest, gint min1, gint max1, gint min2, + gint max2) GValue v1 = { 0, }; GValue v2 = { 0, }; @@ -2283,9 +2283,9 @@ gst_value_subtract_int_range_int (GValue * dest, const GValue * minuend, const GValue * subtrahend) - int min = gst_value_get_int_range_min (minuend); - int max = gst_value_get_int_range_max (minuend); - int val = g_value_get_int (subtrahend); + gint min = gst_value_get_int_range_min (minuend); + gint max = gst_value_get_int_range_max (minuend); + gint val = g_value_get_int (subtrahend); g_return_val_if_fail (min < max, FALSE); @@ -2313,10 +2313,10 @@ gst_value_subtract_int_range_int_range (GValue * dest, const GValue * minuend, - int min1 = gst_value_get_int_range_min (minuend); - int max1 = gst_value_get_int_range_max (minuend); - int min2 = gst_value_get_int_range_min (subtrahend); - int max2 = gst_value_get_int_range_max (subtrahend); + gint min1 = gst_value_get_int_range_min (minuend); + gint max1 = gst_value_get_int_range_max (minuend); + gint min2 = gst_value_get_int_range_min (subtrahend); + gint max2 = gst_value_get_int_range_max (subtrahend); if (max2 == G_MAXINT && min2 == G_MININT) { return FALSE; @@ -2334,9 +2334,9 @@ gst_value_subtract_double_double_range (GValue * dest, const GValue * minuend, - double min = gst_value_get_double_range_min (subtrahend); - double max = gst_value_get_double_range_max (subtrahend); - double val = g_value_get_double (minuend); + gdouble min = gst_value_get_double_range_min (subtrahend); + gdouble max = gst_value_get_double_range_max (subtrahend); + gdouble val = g_value_get_double (minuend); if (val < min || val > max) { gst_value_init_and_copy (dest, minuend); @@ -2361,10 +2361,10 @@ /* since we don't have open ranges, we have to approximate */ /* done like with ints */ - double min1 = gst_value_get_double_range_min (minuend); - double max2 = gst_value_get_double_range_max (minuend); - double max1 = MIN (gst_value_get_double_range_min (subtrahend), max2); - double min2 = MAX (gst_value_get_double_range_max (subtrahend), min1); + gdouble min1 = gst_value_get_double_range_min (minuend); + gdouble max2 = gst_value_get_double_range_max (minuend); + gdouble max1 = MIN (gst_value_get_double_range_min (subtrahend), max2); + gdouble min2 = MAX (gst_value_get_double_range_max (subtrahend), min1); GValue *pv1, *pv2; /* yeah, hungarian! */ @@ -3223,7 +3223,7 @@ * Returns: the numerator of the fraction. gst_value_get_fraction_numerator (const GValue * value) g_return_val_if_fail (GST_VALUE_HOLDS_FRACTION (value), 0); @@ -3239,7 +3239,7 @@ * Returns: the denominator of the fraction. gst_value_get_fraction_denominator (const GValue * value) g_return_val_if_fail (GST_VALUE_HOLDS_FRACTION (value), 1); @@ -3329,7 +3329,7 @@ return TRUE; gst_value_serialize_fraction (const GValue * value) gint32 numerator = value->data[0].v_int; @@ -3351,7 +3351,7 @@ -gst_value_deserialize_fraction (GValue * dest, const char *s) +gst_value_deserialize_fraction (GValue * dest, const gchar * s) gint num, den; @@ -3481,7 +3481,7 @@ ((double) src_value->data[1].v_int); gst_value_compare_fraction (const GValue * value1, const GValue * value2) gint n1, n2; @@ -3558,7 +3558,7 @@ return g_date_new_julian (g_date_get_julian (date)); gst_value_compare_date (const GValue * value1, const GValue * value2) const GDate *date1 = (const GDate *) g_value_get_boxed (value1); @@ -3594,7 +3594,7 @@ return GST_VALUE_GREATER_THAN; gst_value_serialize_date (const GValue * val) const GDate *date = (const GDate *) g_value_get_boxed (val); Index: gstvalue.h RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.h,v retrieving revision 1.41 retrieving revision 1.42 diff -u -d -r1.41 -r1.42 --- gstvalue.h 21 Nov 2005 23:54:59 -0000 1.41 +++ gstvalue.h 27 Nov 2005 18:11:02 -0000 1.42 @@ -281,7 +281,7 @@ * Returns: one of GST_VALUE_LESS_THAN, GST_VALUE_EQUAL, GST_VALUE_GREATER_THAN * or GST_VALUE_UNORDERED -typedef int (* GstValueCompareFunc) (const GValue *value1, +typedef gint (* GstValueCompareFunc) (const GValue *value1, const GValue *value2); /** @@ -292,7 +292,7 @@ * Returns: the string representation of the value -typedef char * (* GstValueSerializeFunc) (const GValue *value1); +typedef gchar * (* GstValueSerializeFunc) (const GValue *value1); * GstValueDeserializeFunc: @@ -304,7 +304,7 @@ * Returns: %TRUE for success typedef gboolean (* GstValueDeserializeFunc) (GValue *dest, - const char *s); + const gchar *s); * GstValueUnionFunc: @@ -318,7 +318,7 @@ * Returns: %TRUE if a union was successful /* FIXME: shouldn't the return value be gboolean ? */ -typedef int (* GstValueUnionFunc) (GValue *dest, +typedef gint (* GstValueUnionFunc) (GValue *dest, const GValue *value1, @@ -337,7 +337,7 @@ * Returns: %TRUE if the values can intersect -typedef int (* GstValueIntersectFunc) (GValue *dest, +typedef gint (* GstValueIntersectFunc) (GValue *dest, @@ -353,7 +353,7 @@ * Returns: %TRUE if the subtraction is not empty -typedef int (* GstValueSubtractFunc) (GValue *dest, +typedef gint (* GstValueSubtractFunc) (GValue *dest, const GValue *minuend, const GValue *subtrahend); @@ -425,17 +425,17 @@ /* int range */ void gst_value_set_int_range (GValue *value, - int start, - int end); -int gst_value_get_int_range_min (const GValue *value); -int gst_value_get_int_range_max (const GValue *value); + gint start, + gint end); +gint gst_value_get_int_range_min (const GValue *value); +gint gst_value_get_int_range_max (const GValue *value); /* double range */ void gst_value_set_double_range (GValue *value, - double start, - double end); -double gst_value_get_double_range_min (const GValue *value); -double gst_value_get_double_range_max (const GValue *value); + gdouble start, + gdouble end); +gdouble gst_value_get_double_range_min (const GValue *value); +gdouble gst_value_get_double_range_max (const GValue *value); /* caps */ G_CONST_RETURN GstCaps * @@ -445,10 +445,10 @@ /* fraction */ void gst_value_set_fraction (GValue *value, - int numerator, - int denominator); -int gst_value_get_fraction_numerator (const GValue *value); -int gst_value_get_fraction_denominator(const GValue *value); + gint numerator, + gint denominator); +gint gst_value_get_fraction_numerator (const GValue *value); +gint gst_value_get_fraction_denominator(const GValue *value); gboolean gst_value_fraction_multiply (GValue *product, const GValue *factor1, const GValue *factor2); @@ -461,10 +461,10 @@ const GValue *start, const GValue *end); void gst_value_set_fraction_range_full (GValue *value, - int numerator_start, - int denominator_start, - int numerator_end, - int denominator_end); + gint numerator_start, + gint denominator_start, + gint numerator_end, + gint denominator_end); const GValue *gst_value_get_fraction_range_min (const GValue *value); const GValue *gst_value_get_fraction_range_max (const GValue *value); @@ -475,7 +475,7 @@ const GDate *date); /* compare */ -int gst_value_compare (const GValue *value1, +gint gst_value_compare (const GValue *value1, const GValue *value2); gboolean gst_value_can_compare (const GValue *value1, |
From: <tp...@fr...> - 2005-11-27 19:53:04
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: tpm Date: Sun Nov 27 2005 11:53:01 PST Log message: * gst/gstvalue.c: Improve documentation for gst_value_union(). * gst/gstvalue.h: Change return value for union, intersect and subtract functions from gint to gboolean. Modified files: . : ChangeLog gst : gstvalue.c gstvalue.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.2023&r2=1.2024 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.103&r2=1.104 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.h.diff?r1=1.42&r2=1.43 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.2023 retrieving revision 1.2024 diff -u -d -r1.2023 -r1.2024 --- ChangeLog 27 Nov 2005 18:11:02 -0000 1.2023 +++ ChangeLog 27 Nov 2005 19:52:49 -0000 1.2024 @@ -1,5 +1,14 @@ 2005-11-27 Tim-Philipp Müller <tim at centricular dot net> + * gst/gstvalue.c: + Improve documentation for gst_value_union(). + + * gst/gstvalue.h: + Change return value for union, intersect and subtract functions + from gint to gboolean. +2005-11-27 Tim-Philipp Müller <tim at centricular dot net> * gst/gstvalue.c: (gst_value_serialize_any_list), (gst_value_transform_any_list_string), (gst_value_deserialize_list), (gst_value_deserialize_array), Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.103 retrieving revision 1.104 diff -u -d -r1.103 -r1.104 --- gstvalue.c 27 Nov 2005 18:11:02 -0000 1.103 +++ gstvalue.c 27 Nov 2005 19:52:49 -0000 1.104 @@ -2675,7 +2675,7 @@ * * Creates a GValue cooresponding to the union of @value1 and @value2. - * Returns: %TRUE if a union was successful + * Returns: always returns %TRUE */ /* FIXME: change return type to 'void'? */ gboolean Index: gstvalue.h RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.h,v retrieving revision 1.42 retrieving revision 1.43 diff -u -d -r1.42 -r1.43 --- gstvalue.h 27 Nov 2005 18:11:02 -0000 1.42 +++ gstvalue.h 27 Nov 2005 19:52:49 -0000 1.43 @@ -317,8 +317,7 @@ * Returns: %TRUE if a union was successful -/* FIXME: shouldn't the return value be gboolean ? */ -typedef gint (* GstValueUnionFunc) (GValue *dest, +typedef gboolean (* GstValueUnionFunc) (GValue *dest, const GValue *value1, const GValue *value2); @@ -336,8 +335,7 @@ * Returns: %TRUE if the values can intersect -typedef gint (* GstValueIntersectFunc) (GValue *dest, +typedef gboolean (* GstValueIntersectFunc) (GValue *dest, @@ -352,8 +350,7 @@ * Returns: %TRUE if the subtraction is not empty -typedef gint (* GstValueSubtractFunc) (GValue *dest, +typedef gboolean (* GstValueSubtractFunc) (GValue *dest, const GValue *minuend, const GValue *subtrahend); |