From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 08:02:59
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Summary: autocolorspace: new plugin for auto space convertor selection Classification: Desktop Product: GStreamer Version: 0.10.20 OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: Normal Component: gst-plugins-bad AssignedTo: gst...@li... ReportedBy: ben...@gm... QAContact: gst...@li... GNOME target: --- GNOME version: --- add a new element named autocolorspace, based on autoconvert, to perform the selection of the best color space converter This is done under Linaro project and specification: https://wiki.linaro.org/WorkingGroups/Middleware/Multimedia/Specs/1105/AutopluggableColorspaceConverter -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 08:04:19
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #1 from Benjamin Gaignard <ben...@gm...> 2010-11-30 08:04:06 UTC --- Created an attachment (id=175518) View: https://bugzilla.gnome.org/attachment.cgi?id=175518 Review: https://bugzilla.gnome.org/review?bug=636106&attachment=175518 1st autocolorspace implementation proposal -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 08:49:45
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Sebastian Dröge <slomo> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sl...@ci... -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 09:31:30
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Thijs Vermeir <thijsvermeir> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thi...@gm... --- Comment #2 from Thijs Vermeir <thi...@gm...> 2010-11-30 09:31:18 UTC --- I also had that idea some time ago and made a wiki page for it, but there was not much interest for it. I also had an implementation but can't find it back anymore. http://gstreamer.freedesktop.org/wiki/ColorSpaceBin -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 09:45:18
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #3 from Benjamin Gaignard <ben...@gm...> 2010-11-30 09:45:04 UTC --- yes it is the same idea does your implementation was also based on autoconvert ? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 14:36:18
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Miguel <luiverco> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lui...@gm... --- Comment #4 from Miguel <lui...@gm...> 2010-11-30 14:36:07 UTC --- This is a good idea I have seen this issue in multiple HW. Until now we have been solving this by adding support under the decoder element for multiple color formats, but this is a more generic solution -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-11-30 17:03:52
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Benjamin Gaignard <benjamin.gaignard> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175518|0 |1 is obsolete| | --- Comment #5 from Benjamin Gaignard <ben...@gm...> 2010-11-30 17:03:36 UTC --- Created an attachment (id=175553) View: https://bugzilla.gnome.org/attachment.cgi?id=175553 Review: https://bugzilla.gnome.org/review?bug=636106&attachment=175553 autocolorspace with fixed klass detection followed bilboed comment's: rewrite klass detection method -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-11 16:11:45
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #6 from Sebastian Dröge <sl...@ci...> 2010-12-11 16:11:30 UTC --- What exactly was the reason why you chose to use autoconvert as base class here? IIRC there are still some quirks in autoconvert because of it's very generic behaviour... Also you should probably make autocolorspace a GstBin with an autoconvert child instead of subclassing autoconvert. This way you would hide all the autoconvert GObject properties like "factories", which you really don't want the user the override :) -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-13 09:09:00
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #7 from Benjamin Gaignard <ben...@gm...> 2010-12-13 09:08:50 UTC --- I have chose to use autoconvert because it seem to do all the boring staff around selection and and pad linking. If autoconvert as to much quirks and it not usable yet I could rewrite autocolorspace from GstBin and use function like decodebin try_to_link_1 function to do the same. is it a better solution? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-13 13:40:29
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #8 from Sebastian Dröge <sl...@ci...> 2010-12-13 13:40:14 UTC --- Oh, and another thing. You should refresh the factory list when going to READY, this way automatic codec installation and similar things would work. I guess using autoconvert here is fine if it works... and it would give a reason to improve any problems with autoconvert :) But still, you should make autocolorspace a GstBin with a single autoconvert child -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-14 08:55:45
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Benjamin Gaignard <benjamin.gaignard> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175553|0 |1 is obsolete| | --- Comment #9 from Benjamin Gaignard <ben...@gm...> 2010-12-14 08:55:31 UTC --- Created an attachment (id=176389) View: https://bugzilla.gnome.org/attachment.cgi?id=176389 Review: https://bugzilla.gnome.org/review?bug=636106&attachment=176389 autocolorspace a GstBin with an autoconvert child I make autocolorspace a GstBin with an autoconvert child and only set factories properties when state change to READY. I a perform some tests if rgb2bayer is present gst-launch videotestsrc num-buffers=2 ! "video/x-raw-rgb,width=100,height=100,framerate=10/1" ! autocolorspace ! "video/x-raw-bayer,width=100,height=100,format=bggr,framerate=10/1" ! fakesink -v if bayer2rgb is present gst-launch videotestsrc num-buffers=2 ! "video/x-raw-bayer,width=100,height=100,format=bggr,framerate=10/1" ! autocolorspace ! "video/x-raw-rgb,width=100,height=100,framerate=10/1" ! fakesink -v test with ffmpegcolorspace gst-launch videotestsrc num-buffers=2 ! "video/x-raw-rgb,bpp=32,width=100,height=100,framerate=10/1" ! autocolorspace ! "video/x-raw-rgb,bpp=16,width=100,height=100,framerate=10/1" ! fakesink -v -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-14 10:25:40
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Benjamin Gaignard <benjamin.gaignard> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176389|0 |1 is obsolete| | --- Comment #10 from Benjamin Gaignard <ben...@gm...> 2010-12-14 10:25:26 UTC --- Created an attachment (id=176394) View: https://bugzilla.gnome.org/attachment.cgi?id=176394 Review: https://bugzilla.gnome.org/review?bug=636106&attachment=176394 same + global factories list same patch than before + global factories list protected by mutex -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-14 14:23:35
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #11 from Benjamin Gaignard <ben...@gm...> 2010-12-14 13:28:39 UTC --- Created an attachment (id=176402) View: https://bugzilla.gnome.org/attachment.cgi?id=176402 Review: https://bugzilla.gnome.org/review?bug=636106&attachment=176402 test suite for autocolorspace -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-15 20:17:47
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Sebastian Dröge <slomo> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176402|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-15 20:21:04
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Sebastian Dröge <slomo> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED Target Milestone|HEAD |0.10.21 --- Comment #12 from Sebastian Dröge <sl...@ci...> 2010-12-15 20:20:50 UTC --- I've committed both patches now but please attach patches in git format-patch format in the future :) commit 8b0c2db425563f3b773825138fcf13c03cca120a Author: Benjamin Gaignard <ben...@st...> Date: Wed Dec 15 21:19:55 2010 +0100 autocolorspace: Add unit test commit 27ac6c3e473bcf5472cfb5c7817c122349d44531 Author: Benjamin Gaignard <ben...@st...> Date: Wed Dec 15 21:14:38 2010 +0100 autocolorspace: Add autoconvert based video format convert element Fixes bug #636106. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-15 21:06:57
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Sebastian Dröge <slomo> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176394|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-15 23:17:50
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 Olivier Crete (Tester) <olivier.crete> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oli...@oc... --- Comment #13 from Olivier Crete (Tester) <oli...@oc...> 2010-12-15 23:17:36 UTC --- If I read the code correctly, it will match all of these plugins: ssim: Class: Filter/Converter/Video alphacolor: Class: Filter/Converter/Video rgb2bayer: Class: Filter/Converter/Video bayer2rgb: Class: Filter/Converter/Video ffdeinterlace: Class: Filter/Converter/Video ffmpegcolorspace: Class: Filter/Converter/Video ffvideoscale: Class: Filter/Converter/Video Is that really what you want ? That said, maybe the classes are wrong: - Possibly ffvideoscale should be "Filter/Effect/Video" like videoscale. - ssim clearly isn't a converter. I guess the rest are fine. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-16 07:57:34
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #14 from Benjamin Gaignard <ben...@gm...> 2010-12-16 07:57:22 UTC --- you are right Olivier, that what I wanted, and yes some class need to be fixed. It is already done for ssim (https://bugzilla.gnome.org/show_bug.cgi?id=636109) -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-16 08:30:28
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #15 from Sebastian Dröge <sl...@ci...> 2010-12-16 08:30:12 UTC --- Arguably videoscale should be Filter/Converter/Video too but ffdeinterlace (and ssim) shouldn't Also Tim said that this element should better be called autovideoconvert, it doesn't only do colorspace conversion. I'll rename it later -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-12-16 09:15:29
|
https://bugzilla.gnome.org/show_bug.cgi?id=636106 GStreamer | gst-plugins-bad | 0.10.20 --- Comment #16 from Sebastian Dröge <sl...@ci...> 2010-12-16 09:15:13 UTC --- Ok, it's renamed now, ffdeinterlace is no Converter anymore and the two scalers we have are Filter/Converter/Video/Scaler now -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |