Menu

#146 fix crash when pressing "rip and encode"

open
nobody
None
5
2017-04-16
2008-05-11
Markus Lude
No

Recently I built grip 3.2.0 from ports on OpenBSD/sparc64 -current. Shortly after starting to rip a track grip crashes with a bus error.

gdb trace:

(gdb) bt
#0 0x0000000056086e80 in g_convert_with_iconv ()
from /usr/local/lib/libglib-2.0.so.1600.0
#1 0x00000000560870c8 in g_convert ()
from /usr/local/lib/libglib-2.0.so.1600.0
#2 0x00000000560877cc in g_locale_from_utf8 ()
from /usr/local/lib/libglib-2.0.so.1600.0
#3 0x0000000000123658 in __register_frame_info ()
#4 0x0000000000123658 in __register_frame_info ()
Previous frame identical to this frame (corrupt stack?)

The only call of g_locale_from_utf8 is in src/launch.c

"make" complains about

launch.c: In function `ArgsToLocale':
launch.c:249: warning: passing arg 4 of `g_locale_from_utf8' from incompatible pointer type

g_locale_from_utf8 is called with a pointer to int instead of to gsize.

The attached patch fixes this for me.

In the development version that code part seems to be commented out. Maybe it would be helpful to even fix this there too.

Discussion

  • Markus Lude

    Markus Lude - 2008-05-11
     
  • Solbu

    Solbu - 2017-04-16

    Does this still happen with the latest release v3.3.5?
    I added a Debian patch 4 months ago that added «GNU/kFreeBSD» support.

     

Log in to post a comment.