#121 Adding more ID3v2 frames

open
nobody
None
2
2004-08-22
2004-08-22
Vladimir Petrov
No

Depends on patches:
1004972 Preserve the characters from "eating" in
DiscDBProcessLine()
1004963 Preventing from splitting of UTF-8 characters

Includes patches:
1013403 ID3v1.1 bugfix updated

Changes:
* Using 'GripInfo' and 'EncodeTrack' structs to call
ID3v2TagFile() and ID3v2TagFile().
* Compress/escape the data while reading/writing
discDB. Additional protection to avoid forbiden writing
of newlines has been added (Replacing newlines by a
slashes).
* Avoid writing of empty tags.
* Avoid appearing of untranslated "Unknown"s in the ID3
fields.
* Added improvements to some of the existing ID3v2 fields:
- Added total numbers of tracks extension to 'Track
number/Position in set' frame.
- Comment description.
- Writing extended disc and track info to separate
comment fields.
* Added some new (to Grip ;) ) frames:
- 'Original filename'.
- 'Band/Orchestra/Accompaniment'.
- 'Length'.
- 'Media type'.
- 'File type'.

TODO:
* Filling of the language comment fields (according to
ISO-639-2).
* Increasing the "ID3 comment field" size and
replacement of 'GtkEntry' by some of multiline Gtk widgets.
* Replacing all fixed size strings in
'DiscData','GripInfo' and 'EncodeTrack' by dynamically
reallocable strings. This is important since Grip can
loss data while resending discDB entries. Except that
ID3v2 allows up to 256 megabytes field lengths. Is
there any reason forcing us to limit this to 256 bytes
(2^20 times)?

Discussion

1 2 > >> (Page 1 of 2)
    • priority: 5 --> 2
     
  • Logged In: YES
    user_id=800933

    Ooops!
    I forgot that filenames are stored in filesystem encoding
    instead of UTF-8.
    So use version 0.2 please. :)

     
  • Logged In: YES
    user_id=800933

    In 0.3 are added more frames:
    'Encoded by'
    'File owner/licensee'

    And in 0.4:
    'Software/Hardware and settings used for encoding'
    Here is added a new function to get version info calling
    encoder and ripper with '--version' argument. I am not sure
    if its callings are placed at right places.
    TODO:
    Deactivation of all important widgets during ripping and
    separately during encoding.

     
  • Logged In: YES
    user_id=800933

    File
    'grip-3.2.0-encodersettings.patch.gz'
    is a patch adding only 'Software/Hardware and settings used
    for encoding' field implementation to the official grip-3.2.0.
    Independent of any other patches.

     
  • Logged In: YES
    user_id=800933

    Version 0.5 corrects a old data reminder bug in all early
    versions.

     
1 2 > >> (Page 1 of 2)