From: Kees B. <kee...@xs...> - 2009-02-15 16:12:46
|
Hi, In GVRelGraph I noticed the following code: dirpath = "ppl/%s/%s" % (h[0], h[1]) This is definitely something which is not public outside the code of NarrativeWeb. At least not to my knowledge. Furthermore this code got changed over a year ago (in trunk). The reason was that chosing the first two letters of a handle is not a good choice to split a large number of files across several subdirectories. What I'm worried about is that there are more plugins that want to know these kinds of internals from NarrativeWeb. If we really want to we need to define what they must be. -- Kees |
From: Benny M. <ben...@gm...> - 2009-02-15 16:53:34
|
2009/2/15 Kees Bakker <kee...@xs...> > Hi, > > In GVRelGraph I noticed the following code: > dirpath = "ppl/%s/%s" % (h[0], h[1]) > > This is definitely something which is not public outside the code of > NarrativeWeb. At least > not to my knowledge. Furthermore this code got changed over a year ago > (in trunk). The > reason was that chosing the first two letters of a handle is not a > good choice to split a > large number of files across several subdirectories. > > What I'm worried about is that there are more plugins that want to > know these kinds of > internals from NarrativeWeb. If we really want to we need to define > what they must be. The plugins/lib contains shared info. So if you correct this code, then the best way would be a libweb.py module. I have no opinion about what should be in it though. Code that is reused obviously, but that is like beating a dead horse. Benny > -- > Kees > > > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, > CA > -OSBC tackles the biggest issue in open source: Open Sourcing the > Enterprise > -Strategies to boost innovation and cut costs with open source > participation > -Receive a $600 discount off the registration fee with the source code: > SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |