From: Nick H. <nic...@ho...> - 2010-04-05 18:17:38
|
I have been looking at 0003710: Pedigree View: use "configure view" dialog. http://www.gramps-project.org/bugs/view.php?id=3710 A few questions: 1. In the new pedigree view, it is possible to change configuration settings from the keyboard. I think that this is the only place in Gramps where this is possible. This creates a potential problem because a setting can be changed from the keyboard whilst the configuration dialog is open. In this case we should really update the open dialog to reflect the changes. Do we want to allow this? 2. Changing the tree size of the pedigree can be slow for larger sizes. This causes unexpected skipping of values when using a SpinButton widget. This is improved by using an HScale widget instead, but an alternative approach would be to use an "Accept" button. Is creating an "Accept" button a good idea or should we try to avoid it? 3. I extended configure.py to add a couple of extra widgets. This allows code in the view to be simpler, and makes it easier to conform to the look and feel of other configuration dialogs. Is it possible to share code with other parts of Gramps? I think someone mentioned sharing code with either GuiOptions in src/PluginUtils or MonitoredWidgets in src/gui/widgets. Regards, Nick. |
From: Benny M. <ben...@gm...> - 2010-04-06 10:40:26
|
2010/4/5 Nick Hall <nic...@ho...> > I have been looking at 0003710: Pedigree View: use "configure view" dialog. > > http://www.gramps-project.org/bugs/view.php?id=3710 > > A few questions: > > 1. In the new pedigree view, it is possible to change configuration > settings from the keyboard. I think that this is the only place in > Gramps where this is possible. This creates a potential problem because > a setting can be changed from the keyboard whilst the configuration > dialog is open. In this case we should really update the open dialog to > reflect the changes. > > Do we want to allow this? > Difficult one. If something needs to change often, then it should not be in configure, but should be an action button or a part of the interface in some way. If it almost never changes, then it should not be possible via the keyboard. > > 2. Changing the tree size of the pedigree can be slow for larger sizes. > This causes unexpected skipping of values when using a SpinButton > widget. This is improved by using an HScale widget instead, but an > alternative approach would be to use an "Accept" button. > > Is creating an "Accept" button a good idea or should we try to avoid it? > Try to avoid if possible. The accept is sometimes needed for performance though, see eg the column changes on the listviews. So it depends. This is a minor issue, if another widget makes it better, then go that route. > > 3. I extended configure.py to add a couple of extra widgets. This > allows code in the view to be simpler, and makes it easier to conform to > the look and feel of other configuration dialogs. > > Is it possible to share code with other parts of Gramps? > > I think someone mentioned sharing code with either GuiOptions in > src/PluginUtils or MonitoredWidgets in src/gui/widgets. > Yes. I don't know that code however. Configure now shares for the preference dialog and the configure dialogs. It would be nice to use guioptions, but I have no idea what would be needed for that. Benny |
From: Doug B. <dou...@gm...> - 2010-04-06 11:35:31
|
On Tue, Apr 6, 2010 at 6:40 AM, Benny Malengier <ben...@gm...> wrote: > > > 2010/4/5 Nick Hall <nic...@ho...> >> >> I have been looking at 0003710: Pedigree View: use "configure view" >> dialog. >> >> http://www.gramps-project.org/bugs/view.php?id=3710 >> >> A few questions: >> >> 1. In the new pedigree view, it is possible to change configuration >> settings from the keyboard. I think that this is the only place in >> Gramps where this is possible. This creates a potential problem because >> a setting can be changed from the keyboard whilst the configuration >> dialog is open. In this case we should really update the open dialog to >> reflect the changes. >> >> Do we want to allow this? > > Difficult one. If something needs to change often, then it should not be in > configure, but should be an action button or a part of the interface in some > way. If it almost never changes, then it should not be possible via the > keyboard. > >> >> 2. Changing the tree size of the pedigree can be slow for larger sizes. >> This causes unexpected skipping of values when using a SpinButton >> widget. This is improved by using an HScale widget instead, but an >> alternative approach would be to use an "Accept" button. >> >> Is creating an "Accept" button a good idea or should we try to avoid it? > > Try to avoid if possible. The accept is sometimes needed for performance > though, see eg the column changes on the listviews. So it depends. This is a > minor issue, if another widget makes it better, then go that route. > >> >> 3. I extended configure.py to add a couple of extra widgets. This >> allows code in the view to be simpler, and makes it easier to conform to >> the look and feel of other configuration dialogs. >> >> Is it possible to share code with other parts of Gramps? >> >> I think someone mentioned sharing code with either GuiOptions in >> src/PluginUtils or MonitoredWidgets in src/gui/widgets. Yes, let's do share the GuiOptions code. > Yes. I don't know that code however. Configure now shares for the preference > dialog and the configure dialogs. It would be nice to use guioptions, but I > have no idea what would be needed for that. The gramplet configure view code uses guioptions (for those that have additional options) such as the Quick View Gramplet (as the gramplet options were written before the configure option). Currently, it uses a "Save" (which should be "Apply") but there may be a way to hook them up to change directly. See the build_options code here: http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/src/plugins/gramplet/QuickViewGramplet.py?view=markup and make_gui_widgets code here: http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/src/gui/widgets/grampletpane.py?view=markup -Doug > Benny > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > > |