From: Kees B. <kee...@xs...> - 2008-05-09 11:48:44
|
Hi Raphael, Do you still use Eclipse and pydev to look at Gramps? You've reported last december about the errors and warnings that pydev finds. Since a few months I have been using Eclipse and pydev too. Using pydev is really helpful to find problem beforhand. Do you by any change know how to trigger pydev to redo the parsing (and thus error check)? And to remind the Gramps devels: what pydev reports as errors really must be verified. All the ones (just a few) that I checked were actual bugs. -- Manual? What manual? This is UNIX! |
From: Brian M. <br...@gr...> - 2008-05-11 05:10:26
|
Kees, > Do you still use Eclipse and pydev to look at > Gramps? You've reported last > december about the errors and warnings that pydev > finds. Since a few months I > have been using Eclipse and pydev too. Using pydev > is really helpful to find > problem beforhand. > > Do you by any change know how to trigger pydev to > redo the parsing (and thus > error check)? > > And to remind the Gramps devels: what pydev reports > as errors really must be > verified. All the ones (just a few) that I checked > were actual bugs. > -- I'm not sure what "error checking" you are referring to. Personally, I enable pylint in pydev. I think it's awesome. There are some helpful instructions here: https://www.seegrid.csiro.au/twiki/bin/view/Compsrvices/GoodPractice I enable all warnings and I always try to eliminate as many warnings as I can. It isn't really possible to remove all warnings. Personally, I always shoot for a pylint score of 8 or above for all source files. ~Brian |
From: Kees B. <kee...@xs...> - 2008-05-11 20:19:49
|
Op 11 mei 2008, om 07:10 heeft Brian Matherly het volgende geschreven: > Kees, > >> Do you still use Eclipse and pydev to look at >> Gramps? You've reported last >> december about the errors and warnings that pydev >> finds. Since a few months I >> have been using Eclipse and pydev too. Using pydev >> is really helpful to find >> problem beforhand. >> >> Do you by any change know how to trigger pydev to >> redo the parsing (and thus >> error check)? >> >> And to remind the Gramps devels: what pydev reports >> as errors really must be >> verified. All the ones (just a few) that I checked >> were actual bugs. >> -- > > I'm not sure what "error checking" you are referring > to. Personally, I enable pylint in pydev. I think it's > awesome. Pydev does much more than just pylint. For example, it knows when a (class) function does not exist. Let me give an example. In ImportCVS.py there is this code (trunk): # only add note to event: if note: # append notes, if previous notes previous_notes = marriage.get_note() if previous_notes != "": if note not in previous_notes: note = previous_notes + "\n" + note marriage.set_note(note) Pydev tells me there is no get_note or set_note. That's not something pytlint can do (I think, and maybe it is pydev extensions that does this). And the first time when I created the gramps project in eclipse (plus pydev) it reported a lot of errors that I wanted to verify again. But to get the error messages again I have to get pydev to parse the Python again. It does it after saving a changed module. But I want to do it for the whole gramps project without having to touch each file separately. > There are some helpful instructions here: > https://www.seegrid.csiro.au/twiki/bin/view/Compsrvices/GoodPractice OK. Thanks. > I enable all warnings and I always try to eliminate as > many warnings as I can. It isn't really possible to > remove all warnings. Personally, I always shoot for a > pylint score of 8 or above for all source files. Yes, pylint gives good hints. But I think pydev (and pydev extensions) takes it to a higher level of error detection. -- Kees |
From: Brian M. <br...@gr...> - 2008-05-11 20:56:36
|
> >> Do you by any change know how to trigger pydev to > >> redo the parsing (and thus > >> error check)? > >> > >> And to remind the Gramps devels: what pydev > reports > >> as errors really must be > >> verified. All the ones (just a few) that I > checked > >> were actual bugs. > >> -- > > > > I'm not sure what "error checking" you are > referring > > to. Personally, I enable pylint in pydev. I think > it's > > awesome. > > Pydev does much more than just pylint. For example, > it knows when a > (class) function > does not exist. Let me give an example. > > In ImportCVS.py there is this code (trunk): > # only add note to event: > if note: > # append notes, if previous > notes > previous_notes = > marriage.get_note() > if previous_notes != "": > if note not in > previous_notes: > note = > previous_notes + "\n" + note > marriage.set_note(note) > > Pydev tells me there is no get_note or set_note. > That's not something > pytlint can do > (I think, and maybe it is pydev extensions that does > this). Yes, it's "PyDev Extensions" doing that - in particular, the code analysis feature. > And the first time when I created the gramps project > in eclipse (plus > pydev) > it reported a lot of errors that I wanted to verify > again. But to get > the error messages > again I have to get pydev to parse the Python again. > It does it after > saving a > changed module. But I want to do it for the whole > gramps project without > having to touch each file separately. Go to "Project->Clean..." and it should rerun the parser. > > There are some helpful instructions here: > > > https://www.seegrid.csiro.au/twiki/bin/view/Compsrvices/GoodPractice > > OK. Thanks. > > > I enable all warnings and I always try to > eliminate as > > many warnings as I can. It isn't really possible > to > > remove all warnings. Personally, I always shoot > for a > > pylint score of 8 or above for all source files. > > Yes, pylint gives good hints. But I think pydev (and > pydev extensions) > takes it to a higher level > of error detection. Like I said, PyDev Extensions is doing all that for you. From the website (http://www.fabioz.com/pydev/index.html), it looks like PyDev Extensions requires a license key which you have to buy. Did you buy a license? I still think pylint brings a LOT of value to the table in terms of PEP8 compliance. Please consider trying it. ~Brian |