From: Dr. V. J. <vol...@in...> - 2006-07-11 14:11:18
|
Dear Gramps Developers! I found some minor Bugs in NavWebPage.py breaking the xhtml1.0 conformity and corrected them. * The tree_display ommits a closing <DIV> Tag * some are coded without a trailing colon * The usage of the "align" property violates xhtml1.0 strict In addition I patched NavWebPage.py to use the persons gramps_id in the ppl directory to generate the file path instead of the persons database handle. The usage of steadily changing paths due to the changing handles makes it impossible for someone to set a deeplink to a person on a website generated by NavWebPage.py. Maybe this patch could be transformed into an user configurable option for path-generation. I have used my working copy of gramps 2.0.11-2 on debian linux for the patches. The patched version can be found at http://jaenisch.name/NavWebPage.py/file_view My changes are marked by a "#xxx" comment line. I like to help to improve this outstanding piece of software further. Best Regards Volker -- ==================================================== inqbus it-consulting +49 ( 341 ) 5643800 Dr. Volker Jaenisch http://www.inqbus.de Herloßsohnstr. 12 0 4 1 5 5 Leipzig N O T - F Ä L L E +49 ( 170 ) 3113748 ==================================================== |
From: Eero T. <oa...@he...> - 2006-07-11 18:34:09
|
Hi, On Tuesday 11 July 2006 17:11, Dr. Volker Jaenisch wrote: > In addition I patched NavWebPage.py to use the persons gramps_id > in the ppl directory to generate the file path instead of the persons > database handle. Did this decrease the size of the report? (AFAIK Gramps IDs should be shorter too) - Eero |
From: Don A. <don...@co...> - 2006-07-12 04:58:53
|
On Tue, 2006-07-11 at 21:55 +0300, Eero Tamminen wrote: > Hi, >=20 > On Tuesday 11 July 2006 17:11, Dr. Volker Jaenisch wrote: > > In addition I patched NavWebPage.py to use the persons gramps_id > > in the ppl directory to generate the file path instead of the persons > > database handle. >=20 > Did this decrease the size of the report? >=20 > (AFAIK Gramps IDs should be shorter too) >=20 >=20 > - Eero The reason we use the handles instead of GRAMPS ids, is that the handles will never change, but the user can change the GRAMPS ids. This can lead to problems when overwriting existing files (if you generate the web site multiple times). If a user changes the gramps ids, it is possible to link to the wrong file if files are overwritten. This will not happen with the unique handles. Don |
From: Don A. <don...@co...> - 2006-07-12 05:01:18
|
I should also point out that GRAMPS IDs may not produce legal filenames, or unique filenames. For example, "I12/23" is a legal GRAMPS id, but would not map to a legal filename. Similarly, I can have "i0" and "I0" as two valid and unique GRAMPS ids, but on some web servers, these would be seen as identical filenames. =20 On Tue, 2006-07-11 at 21:55 +0300, Eero Tamminen wrote: > Hi, >=20 > On Tuesday 11 July 2006 17:11, Dr. Volker Jaenisch wrote: > > In addition I patched NavWebPage.py to use the persons gramps_id > > in the ppl directory to generate the file path instead of the persons > > database handle. >=20 > Did this decrease the size of the report? >=20 > (AFAIK Gramps IDs should be shorter too) >=20 >=20 > - Eero >=20 >=20 > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job ea= sier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim= o > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat= =3D121642 > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel |
From: Brian M. <br...@gr...> - 2006-07-13 04:15:31
|
Volker, Thanks for your report.=20 I have integrated your HTML validation fixes into the 2.1 branch (will beco= me the 2.2.0 release eventually). I have passed on the Gramps ID idea for the reasons Don gave. Thanks so much for your help. ~Brian ----- Original Message ---- From: Dr. Volker Jaenisch <vol...@in...> To: gramps <gra...@li...>; sven.seidel <sven.seidel@u= nister-gmbh.de> Sent: Tuesday, July 11, 2006 9:11:04 AM Subject: [Gramps-devel] Some minor Bugfixes on NavWebPage.py Dear Gramps Developers! I found some minor Bugs in NavWebPage.py breaking the xhtml1.0=20 conformity and corrected them. * The tree_display ommits a closing <DIV> Tag * some are coded without a trailing colon * The usage of the "align" property violates xhtml1.0 strict In addition I patched NavWebPage.py to use the persons gramps_id in the ppl directory to generate the file path instead of the persons database handle. The usage of steadily changing paths due to the changing handles makes=20 it impossible for someone to set a deeplink to a person on a website generated by NavWebPage.py. Maybe this patch could be transformed into an user configurable option=20 for path-generation. I have used my working copy of gramps 2.0.11-2 on debian linux for the=20 patches. The patched version can be found at http://jaenisch.name/NavWebPage.py/file_view My changes are marked by a "#xxx" comment line. I like to help to improve this outstanding piece of software further. Best Regards Volker --=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D inqbus it-consulting +49 ( 341 ) 5643800 Dr. Volker Jaenisch http://www.inqbus.de Herlo=C3=9Fsohnstr. 12 0 4 1 5 5 Leipzig N O T - F =C3=84 L L E +49 ( 170 ) 3113748 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easi= er Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1= 21642 _______________________________________________ Gramps-devel mailing list Gra...@li... https://lists.sourceforge.net/lists/listinfo/gramps-devel |