From: Jim S. <ji...@ji...> - 2004-08-28 23:10:26
Attachments:
RelLib.py.patch
|
Find attached a patch to fix a very minor bug in RelLib.py's guess_gender(). hth, Jim |
From: Tim W. <tw...@re...> - 2004-08-31 11:10:06
|
On Sun, Aug 29, 2004 at 12:10:02AM +0100, Jim Smart wrote: > Find attached a patch to fix a very minor bug in RelLib.py's > guess_gender(). Patch looks wrong to me. Can you explain why you think it's needed? Tim. */ |
From: Jim S. <ji...@ji...> - 2004-08-31 13:41:22
|
On Tue, 2004-08-31 at 12:09, Tim Waugh wrote: > > Find attached a patch to fix a very minor bug in RelLib.py's > > guess_gender(). > > Patch looks wrong to me. Can you explain why you think it's needed? Good catch: my changes were based on an assumption that isn't true, as I couldn't see the authors original intent in the function. Sorry. Being a newcomer to the codebase I've found that at times, the lack of commenting has slowed me somewhat -- and occasionally caused me to arrive at erroneous conclusions. Maybe I should be submitting patches to add comments to the code, instead? (a serious suggestion: feedback appreciated) Jim |
From: Don A. <don...@co...> - 2004-08-31 14:58:42
|
Jim Smart wrote: > Being a newcomer to the codebase I've found that at times, the lack of > commenting has slowed me somewhat -- and occasionally caused me to > arrive at erroneous conclusions. Sorry about that. This is mostly my fault. I've tried improving things lately in the core files (RelLib.py and GrampsDbBase.py). > Maybe I should be submitting patches to add comments to the code, > instead? (a serious suggestion: feedback appreciated) Comments would be greatly appreciated. Don |