Menu

#27 Fixed several function prototypes

closed
nobody
None
5
2012-09-15
2011-01-19
No

Some OpenGL 1.3 and 2.0 functions have wrong parameters in glew (compared to spec).

Fixed these:

gl(Mult|Load)TransposeMatrix[fd] doesn't have const parameters
glGetVertexAttribPointerv takes void*, not void
glGetShaderSource uses uint instead of int as a shader parameter

Please apply the patch.

Discussion

  • Nigel Stewart

    Nigel Stewart - 2011-01-19

    Riku,

    Thanks for the patch.

    Concerning gl(Mult|Load)TransposeMatrix[fd], the opengl.org and nvidia.com versions use const.
    They're also specified as const in Section 2.2 of the 4.1 compatibility specification:
    http://www.opengl.org/registry/doc/glspec41.compatibility.20100725.pdf

    Changes to glGetVertexAttribPointerv and glGetShaderSource agreed.

    I recommend a revised patch.

    • Nigel
     
  • Riku Palomäki

    Riku Palomäki - 2011-01-19

    Thanks for the input.

    Since the gl(Mult|Load)TransposeMatrix[fd] stuff is in file auto/core/GL_VERSION_1_3, I only read the 1.3 specification, it doesn't have the const. Actually even in 2.1 and 3.2 (http://www.opengl.org/registry/doc/glspec32.compatibility.20091207.pdf in section 2.12.1) there is no const, it was only changed in 3.3.

    I noticed this because the corresponding ARB extension http://www.opengl.org/registry/specs/ARB/transpose_matrix.txt doesn't have const, and that is also the case in GLEW, since those are auto-generated.

    I made a revised patch, but it's still a little weird that the ARB version has different prototype.

     
  • Nigel Stewart

    Nigel Stewart - 2011-01-19

    Riku,

    Thanks for the follow up. I agree that it is weird to come across these inconsistencies.
    Patch applied to git repository. Thanks.

    • Nigel
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).