#82 1.6 B2 CVS System Logfile -SMTP error

[Im]

Hello,

This is not really a bug, but could be made more 'user friendly'.

I made some changes in the GEDCOM.
After I checked the Log file I found this:

"Type","Date/time","User","Message"
"E","22.02.2008 18:08:48","admin","ERROR 2: mail() [<a href='function.mail'>function.mail</a>]: SMTP server response: 550 relay not permitted; Error occurred on line 94 of file sendmail.class.php; Using URL: genmod/index.php?command=gedcom; 0 Error occurred on in function <b>mail</b>;
1 called from line <b>94</b> of file <b>sendmail.class.php</b> in function <b>OutputMail</b>;
2 called from line <b>25</b> of file <b>sendmail.class.php</b> in function <b>SendMail</b>;
3 called from line <b>2020</b> of file <b>functions.php</b> in function <b>GmMail</b>;
4 called from line <b>183</b> of file <b>authentication.php</b> in function <b>AddMessage</b>;
5 called from line <b>82</b> of file <b>review_changes.php</b> in function <b>review_changes_block</b>;
6 called from line <b>1</b> of file <b>index.php(263) : eval()'d code</b> in function <b>eval</b>;
7 called from line <b>263</b> of file <b>index.php</b>;
"
"E","22.02.2008 18:08:48","admin","ERROR 2: mail() [<a href='function.mail'>function.mail</a>]: SMTP server response: 550 relay not permitted; Error occurred on line 94 of file sendmail.class.php; Using URL:
genmod/index.php?command=gedcom; "

This I receive by a simple reason.
The "Contact method" is set to "Internal messaging with emails"
The mail server I use is configured but it's not permitted for sending emails from the 'out-side'.
It's for only the local network and I am outside of that right now. Thanks to my laptop...

Maybe a smaller and more understandable error message could be: Hi, you are not permited....etc

This you can set to priority 1

Cheers,
-Im

[Boudewijn Sjouke]

Logged In: YES
user_id=816380
Originator: NO

This is all about error reporting.
I agree that Genmod should produce some message stating the email could not be sent.
But the question is, if we should hide the error messages from the user. This is a Genmod-wide setting, so the discussion actually should be: in general, do we show errors to users?

[Im]

Logged In: YES
user_id=1262354
Originator: YES

Hi Boudewijn,

Good question. Errors should be reported to the user. Othervise, they (or you) never know what went wrong.
But, is it necessary to show all the PHP error messages? In this case, the only interesting message is:
SMTP server response: 550 relay not permitted
The rest is not important or even understandabe by an 'normal' user. I'm not sure if even an admin would care about the PHP errors in this case.
I don't know what or how the Genmod-wide settings works, so I will not give you any ideas. For what ever I say, it will be wrong :)
It's up to you how to handle this. For this bug was reported for all the PHP error messages and not because of the SMTP server response.
The Genmod code can not handle the server response so there will be a long list of PHP errors.

Cheers,
-Im