Menu

#985 Literate Haskell highlighting

None
open
v1.23.1
5
2013-08-16
2013-07-21
xa
No

Scintilla highlights Literate Haskell for at least two months now, however Geany still misses a filetype for it.

Related:
https://github.com/geany/geany/pull/155

Discussion

  • Anonymous

    Anonymous - 2013-07-21
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,4 @@
     Scintilla highlights Literate Haskell for at least two months now, however Geany still misses a filetype for it.
    +
    +Related:
    +https://github.com/geany/geany/pull/155
    
     
  • Anonymous

    Anonymous - 2013-07-21

    This is more of a feature request than a bug report, but new sourceforge UI doesn't seem to allow moving tickets between trackers anymore, so leaving as is.

     
  • Colomban Wendling

    • labels: --> Filetypes, Haskell
    • Found in: --> v1.24
    • Fixed in: v1.24 --> None
     
  • Anonymous

    Anonymous - 2013-08-16
    • labels: Filetypes, Haskell --> Filetypes, Haskell, literate
    • status: open --> closed-fixed
    • assigned_to: Matthew Brush
    • Found in: v1.24 --> v1.23.1
    • Fixed in: None --> v1.24
     
  • Anonymous

    Anonymous - 2013-08-16
     
    • xa

      xa - 2013-08-16

      Fixed in https://github.com/geany/geany/commit/09e7d8398fd168fd0aabfd908ffbdf429d7fc53e

      No, it's not fixed. No literate haskell filetype was added in the commit:

      The other one added Literate Haskell filetype, though it was implemented as an alias for haskell filetype which led to new literate haskell files being saved with an .hs extension.
      This one mostly fixes plain haskell's filetype, though it adds some stuff for literate haskell lexer where makes sense.

      You probably misunderstood it to mean that this pull also adds a literate haskell filetype. I should've said "This one only fixes".

       
  • xa

    xa - 2013-08-16

    Fixed in https://github.com/geany/geany/commit/09e7d8398fd168fd0aabfd908ffbdf429d7fc53e

    No it's not fixed. No literate haskell filetype was added in the commit. You probably misunderstood what i was saying in https://github.com/geany/geany/pull/155#issuecomment-21314821 to mean that this pull also adds full support for literate haskell. It "superxeded" because solution in #139 was inadequate so i decided to only change the current haskell filetype, and leave literate haskell filetype to geany devs.

     
  • Anonymous

    Anonymous - 2013-08-16
    • status: closed-fixed --> open
    • Fixed in: v1.24 --> None
     
  • Anonymous

    Anonymous - 2013-08-16

    Please make a new complete PR with exactly how Geany should be. Me (and other core Geany devs) don't use Haskell, so if you present something believable as a complete pull request, I will most likely merge it.

     
    • xa

      xa - 2013-08-16
       
  • xa

    xa - 2013-08-16
     

Log in to post a comment.