Menu

#5 attach to pidgin notification icon

open
nobody
None
5
2007-10-18
2007-10-18
Anonymous
No

This patch will set geometry hints for the notification using new API for docklet geometry in pidgin. If the geometry is unavailable, the old behavior will be used. The docklet geometry API will be available in the next minor release of pidgin (2.3.0). I'm not sure if this plugin wants to maintain support for older pidgin releases. If so, the code introduced in this patch will need to be conditionally compiled based on the pidgin version.

There is one small behavior quirk with this. If pidgin is configured to only show the tray icon on new messages, then the first notification received will not get "attached" to the tray icon, as it won't exist yet.

Discussion

  • Nobody/Anonymous

     
  • Craig Harding

    Craig Harding - 2008-09-21

    This patch does not work with pidgin-2.5.1 as the patch here:

    http://developer.pidgin.im/ticket/521

    is not committed yet to pidgin. It seems it's going to be committed in 3.0.0 of pidgin.

    I would really like this libnotify patch to be implemented, so if you have the pidgin patch from (#521) that publicly makes available pidgin_docklet_get_geometry, I would defintely apply it to my working copy to see if this libnotify patch works. As of right now, pidgin-libnotify doesn't load upon pidgin startup because it does not find pidgin_docklet_get_geometry in the pidgin library.

     

Log in to post a comment.