From: Steven J. <py...@li...> - 2004-09-26 20:25:36
Attachments:
fuse-20040926-pythonfix.diff
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Greetings, The Python binding in the CVS version fell out of date and wouldn't compile. Fixed and added FuseGetContext call. Signed-off-by: Steven James <py...@li...> G'day, sjames ||||| |||| ||||||||||||| ||| by Linux Labs International, Inc. Steven James, CTO 55 Marietta Street Suite 1830 Atlanta, Ga 30303 866 824 9737 support -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: Made with pgp4pine 1.75-6 iEYEARECAAYFAkFXJbsACgkQaSF+fG6OjZdPngCeLrFe7m34ulyl0k8tCefKsABP Fs0An0GScidtQpnQpOXHBKnvYApUx2lh =pB9x -----END PGP SIGNATURE----- |
From: Miklos S. <mi...@sz...> - 2004-09-27 06:37:10
|
> The Python binding in the CVS version fell out of date and wouldn't > compile. Fixed and added FuseGetContext call. Great! I applied your patch. The only little thing that I don't like is this line: d['kopts'] = 'allow_other,kernel_cache'; I think these options should not be hardcoded into the library. 'allow_other' is an option that will fail with the default kernel module parameters for non-root. 'kernel_cache' has a bit misleading name: kernel cache is enabled by default without this option. What this option does is makes the flushing of the cache the responsibility of the userspace filesystem via the fuse_invalidate() function. So this normally should not be enabled, only for filesystems which are especially written with this in mind. Thanks, Miklos |
From: Steven J. <py...@li...> - 2004-09-27 16:50:51
Attachments:
fuse-20040927-pythonfix2.diff
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Greetings, On Mon, 27 Sep 2004, Miklos Szeredi wrote: > > The Python binding in the CVS version fell out of date and wouldn't > > compile. Fixed and added FuseGetContext call. > > Great! I applied your patch. The only little thing that I don't like > is this line: > > d['kopts'] = 'allow_other,kernel_cache'; > The attached patch (against today's CVS) will make those options settable and default to off (unset). > > 'kernel_cache' has a bit misleading name: kernel cache is enabled by > default without this option. What this option does is makes the > flushing of the cache the responsibility of the userspace filesystem > via the fuse_invalidate() function. So this normally should not be > enabled, only for filesystems which are especially written with this > in mind. > I should have seen that in the module. Thanks for the pointer. > Thanks, > Miklos > Signed-off-by: Steven James <py...@li...> G'day, sjames ||||| |||| ||||||||||||| ||| by Linux Labs International, Inc. Steven James, CTO 55 Marietta Street Suite 1830 Atlanta, Ga 30303 866 824 9737 support -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: Made with pgp4pine 1.75-6 iEYEARECAAYFAkFYRN8ACgkQaSF+fG6OjZemOACfTlXs3Ab52y59Un1KYn1m9h1p Y/4AnjYUfbk8sQo6YN7REqFY6K2qpQB7 =HKFi -----END PGP SIGNATURE----- |
From: Miklos S. <mi...@sz...> - 2004-09-27 17:10:06
|
> The attached patch (against today's CVS) will make those options settable > and default to off (unset). Perfect. Thanks, Miklos |