Thread: [Fulltextsearch-devel] StopList bug fixes and test script
Status: Beta
Brought to you by:
tjmather
Menu
▾
▴
fulltextsearch-devel
From: T.J. M. <tjm...@th...> - 2000-08-22 00:48:25
|
Hi, I added a test for stoplist and some bug fixes for DBIx::FullTextSearch::StopList. Please find the files at http://www.thoughtstore.com/tjmather/perl/StopList.pm and http://www.thoughtstore.com/tjmather/perl/6_stoplist.t > Could you also add tests for the parts you've added? I've done the > port by merely changing the code until all test passed. So any code > that is not tested was not ported to PostgreSQL. We need the > regression tests to make sure the things still run fine with all types > of databases/conditions. |
From: Honza P. <ad...@in...> - 2000-08-22 06:49:10
|
On Mon, Aug 21, 2000 at 08:01:44PM -0500, T.J. Mather wrote: > > I added a test for stoplist and some bug fixes for > DBIx::FullTextSearch::StopList. Please find the files at > > http://www.thoughtstore.com/tjmather/perl/StopList.pm > and > http://www.thoughtstore.com/tjmather/perl/6_stoplist.t Great. Should I repackage them into those distributions or will you do that? -- ------------------------------------------------------------------------ Honza Pazdziora | ad...@fi... | http://www.fi.muni.cz/~adelton/ .project: Perl, DBI, Oracle, MySQL, auth. WWW servers, MTB, Spain, ... ------------------------------------------------------------------------ |
From: T.J. M. <tjm...@th...> - 2000-08-22 18:01:02
|
> Great. Should I repackage them into those distributions or will you do > that? Could you use the test to create a PostgreSQL version of StopList.pm? I don't have access to a postgresql server here. Also should I merge the MySQL and PostgreSQL code bases together or are you going to do that? -TJ |
From: Honza P. <ad...@in...> - 2000-08-24 09:16:02
|
On Tue, Aug 22, 2000 at 01:14:21PM -0500, T.J. Mather wrote: > > Could you use the test to create a PostgreSQL version of StopList.pm? I > don't have access to a postgresql server here. Sure. > Also should I merge the MySQL and PostgreSQL code bases together or are > you going to do that? If you have the time, please do that. I wouldn't be able to look at it until the end of this week. I don't know if we've made some final decission of how to go about it but I think that the most important will be to find some balance. So that we don't create specialized APIs and methods where a simple if () { } else { } suffices. It would be great if we could keep the FTS logic in as much one place as possible and somehow only separate the db parts. Maybe I could find some time to do this for FTS.pm and maybe Blob.pm to rather show code than words ;-) I think I'll try that. -- ------------------------------------------------------------------------ Honza Pazdziora | ad...@fi... | http://www.fi.muni.cz/~adelton/ .project: Perl, DBI, Oracle, MySQL, auth. WWW servers, MTB, Spain, ... ------------------------------------------------------------------------ |
From: T.J. M. <tjm...@th...> - 2000-08-24 14:29:38
|
> I don't know if we've made some final decission of how to go about it > but I think that the most important will be to find some balance. So > that we don't create specialized APIs and methods where a simple > if () { } else { } suffices. I definitely agree - we should use 'if ($fts->{dbd} eq 'mysql') { } else { }' - it might not be the most elegant solution - but it is simple and fast. Is there any place the if/else systax will not suffice and we will need seperate DB modules? > It would be great if we could keep the FTS logic in as much one place > as possible and somehow only separate the db parts. Absolutely - I couldn't agree more. > Maybe I could find some time to do this for FTS.pm and maybe Blob.pm > to rather show code than words ;-) I think I'll try that. Great. If you could do those, I can do the rest. |
From: T.J. M. <tjm...@th...> - 2000-08-29 18:13:01
|
Hi, I'm going to release 0.54 later today, based on the mysql version (0.537) that Honza sent me. There are a couple of fixes to the test suite which caused 'make test' to fail on some newer versions of MySQL. So this release will still only support MySQL. Once we finish adding postgreSQL support (I think all we need to do is StopList.pm), I will release 0.55 which will include PostgreSQL support. If there is anything I should know before I release 0.54, please let me know. -T.J. |
From: Honza P. <ad...@in...> - 2000-08-30 06:51:18
|
On Tue, Aug 29, 2000 at 01:27:08PM -0500, T.J. Mather wrote: > > I'm going to release 0.54 later today, based on the mysql version > (0.537) that Honza sent me. There are a couple of fixes to the test suite > which caused 'make test' to fail on some newer versions of MySQL. So this > release will still only support MySQL. > > Once we finish adding postgreSQL support (I think all we need to do is > StopList.pm), I will release 0.55 which will include PostgreSQL support. > > If there is anything I should know before I release 0.54, please let > me know. I'd say go ahead. I wonly be able to make polished dual version today, so we postpone it for 0.55. -- ------------------------------------------------------------------------ Honza Pazdziora | ad...@fi... | http://www.fi.muni.cz/~adelton/ .project: Perl, DBI, Oracle, MySQL, auth. WWW servers, MTB, Spain, ... ------------------------------------------------------------------------ |