The culprit seems to be the
EnumSystemLocales(EnumLocalesProc, LCID_SUPPORTED);
call in ViewSettingsDlg::OnInitDialog(). If I comment out that line, the dialog works ok.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Weird. I added the breakpoint to begin of ViewSettingsDlg::EnumLocalesProc(). And just continued the excution right after the breakpoint was hit. Now the dialog appeared Ok. And seems the dialog appears every time now, without crashes.
So this is some kind of initialization/first run problem?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I started getting similar crash with WinXP too. And now I got the stack too! So this appears to be a problem with formatting the offset in hex edit view.
I fixed this by simple checking the return value of sprintf() before using that return value for memset(). This fixes the crash, but is not the "real" fix.
I don't believe that is the fix for these crashes though. This time it crashed in different place than previous times. So I think we have some other corruption elsewhere. But somehow it relates to opening View Settings -dialog.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The culprit seems to be the
EnumSystemLocales(EnumLocalesProc, LCID_SUPPORTED);
call in ViewSettingsDlg::OnInitDialog(). If I comment out that line, the dialog works ok.
Weird. I added the breakpoint to begin of ViewSettingsDlg::EnumLocalesProc(). And just continued the excution right after the breakpoint was hit. Now the dialog appeared Ok. And seems the dialog appears every time now, without crashes.
So this is some kind of initialization/first run problem?
The patch
I started getting similar crash with WinXP too. And now I got the stack too! So this appears to be a problem with formatting the offset in hex edit view.
I fixed this by simple checking the return value of sprintf() before using that return value for memset(). This fixes the crash, but is not the "real" fix.
Attaching patch (Fix_offset_format_crash.patch).
File Added: Fix_offset_format_crash.patch
Fix committed to SVN trunk:
Completed: At revision: 365
I don't believe that is the fix for these crashes though. This time it crashed in different place than previous times. So I think we have some other corruption elsewhere. But somehow it relates to opening View Settings -dialog.
Closing as I haven't seen this happen for recent versions.