From: Jason W. <jas...@gm...> - 2011-02-28 08:13:43
|
This is set of patches created against the last stable release. A quick glance told me there shouldn't be any conflicts but I'm not sure. menu-behavior - The patch makes menus hidden while their callback executes. If a window is clicked while another menu is open then the old menu disappears AND a new menu appears if the button is bound to a menu. In win32 menus do become the active window when they appear. The changes needed to make that happen in X11 are not there (I do not even know if they are needed). menu-size-glitch - This patch fixes a visual flaw where menus appear before they are resized in the window system, resulting in a momentary glitch. This is a simple "hack" fix that just makes the glitch invisible. A "proper" fix may not be needed if this is acceptable. msvc-runtime-check - If you enable "smaller type check" in MSVC compile options the truncation of wParam during key presses triggers a runtime exception. This is fixed by explicitly anding (&) wParam with 255 before casting to char. win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash for me if no windows have been created. I may be using the function incorrectly but my code seems identical to others who have not reported this crash. This patch fixes this crash by not relying on there being an existing window to query pixel formats. win32-fullscreen-multimon - going fullscreen would put the window on the monitor that has 0,0 as its origin. This patch makes it so that the monitor that the window has the majority of its area in is the one that it occupies after going fullscreen. This lets me open one fullscreen window on each monitor if I drag each window to that monitor and make them fullscreen there. This is nice for user interaction but if the programmer wishes for each monitor to have a fullscreen window without the user placing them there an extension may be needed. win32-message-pump - Check timers and joysticks between windows messages. This is cheap and seems more correct. win32-set-position - makes glutGet(GLUT_WINDOW_X), glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the window's client area coordinates to position the window. This may be wrong. The change was made in positioning the window, but if using client area coordinates is wrong then the change should actually be made to glutGet. I have also included a copy of the full patch. |
From: John T. <nu...@me...> - 2011-02-28 15:20:36
|
On Mon, Feb 28, 2011 at 02:13:15AM -0600, Jason Wilkins wrote: > > win32-set-position - makes glutGet(GLUT_WINDOW_X), > glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the > window's client area coordinates to position the window. This may be > wrong. The change was made in positioning the window, but if using > client area coordinates is wrong then the change should actually be > made to glutGet. Using the client area on window positioning is consistent with the behaviour on X11 too where the program has no access to the frame (if there is one) anyway, since that's a separate window belonging to the window manager. -- John Tsiombikas http://nuclear.mutantstargoat.com/ |
From: Jason W. <jas...@gm...> - 2011-02-28 22:10:08
|
There is a blurb in the docs about the difference between windows and X on the issue but I'm not sure where it is. Someone also said I should see previous discussions but I could not find the list archive. My google-fu is failing me On Feb 28, 2011, at 9:20 AM, John Tsiombikas <nu...@me...> wrote: > On Mon, Feb 28, 2011 at 02:13:15AM -0600, Jason Wilkins wrote: >> >> win32-set-position - makes glutGet(GLUT_WINDOW_X), >> glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the >> window's client area coordinates to position the window. This may be >> wrong. The change was made in positioning the window, but if using >> client area coordinates is wrong then the change should actually be >> made to glutGet. > > Using the client area on window positioning is consistent with the > behaviour on X11 too where the program has no access to the frame (if > there is one) anyway, since that's a separate window belonging to the > window manager. > > -- > John Tsiombikas > http://nuclear.mutantstargoat.com/ > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer |
From: Diederick C. N. <dc...@gm...> - 2011-03-01 01:28:27
|
Hi Jason, Thanks for the patches! Just a quick note: your full patch file is significantly shorter than the menu-behavior patch by itself, making me think something was missed there. In any case, what we do now is wait for a person with SVN access to put these in. John (Fay) for instance has indicated he is going to be too busy for the coming months (and he has more patches in his queue), so it mught be a while. Thanks again and do let us know when you hit on more issues / fixes. Best, Dee On Mon, Feb 28, 2011 at 16:13, Jason Wilkins <jas...@gm...> wrote: > This is set of patches created against the last stable release. A > quick glance told me there shouldn't be any conflicts but I'm not > sure. > > menu-behavior - The patch makes menus hidden while their callback > executes. If a window is clicked while another menu is open then the > old menu disappears AND a new menu appears if the button is bound to a > menu. In win32 menus do become the active window when they appear. > The changes needed to make that happen in X11 are not there (I do not > even know if they are needed). > > menu-size-glitch - This patch fixes a visual flaw where menus appear > before they are resized in the window system, resulting in a momentary > glitch. This is a simple "hack" fix that just makes the glitch > invisible. A "proper" fix may not be needed if this is acceptable. > > msvc-runtime-check - If you enable "smaller type check" in MSVC > compile options the truncation of wParam during key presses triggers a > runtime exception. This is fixed by explicitly anding (&) wParam with > 255 before casting to char. > > win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash > for me if no windows have been created. I may be using the function > incorrectly but my code seems identical to others who have not > reported this crash. This patch fixes this crash by not relying on > there being an existing window to query pixel formats. > > win32-fullscreen-multimon - going fullscreen would put the window on > the monitor that has 0,0 as its origin. This patch makes it so that > the monitor that the window has the majority of its area in is the one > that it occupies after going fullscreen. This lets me open one > fullscreen window on each monitor if I drag each window to that > monitor and make them fullscreen there. This is nice for user > interaction but if the programmer wishes for each monitor to have a > fullscreen window without the user placing them there an extension may > be needed. > > win32-message-pump - Check timers and joysticks between windows > messages. This is cheap and seems more correct. > > win32-set-position - makes glutGet(GLUT_WINDOW_X), > glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the > window's client area coordinates to position the window. This may be > wrong. The change was made in positioning the window, but if using > client area coordinates is wrong then the change should actually be > made to glutGet. > > I have also included a copy of the full patch. > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer > > |
From: Jason W. <jas...@gm...> - 2011-03-01 06:58:51
|
You are right, I accidentally overwrote my full patch file while I was splitting it up, so it isn't valid. I guess you'll let me know if anything doesn't work :) On Mon, Feb 28, 2011 at 7:28 PM, Diederick C. Niehorster <dc...@gm...> wrote: > Hi Jason, > > Thanks for the patches! Just a quick note: your full patch file is > significantly shorter than the menu-behavior patch by itself, making > me think something was missed there. > > In any case, what we do now is wait for a person with SVN access to > put these in. John (Fay) for instance has indicated he is going to be > too busy for the coming months (and he has more patches in his queue), > so it mught be a while. > > Thanks again and do let us know when you hit on more issues / fixes. > > Best, > Dee > > On Mon, Feb 28, 2011 at 16:13, Jason Wilkins <jas...@gm...> wrote: >> This is set of patches created against the last stable release. A >> quick glance told me there shouldn't be any conflicts but I'm not >> sure. >> >> menu-behavior - The patch makes menus hidden while their callback >> executes. If a window is clicked while another menu is open then the >> old menu disappears AND a new menu appears if the button is bound to a >> menu. In win32 menus do become the active window when they appear. >> The changes needed to make that happen in X11 are not there (I do not >> even know if they are needed). >> >> menu-size-glitch - This patch fixes a visual flaw where menus appear >> before they are resized in the window system, resulting in a momentary >> glitch. This is a simple "hack" fix that just makes the glitch >> invisible. A "proper" fix may not be needed if this is acceptable. >> >> msvc-runtime-check - If you enable "smaller type check" in MSVC >> compile options the truncation of wParam during key presses triggers a >> runtime exception. This is fixed by explicitly anding (&) wParam with >> 255 before casting to char. >> >> win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash >> for me if no windows have been created. I may be using the function >> incorrectly but my code seems identical to others who have not >> reported this crash. This patch fixes this crash by not relying on >> there being an existing window to query pixel formats. >> >> win32-fullscreen-multimon - going fullscreen would put the window on >> the monitor that has 0,0 as its origin. This patch makes it so that >> the monitor that the window has the majority of its area in is the one >> that it occupies after going fullscreen. This lets me open one >> fullscreen window on each monitor if I drag each window to that >> monitor and make them fullscreen there. This is nice for user >> interaction but if the programmer wishes for each monitor to have a >> fullscreen window without the user placing them there an extension may >> be needed. >> >> win32-message-pump - Check timers and joysticks between windows >> messages. This is cheap and seems more correct. >> >> win32-set-position - makes glutGet(GLUT_WINDOW_X), >> glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the >> window's client area coordinates to position the window. This may be >> wrong. The change was made in positioning the window, but if using >> client area coordinates is wrong then the change should actually be >> made to glutGet. >> >> I have also included a copy of the full patch. >> >> ------------------------------------------------------------------------------ >> Free Software Download: Index, Search & Analyze Logs and other IT data in >> Real-Time with Splunk. Collect, index and harness all the fast moving IT data >> generated by your applications, servers and devices whether physical, virtual >> or in the cloud. Deliver compliance at lower cost and gain new business >> insights. http://p.sf.net/sfu/splunk-dev2dev >> _______________________________________________ >> Freeglut-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freeglut-developer >> >> > |
From: John F. <joh...@cy...> - 2011-03-16 04:22:31
|
Jason, I'm having trouble putting your patches into SVN. It looks like you generated them with a series of "diff" commands rather than a single "svn diff" command. Can you send them again please? There's a decent chance that I've already put one or two of them in. Also, you'll need to update your local copy from SVN before doing the "diff". - John On 2/28/2011 2:13 AM, Jason Wilkins wrote: > This is set of patches created against the last stable release. A > quick glance told me there shouldn't be any conflicts but I'm not > sure. > > menu-behavior - The patch makes menus hidden while their callback > executes. If a window is clicked while another menu is open then the > old menu disappears AND a new menu appears if the button is bound to a > menu. In win32 menus do become the active window when they appear. > The changes needed to make that happen in X11 are not there (I do not > even know if they are needed). > > menu-size-glitch - This patch fixes a visual flaw where menus appear > before they are resized in the window system, resulting in a momentary > glitch. This is a simple "hack" fix that just makes the glitch > invisible. A "proper" fix may not be needed if this is acceptable. > > msvc-runtime-check - If you enable "smaller type check" in MSVC > compile options the truncation of wParam during key presses triggers a > runtime exception. This is fixed by explicitly anding (&) wParam with > 255 before casting to char. > > win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash > for me if no windows have been created. I may be using the function > incorrectly but my code seems identical to others who have not > reported this crash. This patch fixes this crash by not relying on > there being an existing window to query pixel formats. > > win32-fullscreen-multimon - going fullscreen would put the window on > the monitor that has 0,0 as its origin. This patch makes it so that > the monitor that the window has the majority of its area in is the one > that it occupies after going fullscreen. This lets me open one > fullscreen window on each monitor if I drag each window to that > monitor and make them fullscreen there. This is nice for user > interaction but if the programmer wishes for each monitor to have a > fullscreen window without the user placing them there an extension may > be needed. > > win32-message-pump - Check timers and joysticks between windows > messages. This is cheap and seems more correct. > > win32-set-position - makes glutGet(GLUT_WINDOW_X), > glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the > window's client area coordinates to position the window. This may be > wrong. The change was made in positioning the window, but if using > client area coordinates is wrong then the change should actually be > made to glutGet. > > I have also included a copy of the full patch. > > > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > > > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer > |
From: Jason W. <jas...@gm...> - 2011-03-17 05:54:52
|
I didn't use svn to generate the patch, I used diff. They should be apply-able if you use patch. I don't have a working copy make a patch from using svn. On Tue, Mar 15, 2011 at 11:22 PM, John Fay <joh...@cy...> wrote: > Jason, > > I'm having trouble putting your patches into SVN. It looks like you > generated them with a series of "diff" commands rather than a single "svn > diff" command. Can you send them again please? > > There's a decent chance that I've already put one or two of them in. > Also, you'll need to update your local copy from SVN before doing the > "diff". > > - John > > > On 2/28/2011 2:13 AM, Jason Wilkins wrote: > > This is set of patches created against the last stable release. A > quick glance told me there shouldn't be any conflicts but I'm not > sure. > > menu-behavior - The patch makes menus hidden while their callback > executes. If a window is clicked while another menu is open then the > old menu disappears AND a new menu appears if the button is bound to a > menu. In win32 menus do become the active window when they appear. > The changes needed to make that happen in X11 are not there (I do not > even know if they are needed). > > menu-size-glitch - This patch fixes a visual flaw where menus appear > before they are resized in the window system, resulting in a momentary > glitch. This is a simple "hack" fix that just makes the glitch > invisible. A "proper" fix may not be needed if this is acceptable. > > msvc-runtime-check - If you enable "smaller type check" in MSVC > compile options the truncation of wParam during key presses triggers a > runtime exception. This is fixed by explicitly anding (&) wParam with > 255 before casting to char. > > win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash > for me if no windows have been created. I may be using the function > incorrectly but my code seems identical to others who have not > reported this crash. This patch fixes this crash by not relying on > there being an existing window to query pixel formats. > > win32-fullscreen-multimon - going fullscreen would put the window on > the monitor that has 0,0 as its origin. This patch makes it so that > the monitor that the window has the majority of its area in is the one > that it occupies after going fullscreen. This lets me open one > fullscreen window on each monitor if I drag each window to that > monitor and make them fullscreen there. This is nice for user > interaction but if the programmer wishes for each monitor to have a > fullscreen window without the user placing them there an extension may > be needed. > > win32-message-pump - Check timers and joysticks between windows > messages. This is cheap and seems more correct. > > win32-set-position - makes glutGet(GLUT_WINDOW_X), > glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the > window's client area coordinates to position the window. This may be > wrong. The change was made in positioning the window, but if using > client area coordinates is wrong then the change should actually be > made to glutGet. > > I have also included a copy of the full patch. > > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT > data > generated by your applications, servers and devices whether physical, > virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer > > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer > > |
From: Diederick C. N. <dc...@gm...> - 2013-04-04 10:23:25
|
Hi Jason, I saw some of these patches never made it in. I have resolved the issues you identified in menu-behavior and msvc-runtime-check, though with somewhat different approaches (code has changed quite a bit since you posted these...) I also had another look at menu-size-glitch, and now menus simply aren't shown and then quickly hidden again when first created. Thanks again for sending all these in! Best, Dee On Thu, Mar 17, 2011 at 1:54 PM, Jason Wilkins <jas...@gm...> wrote: > I didn't use svn to generate the patch, I used diff. They should be > apply-able if you use patch. I don't have a working copy make a patch > from using svn. > > > > On Tue, Mar 15, 2011 at 11:22 PM, John Fay <joh...@cy...> wrote: >> Jason, >> >> I'm having trouble putting your patches into SVN. It looks like you >> generated them with a series of "diff" commands rather than a single "svn >> diff" command. Can you send them again please? >> >> There's a decent chance that I've already put one or two of them in. >> Also, you'll need to update your local copy from SVN before doing the >> "diff". >> >> - John >> >> >> On 2/28/2011 2:13 AM, Jason Wilkins wrote: >> >> This is set of patches created against the last stable release. A >> quick glance told me there shouldn't be any conflicts but I'm not >> sure. >> >> menu-behavior - The patch makes menus hidden while their callback >> executes. If a window is clicked while another menu is open then the >> old menu disappears AND a new menu appears if the button is bound to a >> menu. In win32 menus do become the active window when they appear. >> The changes needed to make that happen in X11 are not there (I do not >> even know if they are needed). >> >> menu-size-glitch - This patch fixes a visual flaw where menus appear >> before they are resized in the window system, resulting in a momentary >> glitch. This is a simple "hack" fix that just makes the glitch >> invisible. A "proper" fix may not be needed if this is acceptable. >> >> msvc-runtime-check - If you enable "smaller type check" in MSVC >> compile options the truncation of wParam during key presses triggers a >> runtime exception. This is fixed by explicitly anding (&) wParam with >> 255 before casting to char. >> >> win32-check-possible - glutGet(GLUT_DISPLAY_MODE_POSSIBLE) would crash >> for me if no windows have been created. I may be using the function >> incorrectly but my code seems identical to others who have not >> reported this crash. This patch fixes this crash by not relying on >> there being an existing window to query pixel formats. >> >> win32-fullscreen-multimon - going fullscreen would put the window on >> the monitor that has 0,0 as its origin. This patch makes it so that >> the monitor that the window has the majority of its area in is the one >> that it occupies after going fullscreen. This lets me open one >> fullscreen window on each monitor if I drag each window to that >> monitor and make them fullscreen there. This is nice for user >> interaction but if the programmer wishes for each monitor to have a >> fullscreen window without the user placing them there an extension may >> be needed. >> >> win32-message-pump - Check timers and joysticks between windows >> messages. This is cheap and seems more correct. >> >> win32-set-position - makes glutGet(GLUT_WINDOW_X), >> glutGet(GLUT_WINDOW_Y) and glutPositionWindow consistent. I use the >> window's client area coordinates to position the window. This may be >> wrong. The change was made in positioning the window, but if using >> client area coordinates is wrong then the change should actually be >> made to glutGet. >> >> I have also included a copy of the full patch. >> >> >> ------------------------------------------------------------------------------ >> Free Software Download: Index, Search & Analyze Logs and other IT data in >> Real-Time with Splunk. Collect, index and harness all the fast moving IT >> data >> generated by your applications, servers and devices whether physical, >> virtual >> or in the cloud. Deliver compliance at lower cost and gain new business >> insights. http://p.sf.net/sfu/splunk-dev2dev >> >> _______________________________________________ >> Freeglut-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freeglut-developer >> >> >> ------------------------------------------------------------------------------ >> Colocation vs. Managed Hosting >> A question and answer guide to determining the best fit >> for your organization - today and in the future. >> http://p.sf.net/sfu/internap-sfd2d >> _______________________________________________ >> Freeglut-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freeglut-developer >> >> > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > Freeglut-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freeglut-developer |