Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#18 README and dump.c fixes

closed-accepted
nobody
None
5
2012-08-05
2012-07-30
Jose Da Silva
No

Started hunting for files, added a couple more pointers to the README, also fixed the buffer[] to NOT point to 401 or 201 (C starts at zero)

Discussion

  • Jose Da Silva
    Jose Da Silva
    2012-07-30

    file pointer updates, removed buffer[] errors introduced earlier in previous dump.c.diff

     
    Attachments
  • Thanks, applied.
    But I had chance to run newer version of cppcheck and got:

    [fontforge/Unicode/dump.c:542]: (error) Uninitialized variable: j
    [fontforge/Unicode/dump.c:544]: (error) Uninitialized variable: j
    [fontforge/Unicode/dump.c:650]: (error) Uninitialized variable: j
    [fontforge/Unicode/dump.c:652]: (error) Uninitialized variable: j

     
  • Jose Da Silva
    Jose Da Silva
    2012-08-04

    correction for 4 errors described 2012aug4

     
    Attachments
  • Jose Da Silva
    Jose Da Silva
    2012-08-04

    I've gone and searched for cppcheck, found it, compiled it now.
    seems to be a useful program to catch stuff missed by gcc during compile.

    Those errors are fixed now, was optimizing routines to not bother initializing stuff if they branched into the else statement, but those two particular if statements made use of the j for the array. I've uploaded a patch.

     
  • Thanks, applied.

     
    • status: open --> closed-accepted