I've gone and searched for cppcheck, found it, compiled it now.
seems to be a useful program to catch stuff missed by gcc during compile.
Those errors are fixed now, was optimizing routines to not bother initializing stuff if they branched into the else statement, but those two particular if statements made use of the j for the array. I've uploaded a patch.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
file pointer updates, removed buffer[] errors introduced earlier in previous dump.c.diff
Thanks, applied.
But I had chance to run newer version of cppcheck and got:
[fontforge/Unicode/dump.c:542]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:544]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:650]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:652]: (error) Uninitialized variable: j
correction for 4 errors described 2012aug4
I've gone and searched for cppcheck, found it, compiled it now.
seems to be a useful program to catch stuff missed by gcc during compile.
Those errors are fixed now, was optimizing routines to not bother initializing stuff if they branched into the else statement, but those two particular if statements made use of the j for the array. I've uploaded a patch.
Thanks, applied.