Menu

#1138 fluxbox-remote.cc:76: bad if test

v1.4.0
closed-accepted
None
5
2016-07-30
2015-10-31
dcb
No

util/fluxbox-remote.cc:76:34: warning: ordered comparison of pointer with integer zero [-Wextra]

Source code is

    && text_prop.value > 0

Suggest new code

    && text_prop.value != 0

Discussion

  • Mathias Gumz

    Mathias Gumz - 2015-11-02

    someone provided a mergable patch: https://github.com/jnse/fluxbox/tree/bugfix/1138

    but good catch! thanx!!

     

    Last edit: Mathias Gumz 2015-11-02
  • Mathias Gumz

    Mathias Gumz - 2015-11-02
    • status: open --> open-accepted
    • assigned_to: Mathias Gumz
    • Group: future release --> v1.3.8
     
  • Mathias Gumz

    Mathias Gumz - 2016-01-09

    merged, thanx!

     
  • Mathias Gumz

    Mathias Gumz - 2016-01-09
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.