#7 in_flac retaining open file handle

[aihtdikh]

A very minor annoyance:
when the in_flac pugin starts reading a file, then
fails when reading the metadata, it neglects to close
the file until another file is played or winamp is closed.

I observed this in winamp5, but I think it would affect
2 as well.

Anyway, the fix is simple - at line 79 in
plugin_winamp2/in_flac.c

if \(\!FLAC\_plugin\_\_decoder\_init\(decoder\_, fn, filesize,

&file_info_, &flac_cfg.output))
return 1;

needs to be changed to

if \(\!FLAC\_plugin\_\_decoder\_init\(decoder\_, fn, filesize,

&file_info_, &flac_cfg.output))
{
FLAC_plugin__decoder_finish(decoder_);
return 1;
}

Far from a priority, but here it is, in case anyone
wants to check and commit it.

Also, thanks for a great project, guys - FLAC (in fact,
all the xiph stuff) is an excellent example of what can
be achieved - you rock.

[Josh Coalson]

Logged In: YES
user_id=78173

thanks, this is fixed in CVS.

Josh