#27 fix missing include in flac-1.2.1

closed-fixed
Josh Coalson
None
6
2014-08-10
2007-11-18
No

GCC 4.3 cleans up the include dependencies of the C++ stdlib headers. The
result is some packages have missing includes. This patch fixes one such error
in flac-1.2.1.

make[5]: Entering directory
`/var/tmp/portage/media-libs/flac-1.2.1-r1/work/flac-1.2.1/examples/cpp/encode/file'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../..
-DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include
-I../../../../include -O2 -g -march=native -fomit-frame-pointer -pipe -c -o
main.o main.cpp
main.cpp: In function 'int main(int, char**)':
main.cpp:75: error: 'memcmp' was not declared in this scope
make[5]: *** [main.o] Error 1

Discussion

    • summary: fix missing include in media-sound/flac-1.2.1 --> fix missing include in flac-1.2.1
     
  • Josh Coalson
    Josh Coalson
    2007-11-26

    Logged In: YES
    user_id=78173
    Originator: NO

    for source consistency I'd prefer to use the C headers, does

    #include <string.h>

    also work? (instead of <cstring>)

     
  • Josh Coalson
    Josh Coalson
    2007-11-26

    • priority: 5 --> 6
    • assigned_to: nobody --> jcoalson
    • status: open --> open-accepted
     
  • Logged In: YES
    user_id=1415513
    Originator: YES

    yep, that works fine.

     
  • Josh Coalson
    Josh Coalson
    2007-11-27

    • status: open-accepted --> closed-fixed
     
  • Josh Coalson
    Josh Coalson
    2007-11-27

    Logged In: YES
    user_id=78173
    Originator: NO

    ok, fixed in CVS