#17 CVS 2006-11-18 and Borland C++

[Jerome Martinez]

Here is a patch which mainly modify only #if defined to be able to work with Borland C++ Builder 2006.
I hope you will integrate it to the CVS.

[Jerome Martinez]

[Josh Coalson]

Logged In: YES
user_id=78173
Originator: NO

OK, I checked in most of it, but it's not entirely correct (src/libFLAC/metadata_iterators.c breaks _MSC_VER logic), also the very first part of src/libFLAC/format.c, I would prefer that you find a way to set VERSION in the build system instead. can you get the latest from CVS and send one more patch? it should be within the next couple of days in order to make it into flac-1.1.3

thanks,
Josh

[Jerome Martinez]

Logged In: YES
user_id=801394
Originator: YES

* 2nd version from CVS of November 20th.
* src/libFLAC/metadata_iterators.c : yes, I did an error, corrected in the 2nd version of the patch.
* There are other file not patched in the CVS, included in the 2nd patch.
* I don't understand this method:
#if defined _MSC_VER || defined __MINGW32__
#if _MSC_VER <= 1200 /* @@@ [2G limit] */
#define fseeko fseek
#define ftello ftell
#endif
#endif
(__MINGW32__ definition is useless?)
in 2 of the 3 files containing fseeko/ftello, but I did like you for adding __BORLANDC__.

* Visual C++ 2005 (_MSC_VER=1400) does not support fseeko/ftello too. I replaced in my code with this:
#if defined _MSC_VER || defined __BORLANDC__
#define fseeko fseek
#define ftello ftell
#endif
(but not in the patch file)
* Remark : Visual C++ version of fseeko/ftello is _fseeki64/_ftelli64, but I didn't tested and I don't know which version of . Borland C++ does not support 64-bit versions of fseek/ftell.

[Jerome Martinez]

[Josh Coalson]

Logged In: YES
user_id=78173
Originator: NO

excellent, checked in, thanks.

Josh