From: FFADO <ffa...@ff...> - 2010-07-12 15:24:55
|
#290: Drop external/. Use system's libconfig and libdbus-c++ instead ---------------------+------------------------------------------------------ Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Keywords: | Device_name: ---------------------+------------------------------------------------------ Right now, FFADO ships a private copy of libdbus-c++ and libconfig in the external/ directory. This is usually discouraged by distributions, because those statically builtin copies needs separate treatment in case of security fixes or other issues. The attached patch fixes this issue. On Debian-like systems, install libconfig++8-dev and libdbus-c++-dev to satisfy the external dependencies. -- Ticket URL: <http://subversion.ffado.org/ticket/290> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: FFADO <ffa...@ff...> - 2010-07-14 00:16:04
|
#290: Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Resolution: | Keywords: Device_name: | -----------------------+---------------------------------------------------- Comment (by oget): Actually, I think we should add another clause to dbus check. Currently, the patch disables dbus support only if one of - dbus headers - dbusxx-xml2cpp is missing. - dbus-c++ headers need to be added to this list. I'll update the patch. Off topic: Now I have a trac account I will also post my other patches that are packaging related. Make the .desktop file nicer, put the configuration file in /etc instead of /usr/share/libffado etc. -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:1> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: Adrian K. <ad...@dr...> - 2010-07-14 07:50:22
|
On Wed, Jul 14, 2010 at 12:12:25AM -0000, FFADO wrote: > Comment (by oget): > put the configuration file in /etc instead of /usr/share/libffado etc. This might need some discussion. It's not a configuration file in the typical sense, it's more like "outsourced internal state". One could also hardcode these values into FFADO, but for the sake of flexibility, it's an external file. As long as you have only one version of FFADO installed, it probably doesn't matter where the file resides. But if you go for multiple versions, the config files would collide, hence placing them under some prefix is handy. IOW: no user is ever supposed to edit it, there's no need to backup it and the lot. Just my €0.02 -- mail: ad...@th... http://adi.thur.de PGP/GPG: key via keyserver |
From: Arnold K. <ar...@ar...> - 2010-07-14 08:46:10
|
On Wednesday 14 July 2010 09:50:08 Adrian Knoth wrote: > On Wed, Jul 14, 2010 at 12:12:25AM -0000, FFADO wrote: > > Comment (by oget): > > put the configuration file in /etc instead of /usr/share/libffado etc. > > This might need some discussion. It's not a configuration file in the > typical sense, it's more like "outsourced internal state". > > One could also hardcode these values into FFADO, but for the sake of > flexibility, it's an external file. > > As long as you have only one version of FFADO installed, it probably > doesn't matter where the file resides. But if you go for multiple > versions, the config files would collide, hence placing them under some > prefix is handy. > > IOW: no user is ever supposed to edit it, there's no need to backup it > and the lot. Yep, I go with adi here: its not configuration file in the traditional sense, its the factory provided list of known devices (and some settings). This list can be extended by the user trough ~/.ffado/configuration, but the one in /usr/share/libffado is supposed to be edited only by libffado through install/package management. But I think we could add the ability to look at /etc/ffado/configuration or something like that to provide admins a way to extend the device list system- wide. That is worth a ticket and a discussion. Have fun, Arnold |
From: FFADO <ffa...@ff...> - 2010-07-14 19:34:07
|
#290: Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Resolution: | Keywords: Device_name: | -----------------------+---------------------------------------------------- Comment (by oget): Hi, I just sent the two patches I made. ffado-external-libs-rev3.patch adds two more features: 1- Don't compile dbus support when dbus-c++ headers are missing. This one is definitely needed. 2- Don't link to expat unless SERIALIZE_USE_EXPAT is passed. By default ffado uses libxml++. Serialization via expat is optional. However, expat was also needed for the bundlud copy of dbus-c++. Since we patched that out, we don't need to link to expat anymore, by default. libffado-libconfig145.patch: This is to make ffado compile against libconfig-1.4.5. There was a tiny API change that we needed to take into account. I tested the patch against both libconfig-1.3.2 and libconfig-1.4.5. It works. Needless to say, this patch requires the above patch. -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:2> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: FFADO <ffa...@ff...> - 2010-07-21 17:13:00
|
#290: [Patch] Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Resolution: | Keywords: Device_name: | -----------------------+---------------------------------------------------- Changes (by adi): * summary: Drop external/. Use system's libconfig and libdbus-c++ instead => [Patch] Drop external/. Use system's libconfig and libdbus-c++ instead -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:3> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: FFADO <ffa...@ff...> - 2010-08-02 15:22:31
|
#290: [Patch] Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Resolution: | Keywords: Device_name: | -----------------------+---------------------------------------------------- Comment (by oget): Hello, is there any progress on reviewing this? The patch alters SConstruct files, which are usually modified rather frequently. If this does not get reviewed soon, and the code starts to diverge, then we will need to redo all the work we have done. For the Fedora package, we've been using the ffado-external-libs- rev3.patch and libffado-libconfig145.patch -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:4> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: FFADO <ffa...@ff...> - 2010-08-02 20:52:53
|
#290: [Patch] Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: new Priority: major | Milestone: Component: generic | Version: FFADO SVN (trunk) Resolution: | Keywords: Device_name: | -----------------------+---------------------------------------------------- Changes (by nils): * cc: nils (added) -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:5> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |
From: FFADO <ffa...@ff...> - 2010-09-10 21:53:27
|
#290: [Patch] Drop external/. Use system's libconfig and libdbus-c++ instead -----------------------+---------------------------------------------------- Reporter: adi | Owner: Type: bug | Status: closed Priority: major | Milestone: FFADO 2.1 Component: generic | Version: FFADO SVN (trunk) Resolution: fixed | Keywords: Device_name: | -----------------------+---------------------------------------------------- Changes (by arnonym): * status: new => closed * resolution: => fixed * milestone: => FFADO 2.1 Comment: Thanks for the patches. Applied in r1888. -- Ticket URL: <http://subversion.ffado.org/ticket/290#comment:6> FFADO <http://subversion.ffado.org/index.fcgi> Free Firewire Audio Drivers |