From: Matt P. <ma...@de...> - 2008-03-06 04:26:14
|
Hi guys, I quickly tacked on DROID support in Fez today. It essentially works almost identically to the existing JHOVE integration and creates a 'droid' datastream instead of a 'presmd' datastream. I haven't had greatly positive experiences with DROID's file identification today - reporting of M$ files in particular is rather suspect - but it's possible that the mimetype identification provided by DROID may be superior to the current method in Fez. As an aside, there appears to be a fair amount of duplicated code in both the /webservices files and particuarly in class.misc.php (replicated fragments of largely identical code in cleanDatastreamListLite() and cleanDatastreamList() for a start), and areas for implementation of cleaner functionality. In particular, there are several common operations in this file that are performed on special datastream IDs ('presmd_', 'web_', etc) so it would make more sense to stuff these in an array of constants and just iterate over them when they're required rather than specifying as strings throughout the place... ... anyway, this is a roundabout way of saying that I haven't implemented it as cleanly as I would ordinarily like and have resorted to copying and pasting in places. This could, of course, also just be seen as a feeble excuse ;) If you'd like it, I can send you the files/patches. If you don't, that's fine - it was really just for our own investigation (and for me to get away from defect resolution / writing documentation) ;) M -- Matt Painter http://deity.co.nz ma...@de... +64 21 115 9378 |