#673 Pal mode & fullscreen -> yscale out of bounds

[Niklas Blomkvist]

If I turn on PAL mode and switch to fullscreen I get the error message "yscale out of bounds" and fceux disappears but continues to run with audio. This is because of lines 332-336 in drivers/sdl/sdl-video.cpp and the condition yres < s_tlines * s_eys.

When I run it I have that yres is 448, s_tlines is 240 and s_eys is 1.8666666666666667 (as gdb puts it). The problem seems to be that 240 * 1.8666666666666667 is just a tiny bit larger than 448. I'm guessing the condition yres < s_tlines * s_eys is then true more due to comparing an int with a double than due to a real problem. As far as I can tell, fceux manages to put up fullscreen video in PAL mode without problem if I make it skip these lines.

I've only used version 2.2.2 as I couldn't get the latest code in the repistory to compile, but sdl-video.cpp is still identical between the two.

[Lukas Sabota]

Thank you for bringing this to our attention with this bug report. I will look into this patch when I get a chance (and once the SDL trunk is in a sane state - some recent commits need to be reversed so that SDL trunk will compile once again)

Accepting this issue