Menu

#107 Handling additional lines in the localized exultmsg.txt

None
closed-accepted
None
5
2017-06-07
2016-02-08
No

The French and German localizations of exultmsg.txt add more text than we previously accounted for.
These are two different patches to deal with this:
http://pastebin.com/p7FZCQE6 (local1.diff) renumbers the exultmsg files, changes items.h accordingly and fixes bggame.cc to display the additional lines.

http://pastebin.com/6hbdDxcX (local2.diff) only gives the new lines new numbers, adds new const ints in items.h and fixes bggame.cc to display the additional lines.

Both work, the 2nd one looks a bit more hacky, IMO. OTOH if for any reason we need to dislay even more lines in the future, the 2nd one is easier to expand.

2 Attachments

Discussion

  • Dominik Reichardt

    maybe a better way to make it more future proof would be to make the intro/final messages into a file that assigns "blocks" (e.g. from 0x?1A to 0x?1F) of text, so if you need to add lines, you just add them to the block and be done with it...
    But that would also mean a rewrite of the current way...

     
  • Dominik Reichardt

    Another patch local1+congrats.diff, adds the congratulations screen to the endgame.
    The congrats text is added to the end of exultmsg. can be moved up to the BG endign stuff and numbered accordingly.

    BUT it needs a check whether from a game or viewed from the menu.
    AND it needs to grab the time it took to complete the game
    http://pastebin.com/QWDD0DpX

     

    Last edit: Dominik Reichardt 2016-02-09
  • Dominik Reichardt

    The French final is not painting the Guardian's long speech orange, in both the original and Exult.

     
  • Dominik Reichardt

    • status: open --> closed-accepted
    • assigned_to: Dominik Reichardt
    • Group: -->
     
  • Dominik Reichardt

    I applied the 1st patch + congratulation differences. Needed to tweak the bggame.cc changes a bit to properly show everything.
    https://github.com/exult/exult/commit/f162ad8ac4f6c63269ddc3e63e13f2f061954c79

     

    Last edit: Dominik Reichardt 2017-06-07