From: Steve V. <vi...@ie...> - 2008-01-21 20:17:39
|
The yaws-1.74/scripts/redhat/yaws.init.d script always prints "failure" on Linux when you stop yaws, regardless of whether there's actually an error, because it doesn't check for the right string coming from the "yaws --stop" command. I'm happy to write a patch for this minor issue, but before doing so I was wondering whether there were other known issues with the init.d script that I might also tackle? thanks, --steve |
From: Claes W. <kl...@ta...> - 2008-01-21 20:29:58
|
Steve Vinoski wrote: > The yaws-1.74/scripts/redhat/yaws.init.d script always prints > "failure" on Linux when you stop yaws, regardless of whether there's > actually an error, because it doesn't check for the right string > coming from the "yaws --stop" command. > > I'm happy to write a patch for this minor issue, but before doing so I > was wondering whether there were other known issues with the init.d > script that I might also tackle? > please do - I don't have any redhat system available to test on. /klacke |
From: Steve V. <vi...@ie...> - 2008-02-16 05:43:20
|
On 1/21/08, Claes Wikstrom <kl...@ta...> wrote: > Steve Vinoski wrote: > > The yaws-1.74/scripts/redhat/yaws.init.d script always prints > > "failure" on Linux when you stop yaws, regardless of whether there's > > actually an error, because it doesn't check for the right string > > coming from the "yaws --stop" command. > > > > I'm happy to write a patch for this minor issue, but before doing so I > > was wondering whether there were other known issues with the init.d > > script that I might also tackle? > > please do - I don't have any redhat system available > to test on. Here's one possible patch for this issue. --steve Index: scripts/redhat/yaws.init.d =================================================================== --- scripts/redhat/yaws.init.d (revision 1218) +++ scripts/redhat/yaws.init.d (working copy) @@ -14,8 +14,13 @@ yaws=%prefix%/bin/yaws prog=yaws -#yawsid_opts=--id =myserverid -conf="--conf %etcdir%/yaws.conf" +# +# Default yawsid is "default". If you change this to another ID, +# be sure to also uncomment the yawsid_opts line just below. +# +yawsid=default +#yawsid_opts="--id $yawsid" +conf="--conf %etcdir%yaws.conf" start() { echo -n $"Starting $prog: " @@ -29,7 +34,7 @@ stop() { echo -n $"Stopping $prog: " str=`$yaws ${yawsid_opts} --stop` - if [ "$str" = "stopping" ]; then + if [ "$str" = "stopping yaws with id=$yawsid" ]; then echo_success RETVAL=0 else |
From: Claes W. <kl...@ta...> - 2008-02-17 16:07:09
|
Steve Vinoski wrote: > > Here's one possible patch for this issue. > Thanks alot - applied in trunk /klacke |