#85 Option files not closed after readfp()

v3.0
closed-fixed
Edward Loper
5
2006-04-04
2006-04-04
Pierre Rouleau
No

Minor problem: config files not closed at end of use.
Revision 1157.

Suggestion:
-----------

Index: cli.py

@@ -261,6 +261,7 @@
fp = open(configfile, 'r') # may raise IOError.
log.debug('here2')
configparser.readfp(fp, configfile)
+ fp.close()
for optname in configparser.options('epydoc'):
val = configparser.get('epydoc', optname).strip()
if optname in ('modules', 'objects', 'values',

Discussion

  • Edward Loper
    Edward Loper
    2006-04-04

    Logged In: YES
    user_id=195958

    Fixed in subversion, revision 1159
    (And I got rid of those debug printfs while I was at it)

     
  • Edward Loper
    Edward Loper
    2006-04-04

    • status: open --> closed-fixed