From: Dr. M. L. <mi...@va...> - 2007-08-06 15:26:30
|
Enlightenment CVS wrote: > Enlightenment CVS committal > Author : andreas > Project : e17 > Module : proto > Dir : e17/proto/eflpp/src/edje > Modified Files: > eflpp_edje.cpp eflpp_edje.h > Log Message: > little API change for get/set consistence and examples update > =================================================================== > RCS file: /cvs/e/e17/proto/eflpp/src/edje/eflpp_edje.cpp,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -3 -r1.1 -r1.2 > --- eflpp_edje.cpp 3 Jul 2007 22:42:36 -0000 1.1 > +++ eflpp_edje.cpp 6 Aug 2007 09:00:48 -0000 1.2 > @@ -53,13 +53,21 @@ > return ( errorcode == 0 ); > } > > -Size EvasEdje::minimalSize() const > +Size EvasEdje::getMinimalSize() const Mmmh, actually I would prefer it the other way. I didn't add the get prefix for all getters on purpose. It is inspired by Qt style which I consider being a good C++ programming style. Regards, :M: -- Michael 'Mickey' Lauer | IT-Freelancer | http://www.vanille-media.de |
From: Andreas V. <li...@br...> - 2007-08-17 18:30:13
|
Am Mon, 6 Aug 2007 17:26:22 +0200 schrieb Dr. Michael Lauer: > Enlightenment CVS wrote: > > Enlightenment CVS committal > > > Author : andreas > > Project : e17 > > Module : proto > > > Dir : e17/proto/eflpp/src/edje > > > > Modified Files: > > eflpp_edje.cpp eflpp_edje.h > > > > Log Message: > > little API change for get/set consistence and examples update > > > =================================================================== > > RCS file: /cvs/e/e17/proto/eflpp/src/edje/eflpp_edje.cpp,v > > retrieving revision 1.1 > > retrieving revision 1.2 > > diff -u -3 -r1.1 -r1.2 > > --- eflpp_edje.cpp 3 Jul 2007 22:42:36 -0000 1.1 > > +++ eflpp_edje.cpp 6 Aug 2007 09:00:48 -0000 1.2 > > @@ -53,13 +53,21 @@ > > return ( errorcode == 0 ); > > } > > > > -Size EvasEdje::minimalSize() const > > +Size EvasEdje::getMinimalSize() const > > Mmmh, actually I would prefer it the other way. I didn't add the get > prefix for all getters on purpose. It is inspired by Qt style which I > consider being a good C++ programming style. As you see I changed it back. Sorry for the late answer. This and ~500 other mails from mailing lists were lost in my stupid server side spam filter. :-( regards Andreas |