From: Cedric B. <ced...@fr...> - 2012-07-04 00:58:37
|
ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua 5.1 ? As far as I remember we avoided moving to 5.2 because they did break their API/ABI. If this break 5.1, then revert ! On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN <no-...@en...> wrote: > Log: > unbork edje-lua on 5.2 > > Author: quaker > Date: 2012-07-03 07:08:09 -0700 (Tue, 03 Jul 2012) > New Revision: 73240 > Trac: http://trac.enlightenment.org/e/changeset/73240 > > Modified: > trunk/edje/src/lib/edje_lua2.c > > Modified: trunk/edje/src/lib/edje_lua2.c > =================================================================== > --- trunk/edje/src/lib/edje_lua2.c 2012-07-03 13:53:44 UTC (rev 73239) > +++ trunk/edje/src/lib/edje_lua2.c 2012-07-03 14:08:09 UTC (rev 73240) > @@ -180,7 +180,7 @@ > > static int _elua_obj_gc(lua_State *L); > > -static const struct luaL_reg _elua_edje_gc_funcs [] = > +static const struct luaL_Reg _elua_edje_gc_funcs [] = > { > {"__gc", _elua_obj_gc}, // garbage collector func for edje objects > > @@ -635,7 +635,7 @@ > //static int _elua_textblock(lua_State *L); /* XXX: disabled until there are enough textblock functions implemented to make it actually useful > > static const char *_elua_edje_api = "edje"; > -static const struct luaL_reg _elua_edje_funcs [] = > +static const struct luaL_Reg _elua_edje_funcs [] = > { > // add an echo too to make it more shelly > {"echo", _elua_echo}, // test func - echo (i know we have print. test) > @@ -1714,7 +1714,7 @@ > static int _elua_obj_map_enable(lua_State *L); > > static const char *_elua_evas_api = "evas"; > -static const struct luaL_reg _elua_evas_funcs [] = > +static const struct luaL_Reg _elua_evas_funcs [] = > { > {"del", _elua_obj_del}, // generic del any object created for edje (evas objects, timers, animators, transitions... everything) > > @@ -2504,7 +2504,7 @@ > holds a reference to an ecore animator object. > */ > static const char *_elua_ecore_animator_api = "ecore_animator"; > -static const struct luaL_reg _elua_ecore_animator_funcs [] = > +static const struct luaL_Reg _elua_ecore_animator_funcs [] = > { > {NULL, NULL} // end > }; > @@ -2524,7 +2524,7 @@ > */ > > static const char *_elua_ecore_timer_api = "ecore_timer"; > -static const struct luaL_reg _elua_ecore_timer_funcs [] = > +static const struct luaL_Reg _elua_ecore_timer_funcs [] = > { > {NULL, NULL} // end > }; > @@ -2550,7 +2550,7 @@ > > static const char *_elua_evas_edje_api = "evas_edje"; > static const char *_elua_evas_edje_parent = "evas_edje_parent"; > -static const struct luaL_reg _elua_evas_edje_funcs [] = > +static const struct luaL_Reg _elua_evas_edje_funcs [] = > { > {"file", _elua_edje_file}, // get or set edje file and group > > @@ -2649,7 +2649,7 @@ > > static const char *_elua_evas_image_api = "evas_image"; > static const char *_elua_evas_image_parent = "evas_image_parent"; > -static const struct luaL_reg _elua_evas_image_funcs [] = > +static const struct luaL_Reg _elua_evas_image_funcs [] = > { > {"fill", _elua_image_fill}, // get or set the fill parameters > {"filled", _elua_image_filled}, // get or set the filled state (overrides fill()) > @@ -2851,7 +2851,7 @@ > > static const char *_elua_evas_line_api = "evas_line"; > static const char *_elua_evas_line_parent = "evas_line_parent"; > -static const struct luaL_reg _elua_evas_line_funcs [] = > +static const struct luaL_Reg _elua_evas_line_funcs [] = > { > {"xy", _elua_line_xy}, // get or set line coords > > @@ -2933,7 +2933,7 @@ > static int _elua_map_zoom(lua_State *L); > > static const char *_elua_evas_map_api = "ewas_map"; > -static const struct luaL_reg _elua_evas_map_funcs [] = > +static const struct luaL_Reg _elua_evas_map_funcs [] = > { > {"alpha", _elua_map_alpha}, > // {"dup", _elua_map_dup}, // not sure of proper api for this. > @@ -3496,7 +3496,7 @@ > > static const char *_elua_evas_polygon_api = "evas_polygon"; > static const char *_elua_evas_polygon_parent = "evas_polygon_parent"; > -static const struct luaL_reg _elua_evas_polygon_funcs [] = > +static const struct luaL_Reg _elua_evas_polygon_funcs [] = > { > {"clear", _elua_polygon_clear}, // clear all polygon points > {"point", _elua_polygon_point}, // add a polygon point > @@ -3576,7 +3576,7 @@ > > static const char *_elua_evas_text_api = "evas_text"; > static const char *_elua_evas_text_parent = "evas_text_parent"; > -static const struct luaL_reg _elua_evas_text_funcs [] = > +static const struct luaL_Reg _elua_evas_text_funcs [] = > { > {"font", _elua_text_font}, // get or set text font > {"text", _elua_text_text}, // get or set text > @@ -3703,7 +3703,7 @@ > static int _elua_bogan_nilfunc(lua_State *L); > static int _elua_bogan_index(lua_State *L); > > -static const struct luaL_reg _elua_bogan_funcs [] = > +static const struct luaL_Reg _elua_bogan_funcs [] = > { > {"nilfunc", _elua_bogan_nilfunc}, // Just return a nil. > {"__index", _elua_bogan_index}, // Return the above func. > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Cedric BAIL |
From: Carsten H. (T. R. <ra...@ra...> - 2012-07-04 01:44:22
|
On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> said: i asked last night and he claims it works with 5.1 - we were using deprecated features that still were in 5.1 (deprecated earlier) and 5.2 killed them off entirely. > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua 5.1 ? As > far as I remember we avoided moving to 5.2 because they did break > their API/ABI. If this break 5.1, then revert ! > > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN > <no-...@en...> wrote: > > Log: > > unbork edje-lua on 5.2 > > > > Author: quaker > > Date: 2012-07-03 07:08:09 -0700 (Tue, 03 Jul 2012) > > New Revision: 73240 > > Trac: http://trac.enlightenment.org/e/changeset/73240 > > > > Modified: > > trunk/edje/src/lib/edje_lua2.c > > > > Modified: trunk/edje/src/lib/edje_lua2.c > > =================================================================== > > --- trunk/edje/src/lib/edje_lua2.c 2012-07-03 13:53:44 UTC (rev 73239) > > +++ trunk/edje/src/lib/edje_lua2.c 2012-07-03 14:08:09 UTC (rev 73240) > > @@ -180,7 +180,7 @@ > > > > static int _elua_obj_gc(lua_State *L); > > > > -static const struct luaL_reg _elua_edje_gc_funcs [] = > > +static const struct luaL_Reg _elua_edje_gc_funcs [] = > > { > > {"__gc", _elua_obj_gc}, // garbage collector func for edje objects > > > > @@ -635,7 +635,7 @@ > > //static int _elua_textblock(lua_State *L); /* XXX: disabled until there > > are enough textblock functions implemented to make it actually useful > > > > static const char *_elua_edje_api = "edje"; > > -static const struct luaL_reg _elua_edje_funcs [] = > > +static const struct luaL_Reg _elua_edje_funcs [] = > > { > > // add an echo too to make it more shelly > > {"echo", _elua_echo}, // test func - echo (i know we have > > print. test) @@ -1714,7 +1714,7 @@ > > static int _elua_obj_map_enable(lua_State *L); > > > > static const char *_elua_evas_api = "evas"; > > -static const struct luaL_reg _elua_evas_funcs [] = > > +static const struct luaL_Reg _elua_evas_funcs [] = > > { > > {"del", _elua_obj_del}, // generic del any object created > > for edje (evas objects, timers, animators, transitions... everything) > > > > @@ -2504,7 +2504,7 @@ > > holds a reference to an ecore animator object. > > */ > > static const char *_elua_ecore_animator_api = "ecore_animator"; > > -static const struct luaL_reg _elua_ecore_animator_funcs [] = > > +static const struct luaL_Reg _elua_ecore_animator_funcs [] = > > { > > {NULL, NULL} // end > > }; > > @@ -2524,7 +2524,7 @@ > > */ > > > > static const char *_elua_ecore_timer_api = "ecore_timer"; > > -static const struct luaL_reg _elua_ecore_timer_funcs [] = > > +static const struct luaL_Reg _elua_ecore_timer_funcs [] = > > { > > {NULL, NULL} // end > > }; > > @@ -2550,7 +2550,7 @@ > > > > static const char *_elua_evas_edje_api = "evas_edje"; > > static const char *_elua_evas_edje_parent = "evas_edje_parent"; > > -static const struct luaL_reg _elua_evas_edje_funcs [] = > > +static const struct luaL_Reg _elua_evas_edje_funcs [] = > > { > > {"file", _elua_edje_file}, // get or set edje file and group > > > > @@ -2649,7 +2649,7 @@ > > > > static const char *_elua_evas_image_api = "evas_image"; > > static const char *_elua_evas_image_parent = "evas_image_parent"; > > -static const struct luaL_reg _elua_evas_image_funcs [] = > > +static const struct luaL_Reg _elua_evas_image_funcs [] = > > { > > {"fill", _elua_image_fill}, // get or set the fill > > parameters {"filled", _elua_image_filled}, // get or set the filled > > state (overrides fill()) @@ -2851,7 +2851,7 @@ > > > > static const char *_elua_evas_line_api = "evas_line"; > > static const char *_elua_evas_line_parent = "evas_line_parent"; > > -static const struct luaL_reg _elua_evas_line_funcs [] = > > +static const struct luaL_Reg _elua_evas_line_funcs [] = > > { > > {"xy", _elua_line_xy}, // get or set line coords > > > > @@ -2933,7 +2933,7 @@ > > static int _elua_map_zoom(lua_State *L); > > > > static const char *_elua_evas_map_api = "ewas_map"; > > -static const struct luaL_reg _elua_evas_map_funcs [] = > > +static const struct luaL_Reg _elua_evas_map_funcs [] = > > { > > {"alpha", _elua_map_alpha}, > > // {"dup", _elua_map_dup}, // not sure of proper api for > > this. @@ -3496,7 +3496,7 @@ > > > > static const char *_elua_evas_polygon_api = "evas_polygon"; > > static const char *_elua_evas_polygon_parent = "evas_polygon_parent"; > > -static const struct luaL_reg _elua_evas_polygon_funcs [] = > > +static const struct luaL_Reg _elua_evas_polygon_funcs [] = > > { > > {"clear", _elua_polygon_clear}, // clear all polygon points > > {"point", _elua_polygon_point}, // add a polygon point > > @@ -3576,7 +3576,7 @@ > > > > static const char *_elua_evas_text_api = "evas_text"; > > static const char *_elua_evas_text_parent = "evas_text_parent"; > > -static const struct luaL_reg _elua_evas_text_funcs [] = > > +static const struct luaL_Reg _elua_evas_text_funcs [] = > > { > > {"font", _elua_text_font}, // get or set text font > > {"text", _elua_text_text}, // get or set text > > @@ -3703,7 +3703,7 @@ > > static int _elua_bogan_nilfunc(lua_State *L); > > static int _elua_bogan_index(lua_State *L); > > > > -static const struct luaL_reg _elua_bogan_funcs [] = > > +static const struct luaL_Reg _elua_bogan_funcs [] = > > { > > {"nilfunc", _elua_bogan_nilfunc}, // Just return a nil. > > {"__index", _elua_bogan_index}, // Return the above func. > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-svn mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |
From: David S. <on...@gm...> - 2012-07-04 02:11:56
Attachments:
signature.asc
|
On Wed, 4 Jul 2012 10:44:19 +0900 Carsten Haitzler (The Rasterman) <ra...@ra...> wrote: > On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> > said: > > i asked last night and he claims it works with 5.1 - we were using > deprecated features that still were in 5.1 (deprecated earlier) and > 5.2 killed them off entirely. > > > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua 5.1 ? As > > far as I remember we avoided moving to 5.2 because they did break > > their API/ABI. If this break 5.1, then revert ! > > > > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN > > <no-...@en...> wrote: > > > Log: > > > unbork edje-lua on 5.2 I was worried about that, but the Lua example still runs fine on 5.1, as does my app that actually uses it. Yes, we had a bit of a discussion long ago where we decided to NOT go to 5.2. If it helps with 5.2 and still works with 5.1, then it's all good. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. |
From: Vincent T. <vin...@gm...> - 2012-07-05 09:04:13
|
On Wed, Jul 4, 2012 at 4:11 AM, David Seikel <on...@gm...> wrote: > On Wed, 4 Jul 2012 10:44:19 +0900 Carsten Haitzler (The Rasterman) > <ra...@ra...> wrote: > >> On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> >> said: >> >> i asked last night and he claims it works with 5.1 - we were using >> deprecated features that still were in 5.1 (deprecated earlier) and >> 5.2 killed them off entirely. >> >> > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua 5.1 ? As >> > far as I remember we avoided moving to 5.2 because they did break >> > their API/ABI. If this break 5.1, then revert ! >> > >> > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN >> > <no-...@en...> wrote: >> > > Log: >> > > unbork edje-lua on 5.2 > > I was worried about that, but the Lua example still runs fine on 5.1, as > does my app that actually uses it. > > Yes, we had a bit of a discussion long ago where we decided to NOT go > to 5.2. If it helps with 5.2 and still works with 5.1, then it's all > good. > so http://trac.enlightenment.org/e/ticket/978 should be closed ? Vincent |
From: David S. <on...@gm...> - 2012-07-05 09:52:07
Attachments:
signature.asc
|
On Thu, 5 Jul 2012 11:04:02 +0200 Vincent Torri <vin...@gm...> wrote: > On Wed, Jul 4, 2012 at 4:11 AM, David Seikel <on...@gm...> > wrote: > > On Wed, 4 Jul 2012 10:44:19 +0900 Carsten Haitzler (The Rasterman) > > <ra...@ra...> wrote: > > > >> On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> > >> said: > >> > >> i asked last night and he claims it works with 5.1 - we were using > >> deprecated features that still were in 5.1 (deprecated earlier) and > >> 5.2 killed them off entirely. > >> > >> > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua > >> > 5.1 ? As far as I remember we avoided moving to 5.2 because they > >> > did break their API/ABI. If this break 5.1, then revert ! > >> > > >> > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN > >> > <no-...@en...> wrote: > >> > > Log: > >> > > unbork edje-lua on 5.2 > > > > I was worried about that, but the Lua example still runs fine on > > 5.1, as does my app that actually uses it. > > > > Yes, we had a bit of a discussion long ago where we decided to NOT > > go to 5.2. If it helps with 5.2 and still works with 5.1, then > > it's all good. > > > > so http://trac.enlightenment.org/e/ticket/978 should be closed ? I agree with Cedric's comment on that ticket. It might be worthwhile to rehash the previous discussion some time in the future, things change. Personally I'd like to go with Cedric's suggestion to include Lua directly in EFL, but to make it LuaJIT instead of stock Lua. To quote the author of LuaJIT - "As I've previously said, Lua 5.2 provides few tangible benefits. LuaJIT already includes the major new features, without breaking compatibility. Upgrading to be compatible with 5.2, just for the sake of a higher version number, is neither a priority nor a sensible move for most LuaJIT users." Going the LuaJIT route gives us a few benefits, two of the important ones are raw speed and much easier integration of C with Lua. http://luajit.org/ -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. |
From: Cedric B. <ced...@fr...> - 2012-07-05 10:32:17
|
On Thu, Jul 5, 2012 at 6:51 PM, David Seikel <on...@gm...> wrote: > On Thu, 5 Jul 2012 11:04:02 +0200 Vincent Torri > <vin...@gm...> wrote: >> On Wed, Jul 4, 2012 at 4:11 AM, David Seikel <on...@gm...> >> wrote: >> > On Wed, 4 Jul 2012 10:44:19 +0900 Carsten Haitzler (The Rasterman) >> > <ra...@ra...> wrote: >> > >> >> On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> >> >> said: >> >> >> >> i asked last night and he claims it works with 5.1 - we were using >> >> deprecated features that still were in 5.1 (deprecated earlier) and >> >> 5.2 killed them off entirely. >> >> >> >> > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua >> >> > 5.1 ? As far as I remember we avoided moving to 5.2 because they >> >> > did break their API/ABI. If this break 5.1, then revert ! >> >> > >> >> > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN >> >> > <no-...@en...> wrote: >> >> > > Log: >> >> > > unbork edje-lua on 5.2 >> > >> > I was worried about that, but the Lua example still runs fine on >> > 5.1, as does my app that actually uses it. >> > >> > Yes, we had a bit of a discussion long ago where we decided to NOT >> > go to 5.2. If it helps with 5.2 and still works with 5.1, then >> > it's all good. >> > >> >> so http://trac.enlightenment.org/e/ticket/978 should be closed ? > > I agree with Cedric's comment on that ticket. It might be worthwhile to > rehash the previous discussion some time in the future, things change. > > Personally I'd like to go with Cedric's suggestion to include Lua > directly in EFL, but to make it LuaJIT instead of stock Lua. To quote > the author of LuaJIT - > > "As I've previously said, Lua 5.2 provides few tangible benefits. > LuaJIT already includes the major new features, without breaking > compatibility. Upgrading to be compatible with 5.2, just for the > sake of a higher version number, is neither a priority nor a > sensible move for most LuaJIT users." > > Going the LuaJIT route gives us a few benefits, two of the important > ones are raw speed and much easier integration of C with Lua. I really like this idea, just wondering if LuaJIT as a fallback if they don't have a proper backend on that CPU. -- Cedric BAIL |
From: Vincent T. <vin...@gm...> - 2012-07-05 11:52:26
|
On Thu, Jul 5, 2012 at 11:51 AM, David Seikel <on...@gm...> wrote: > On Thu, 5 Jul 2012 11:04:02 +0200 Vincent Torri > <vin...@gm...> wrote: > >> On Wed, Jul 4, 2012 at 4:11 AM, David Seikel <on...@gm...> >> wrote: >> > On Wed, 4 Jul 2012 10:44:19 +0900 Carsten Haitzler (The Rasterman) >> > <ra...@ra...> wrote: >> > >> >> On Wed, 4 Jul 2012 09:58:30 +0900 Cedric BAIL <ced...@fr...> >> >> said: >> >> >> >> i asked last night and he claims it works with 5.1 - we were using >> >> deprecated features that still were in 5.1 (deprecated earlier) and >> >> 5.2 killed them off entirely. >> >> >> >> > ARE YOU SURE OF WHAT YOU DID ? Is it still working with lua >> >> > 5.1 ? As far as I remember we avoided moving to 5.2 because they >> >> > did break their API/ABI. If this break 5.1, then revert ! >> >> > >> >> > On Tue, Jul 3, 2012 at 11:08 PM, Enlightenment SVN >> >> > <no-...@en...> wrote: >> >> > > Log: >> >> > > unbork edje-lua on 5.2 >> > >> > I was worried about that, but the Lua example still runs fine on >> > 5.1, as does my app that actually uses it. >> > >> > Yes, we had a bit of a discussion long ago where we decided to NOT >> > go to 5.2. If it helps with 5.2 and still works with 5.1, then >> > it's all good. >> > >> >> so http://trac.enlightenment.org/e/ticket/978 should be closed ? > > I agree with Cedric's comment on that ticket. It might be worthwhile to > rehash the previous discussion some time in the future, things change. > > Personally I'd like to go with Cedric's suggestion to include Lua > directly in EFL, but to make it LuaJIT instead of stock Lua. To quote > the author of LuaJIT - I already does that with epdf/eyesight and mupdf. Vincent |