From: ChunEon P. <chu...@sa...> - 2010-12-02 04:20:22
|
Hi this is Hermet. The reason why i used the API name is any other APIs follow the naming rule. For example, elm_object_disabled_set, elm_gengrid_item_disabled_set elm_entry_context_menu_disabled_set elm_toobl_item_disabled_set .... Frackly, I dont prefer disabled_set. It makes people thinked one more. However, I just followed the naming rule. if the default is the enabled, then it provides disabled_set If this is my fault, OK I agree with you. Thanks. ------- Original Message ------- Sender : Dave Andreoli<da...@gu...> Date : 2010-12-02 08:53 (GMT+09:00) Title : Re: [E-devel] [Patch] elm_transit 2010/12/1 Gustavo Sverzut Barbieri : > On Wed, Dec 1, 2010 at 4:00 PM, Daniel Juyung Seo wrote: >> I agree with Helen. >> >> Even the event block is set by default >> and I understand why Hermet prefers elm_transit_event_block_disabled_set(), >> elm_transit_event_block_set(transit, EINA_TRUE) >> is less confusing than >> elm_transit_event_block_disabled_set(transit, EINA_TRUE). >> >> But I think BOTH are confusing. >> >> I suggest another solution for this. >> Why don't you use >> elm_transit_event_enabled_set(transit, EINA_TRUE) instead? >> Because event is blocked by default, >> someone who wants to use events needs to call >> elm_transit_event_enabled_set() API. > > +1, that seems the most reasonable api. indeed +1 davemds > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: bar...@gm... > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ---------------------------------------------------------------------------- -- > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ---------------------------------------------------------------------------- -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ enlightenment-devel mailing list enl...@li... https://lists.sourceforge.net/lists/listinfo/enlightenment-devel [cid:V0U...@na...] [SeenTimeChecker?do=d9ce704749a25c62756122855015f930f101de264366a50c6b754d17 d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] |
From: ChunEon P. <chu...@sa...> - 2010-12-02 04:35:44
|
Ah.. of course when i named this API, I remember there are no enabled_set maybe. The problem is that current SLP developers may use this APIs. So if it did not need to change, i just prefered keeping. Thanks. :) ------- Original Message ------- Sender : 박춘언<chu...@sa...> E3(사원)/사원/Mobile S/W Platform Lab(DMC연)/삼성전자 Date : 2010-12-02 13:19 (GMT+09:00) Title : Re: [E-devel] [Patch] elm_transit Hi this is Hermet. The reason why i used the API name is any other APIs follow the naming rule. For example, elm_object_disabled_set, elm_gengrid_item_disabled_set elm_entry_context_menu_disabled_set elm_toobl_item_disabled_set .... Frackly, I dont prefer disabled_set. It makes people thinked one more. However, I just followed the naming rule. if the default is the enabled, then it provides disabled_set If this is my fault, OK I agree with you. Thanks. ------- Original Message ------- Sender : Dave Andreoli Date : 2010-12-02 08:53 (GMT+09:00) Title : Re: [E-devel] [Patch] elm_transit 2010/12/1 Gustavo Sverzut Barbieri : > On Wed, Dec 1, 2010 at 4:00 PM, Daniel Juyung Seo wrote: >> I agree with Helen. >> >> Even the event block is set by default >> and I understand why Hermet prefers elm_transit_event_block_disabled_set(), >> elm_transit_event_block_set(transit, EINA_TRUE) >> is less confusing than >> elm_transit_event_block_disabled_set(transit, EINA_TRUE). >> >> But I think BOTH are confusing. >> >> I suggest another solution for this. >> Why don't you use >> elm_transit_event_enabled_set(transit, EINA_TRUE) instead? >> Because event is blocked by default, >> someone who wants to use events needs to call >> elm_transit_event_enabled_set() API. > > +1, that seems the most reasonable api. indeed +1 davemds > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: bar...@gm... > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ---------------------------------------------------------------------------- -- > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ---------------------------------------------------------------------------- -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ enlightenment-devel mailing list enl...@li... https://lists.sourceforge.net/lists/listinfo/enlightenment-devel [cid:V0U...@na...] [SeenTimeChecker?do=d9ce704749a25c62756122855015f930f101de264366a50c6b754d17 d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] [cid:XT4...@na...] [SeenTimeChecker?do=d9ce704749a25c621a7b3bbe209e285e9991b7b6d404ee9e6b754d17 d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] |
From: Carsten H. (T. R. <ra...@ra...> - 2010-12-04 02:11:21
|
On Thu, 02 Dec 2010 04:35:32 +0000 (GMT) ChunEon Park <chu...@sa...> said: hmm it is a bit confusing (trhe api) well.. ok - not confusing. simply... less obvious and instantly recognisable. it needs a little thought. we could have both api's and deprecate 1 for now and wait for people to move over and finally kill it off. that's my suggestion. > > Ah.. of course when i named this API, > > I remember there are no enabled_set maybe. > > > The problem is that current SLP developers may use this APIs. > > So if it did not need to change, i just prefered keeping. > > > Thanks. :) > > > ------- Original Message ------- > > Sender : 박춘언<chu...@sa...> E3(사원)/사원/Mobile S/W > Platform Lab(DMC연)/삼성전자 > > Date : 2010-12-02 13:19 (GMT+09:00) > > Title : Re: [E-devel] [Patch] elm_transit > > > Hi this is Hermet. > The reason why i used the API name is any other APIs follow the naming > rule. > For example, > elm_object_disabled_set, > elm_gengrid_item_disabled_set > elm_entry_context_menu_disabled_set > elm_toobl_item_disabled_set > .... > Frackly, I dont prefer disabled_set. > It makes people thinked one more. > However, I just followed the naming rule. > if the default is the enabled, then it provides disabled_set > If this is my fault, OK I agree with you. > Thanks. > ------- Original Message ------- > Sender : Dave Andreoli > Date : 2010-12-02 08:53 (GMT+09:00) > Title : Re: [E-devel] [Patch] elm_transit > 2010/12/1 Gustavo Sverzut Barbieri : > > On Wed, Dec 1, 2010 at 4:00 PM, Daniel Juyung Seo wrote: > >> I agree with Helen. > >> > >> Even the event block is set by default > >> and I understand why Hermet prefers > elm_transit_event_block_disabled_set(), > >> elm_transit_event_block_set(transit, EINA_TRUE) > >> is less confusing than > >> elm_transit_event_block_disabled_set(transit, EINA_TRUE). > >> > >> But I think BOTH are confusing. > >> > >> I suggest another solution for this. > >> Why don't you use > >> elm_transit_event_enabled_set(transit, EINA_TRUE) instead? > >> Because event is blocked by default, > >> someone who wants to use events needs to call > >> elm_transit_event_enabled_set() API. > > > > +1, that seems the most reasonable api. > indeed +1 > davemds > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: bar...@gm... > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > > > > ---------------------------------------------------------------------------- > -- > > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > > Tap into the largest installed PC base & get more eyes on your game by > > optimizing for Intel(R) Graphics Technology. Get started today with > > the Intel(R) Software Partner Program. Five $500 cash prizes are up > > for > grabs. > > http://p.sf.net/sfu/intelisp-dev2dev > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ---------------------------------------------------------------------------- > -- > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for > grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > [cid:V0U...@na...] > > [SeenTimeChecker? > do=d9ce704749a25c62756122855015f930f101de264366a50c6b754d17 > > d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 > b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] > > > [cid:XT4...@na...] > > [SeenTimeChecker? > do=d9ce704749a25c621a7b3bbe209e285e9991b7b6d404ee9e6b754d17 > d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 > b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |
From: ChunEon P. <chu...@sa...> - 2010-12-06 14:26:05
|
oh yes, i will try it soon. thx. ------- Original Message ------- Sender : Carsten Haitzler<ra...@ra...> Date : 2010-12-04 11:39 (GMT+09:00) Title : Re: [E-devel] [Patch] elm_transit On Thu, 2 Dec 2010 00:53:22 +0100 Dave Andreoli said: > 2010/12/1 Gustavo Sverzut Barbieri : > > On Wed, Dec 1, 2010 at 4:00 PM, Daniel Juyung Seo > > wrote: > >> I agree with Helen. > >> > >> Even the event block is set by default > >> and I understand why Hermet prefers elm_transit_event_block_disabled_set(), > >> elm_transit_event_block_set(transit, EINA_TRUE) > >> is less confusing than > >> elm_transit_event_block_disabled_set(transit, EINA_TRUE). > >> > >> But I think BOTH are confusing. > >> > >> I suggest another solution for this. > >> Why don't you use > >> elm_transit_event_enabled_set(transit, EINA_TRUE) instead? > >> Because event is blocked by default, > >> someone who wants to use events needs to call > >> elm_transit_event_enabled_set() API. > > > > +1, that seems the most reasonable api. > > indeed +1 > davemds hermet - why don't you provide a patch that provides the new suggested api above, but only deprecates the old (still keeping it). EINA_DEPRECATED in front of the EAPI's to mark it. nothing wil break right now, we have new api thats better for people to use and people using the old api have a chance to move over without a break for a period of time. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... ---------------------------------------------------------------------------- -- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d _______________________________________________ enlightenment-devel mailing list enl...@li... https://lists.sourceforge.net/lists/listinfo/enlightenment-devel [cid:4XE...@na...] [SeenTimeChecker?do=d9ce704749a25c6224487052f128d9a8b45af81d54503f866b754d17 d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] |
From: ChunEon P. <chu...@sa...> - 2011-01-07 12:00:01
Attachments:
elm_transit.txt
|
Really sorry. Attached file is something wrong. Here it again. Thanks. -----Original Message----- From: ChunEon Park [mailto:chu...@sa...] Sent: Friday, January 07, 2011 8:48 PM To: 'enl...@li...' Subject: [PATCH] elm_transit Hi, Here is a very small patch for elm_transit Removed an unnecessary parameter. Please consider then apply it. Thanks. |
From: Carsten H. (T. R. <ra...@ra...> - 2011-01-10 05:35:18
|
On Fri, 07 Jan 2011 20:59:15 +0900 ChunEon Park <chu...@sa...> said: in svn! :) > Really sorry. > > Attached file is something wrong. > > Here it again. > > Thanks. > > -----Original Message----- > From: ChunEon Park [mailto:chu...@sa...] > Sent: Friday, January 07, 2011 8:48 PM > To: 'enl...@li...' > Subject: [PATCH] elm_transit > > Hi, > > Here is a very small patch for elm_transit > > Removed an unnecessary parameter. > > Please consider then apply it. > > Thanks. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |