From: Naruto T. <tna...@yb...> - 2008-10-21 17:20:48
Attachments:
eina.diff
|
Hi all, eina build failed on FreeBSD, so I made FreeBSD patch. Best regards. -=-=-=-=-=-=-=-=- Naruto TAKAHASHI tna...@yb... |
From: Naruto T. <tna...@yb...> - 2008-10-21 17:30:02
Attachments:
eina.diff
|
Hi all, eina build failed on FreeBSD, so I made FreeBSD patch. Best regards. -=-=-=-=-=-=-=-=- Naruto TAKAHASHI tna...@yb... |
From: Ravenlock <rav...@ra...> - 2008-10-25 18:45:14
Attachments:
signature.asc
|
On 10/21/2008 12:11, Naruto TAKAHASHI wrote: > Hi all, > > eina build failed on FreeBSD, so I made FreeBSD patch. In SVN! :) > > Best regards. > -=-=-=-=-=-=-=-=- > Naruto TAKAHASHI > tna...@yb... > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Regards, Ravenlock |
From: Joerg S. <jo...@br...> - 2008-10-26 12:59:22
|
On Sat, Oct 25, 2008 at 01:18:25PM -0500, Ravenlock wrote: > > eina build failed on FreeBSD, so I made FreeBSD patch. > > In SVN! :) Please invert that patch. CLOCK_PROF is mostly present, the alternative not. E.g. linux clock if present, otherwise CLOCK_PROF or CLOCK_REALTIME as last line of fallback. Joerg |
From: Naruto T. <tna...@yb...> - 2008-10-27 14:34:35
Attachments:
eina.diff
|
From: Ravenlock <rav...@ra...> Subject: Re: [E-devel] [PATCH] tiny patch eina for FreeBSD Date: Mon, 27 Oct 2008 08:56:55 -0500 > On 10/26/2008 07:56, Joerg Sonnenberger wrote: > > On Sat, Oct 25, 2008 at 01:18:25PM -0500, Ravenlock wrote: > >>> eina build failed on FreeBSD, so I made FreeBSD patch. > >> In SVN! :) > > > > Please invert that patch. CLOCK_PROF is mostly present, the alternative > > not. E.g. linux clock if present, otherwise CLOCK_PROF or CLOCK_REALTIME > > as last line of fallback. > > You prefer: > > #ifdef __linux__ > CLOCK_PROCESS_CPUTIME_ID > #else > CLOCK_PROF -or- CLOCK_REALTIME > #endif > > because CLOCK_PROCESS_CPUTIME_ID is not implemented on *many* platforms, > but known to linux? > I suggest: #if defined(CLOCK_PROCESS_CPUTIME_ID) && defined(__linux__) # define CLOCK CLOCK_PROCESS_CPUTIME_ID #elif defined(CLOCK_PROF) && defined(__FreeBSD__) # define CLOCK CLOCK_PROF #else # define CLOCK CLOCK_REALTIME #endif return clock_gettime(CLOCK, tp); #undef CLOCK Best regards. -=-=-=-=-=-=-=-=- Naruto TAKAHASHI tna...@yb... > > > > Joerg > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > enlightenment-devel mailing list > > enl...@li... > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > -- > Regards, > Ravenlock > > |
From: Joerg S. <jo...@br...> - 2008-10-27 15:56:31
|
On Mon, Oct 27, 2008 at 11:31:19PM +0900, Naruto TAKAHASHI wrote: > #if defined(CLOCK_PROCESS_CPUTIME_ID) && defined(__linux__) > # define CLOCK CLOCK_PROCESS_CPUTIME_ID > #elif defined(CLOCK_PROF) && defined(__FreeBSD__) > # define CLOCK CLOCK_PROF > #else > # define CLOCK CLOCK_REALTIME > #endif > return clock_gettime(CLOCK, tp); E.g. CLOCK_PROF exists on the other BSDs as well. Please, try to keep OS specific ifdefs to the minimal amount. Joerg |
From: Sebastian D. <seb...@ta...> - 2008-10-27 16:05:56
|
Joerg Sonnenberger wrote: > On Mon, Oct 27, 2008 at 11:31:19PM +0900, Naruto TAKAHASHI wrote: >> #if defined(CLOCK_PROCESS_CPUTIME_ID) && defined(__linux__) >> # define CLOCK CLOCK_PROCESS_CPUTIME_ID >> #elif defined(CLOCK_PROF) && defined(__FreeBSD__) >> # define CLOCK CLOCK_PROF >> #else >> # define CLOCK CLOCK_REALTIME >> #endif >> return clock_gettime(CLOCK, tp); > > E.g. CLOCK_PROF exists on the other BSDs as well. Please, try to keep OS > specific ifdefs to the minimal amount. Current code is (without OS specific ifdefs): #if defined(CLOCK_PROCESS_CPUTIME_ID) return clock_gettime(CLOCK_PROCESS_CPUTIME_ID, tp); #elif defined(CLOCK_PROF) return clock_gettime(CLOCK_PROF, tp); #else return clock_gettime(CLOCK_REALTIME, tp); #endif Sebastian |
From: Ravenlock <rav...@ra...> - 2008-10-27 13:57:03
Attachments:
signature.asc
|
On 10/26/2008 07:56, Joerg Sonnenberger wrote: > On Sat, Oct 25, 2008 at 01:18:25PM -0500, Ravenlock wrote: >>> eina build failed on FreeBSD, so I made FreeBSD patch. >> In SVN! :) > > Please invert that patch. CLOCK_PROF is mostly present, the alternative > not. E.g. linux clock if present, otherwise CLOCK_PROF or CLOCK_REALTIME > as last line of fallback. You prefer: #ifdef __linux__ CLOCK_PROCESS_CPUTIME_ID #else CLOCK_PROF -or- CLOCK_REALTIME #endif because CLOCK_PROCESS_CPUTIME_ID is not implemented on *many* platforms, but known to linux? > > Joerg > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Regards, Ravenlock |
From: Joerg S. <jo...@br...> - 2008-10-27 15:42:55
|
On Mon, Oct 27, 2008 at 08:56:55AM -0500, Ravenlock wrote: > You prefer: > > #ifdef __linux__ > CLOCK_PROCESS_CPUTIME_ID > #else > CLOCK_PROF -or- CLOCK_REALTIME > #endif > > because CLOCK_PROCESS_CPUTIME_ID is not implemented on *many* platforms, > but known to linux? Either that or even #ifdef CLOCK_PROCESS_CPUTIME_ID CLOCK_PROCESS_CPUTIME_ID #elif CLOCK_PROF CLOCK_PROF #else CLOCK_REALTIME #endif Joerg |