Menu

#32 issues with test_ss in lib/ss

closed-fixed
nobody
None
5
2008-01-01
2007-12-09
No

the new test_ss script has a few issues:
- unnecessary depend on $(LIBEXT2FS)
- tries to execute `test_ss` in $PATH
- test_ss lacks RPATH tags to local libs

attached path addresses the first two issues. the third issue could be addressed by doing:
LD_LIBRARY_PATH="$(top_builddir)/libs:${LD_LIBRARY_PATH}"
before executing test_ss ...

Discussion

  • Mike Frysinger

    Mike Frysinger - 2007-12-09

    ss-1.40.3-check.patch

     
  • Theodore Ts'o

    Theodore Ts'o - 2008-01-01
    • status: open --> closed-fixed
     
  • Mike Frysinger

    Mike Frysinger - 2008-01-01

    Logged In: YES
    user_id=114429
    Originator: YES

    while points (2) and (3) were resolved, (1) was not ... test_ss still depends on $(LIBEXT2FS) when it doesnt actually need/use the library

     
  • Mike Frysinger

    Mike Frysinger - 2008-01-01
    • status: closed-fixed --> open
     
  • Theodore Ts'o

    Theodore Ts'o - 2008-01-01

    Logged In: YES
    user_id=628
    Originator: NO

    Point (1) is fixed in the git repository after the 1.40.4 release. I fixed the bug in response to an e-mail comment (sorry, sourceforge's tracker is a bit unwieldy, so I sometimes fall behind dealing with bugs sent there, although I do get to them), and when I fixed it I didn't notice point (1). When I started going through the sourceforge tracker to close already fixed bugs, I noted point (1), and committed a fix, although it didn't make it into 1.40.4.

    Thanks!!

     
  • Theodore Ts'o

    Theodore Ts'o - 2008-01-01
    • status: open --> closed-fixed
     
  • Mike Frysinger

    Mike Frysinger - 2008-01-01

    Logged In: YES
    user_id=114429
    Originator: YES

    yeah, sf tracker does leave something to be desired

    if it's fixed, i'm happy ... i did only check 1.40.4 rather than git

    thanks !