Menu

#3 newline in body fix, header folding fix

open
nobody
None
5
2005-07-06
2005-07-06
Anonymous
No

Hello!

Dumbster is GREAT!

The patches were made for Dumbster 1.6.

The first patch adds a testcase which sends a mail
having newline in
the middle of the body. It fails. Name of the patch is
'patch_newline_test'.

The second patch fixes the problem by modifying
SmtpRequest.createRequest() and remove final linefeed at
SmtpMessage.store(). All the testcases are succeds.
Name of the patch is
'patch_newline_res'.

The third patch adds a testcase which sends a mail
having its header
'folded'. For details of it see rfc822 section 3.1.1.
It fails. Name of
the patch is 'patch_folding_test'.

The fourth patch fixes the problem by introducing a
new FOLD action,
and FOLD state. In SmtpMessage it uses a LinkedList
instead of the
hashMap for the order of the header lines must be
preserved (when
unfolding it appends folded line content to the *last*
header line). The
headersMap constructed from the list at the end of
processing.

Note that the second patch contains the first patch
as well, the third
patch contains the first and the second and so on.

Regards, Peter RISKO

Discussion


Log in to post a comment.