From: <th...@tu...> - 2006-12-19 22:57:03
|
Hi, Does anbody know why drm is using vmalloc_32 instead of vmalloc when allocating SHM maps? /Thomas |
From: Dave A. <ai...@li...> - 2006-12-19 23:03:09
|
> > Does anbody know why drm is using vmalloc_32 instead of vmalloc when > allocating SHM maps? I may be wrong but maybe for mixed 64/32-bit kernel/userspace systems, did it ever use vmalloc? Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG |
From: <th...@tu...> - 2006-12-19 23:11:19
|
Dave Airlie wrote: >>Does anbody know why drm is using vmalloc_32 instead of vmalloc when >>allocating SHM maps? >> >> > >I may be wrong but maybe for mixed 64/32-bit kernel/userspace systems, did >it ever use vmalloc? > > > Don't know really, but since drm AFAICT never cares about the physical address of the underlying pages, vmalloc should probably do just fine, or even better vmalloc_user on newer kernels, => we could skip the memset() i just added. /Thomas >Dave. > > > |
From: Dave A. <ai...@li...> - 2006-12-19 23:21:13
|
>> >> > Don't know really, but since drm AFAICT never cares about the physical > address of the > underlying pages, vmalloc should probably do just fine, or even better > vmalloc_user on newer kernels, > => we could skip the memset() i just added. I'ts been there for ever.... http://gitweb.freedesktop.org/?p=mesa/drm.git;a=commitdiff;h=74e19a40187ac3b5907922e5dc01418135a5794b was the result of my digging... so it may be worth changing it in git and see what happens.. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG |
From: <kr...@bi...> - 2006-12-23 19:00:57
|
T24gMTIvMTkvMDYsIFRob21hcyBIZWxsc3Ryw7ZtIDx0aG9tYXNAdHVuZ3N0ZW5ncmFwaGljcy5j b20+IHdyb3RlOgo+IERhdmUgQWlybGllIHdyb3RlOgo+Cj4gPj5Eb2VzIGFuYm9keSBrbm93IHdo eSBkcm0gaXMgdXNpbmcgdm1hbGxvY18zMiBpbnN0ZWFkIG9mIHZtYWxsb2Mgd2hlbgo+ID4+YWxs b2NhdGluZyBTSE0gbWFwcz8KPiA+Cj4gPkkgbWF5IGJlIHdyb25nIGJ1dCBtYXliZSBmb3IgbWl4 ZWQgNjQvMzItYml0IGtlcm5lbC91c2Vyc3BhY2Ugc3lzdGVtcywgZGlkCj4gPml0IGV2ZXIgdXNl IHZtYWxsb2M/Cj4gPgo+IERvbid0IGtub3cgcmVhbGx5LCBidXQgc2luY2UgZHJtIEFGQUlDVCBu ZXZlciBjYXJlcyBhYm91dCB0aGUgcGh5c2ljYWwKPiBhZGRyZXNzIG9mIHRoZQo+IHVuZGVybHlp bmcgcGFnZXMsIHZtYWxsb2Mgc2hvdWxkIHByb2JhYmx5IGRvIGp1c3QgZmluZSwgb3IgZXZlbiBi ZXR0ZXIKPiB2bWFsbG9jX3VzZXIgb24gbmV3ZXIga2VybmVscywKPiA9PiB3ZSBjb3VsZCBza2lw IHRoZSBtZW1zZXQoKSBpIGp1c3QgYWRkZWQuCgpBRkFJSywgdm1hbGxvY18zMiBwdXQgdGhlIG1l bW9yeSBpbiB0aGUgbG93ZXIgNGdiLCBzbyBpdCdzIGFjY2Vzc2libGUKYnkgcGVyaXBoZXJhbHMg dGhhdCBvbmx5IHN1cHBvcnQgMzItYml0IERNQS4gIElmIHRoYXQncyBub3QgYW4gaXNzdWUsCnRo ZXJlJ3Mgbm8gbmVlZCB0byB1c2UgdGhlIF8zMiB2ZXJzaW9uLgoKS3Jpc3RpYW4K |
From: <th...@tu...> - 2006-12-27 10:42:14
|
Kristian H=C3=B8gsberg wrote: >On 12/19/06, Thomas Hellstr=C3=B6m <th...@tu...> wrote: > =20 > >>Dave Airlie wrote: >> >> =20 >> >>>>Does anbody know why drm is using vmalloc_32 instead of vmalloc when >>>>allocating SHM maps? >>>> =20 >>>> >>>I may be wrong but maybe for mixed 64/32-bit kernel/userspace systems,= did >>>it ever use vmalloc? >>> >>> =20 >>> >>Don't know really, but since drm AFAICT never cares about the physical >>address of the >>underlying pages, vmalloc should probably do just fine, or even better >>vmalloc_user on newer kernels, >>=3D> we could skip the memset() i just added. >> =20 >> > >AFAIK, vmalloc_32 put the memory in the lower 4gb, so it's accessible >by peripherals that only support 32-bit DMA. If that's not an issue, >there's no need to use the _32 version. > >Kristian > =20 > Thanks, Kristian. I've already changed to vmalloc_user in git. It's for SAREAs only, and=20 they will hopefully never get submitted to the hardware. /Thomas >------------------------------------------------------------------------= - >Take Surveys. Earn Cash. Influence the Future of IT >Join SourceForge.net's Techsay panel and you'll get the chance to share = your >opinions on IT & business topics through brief surveys - and earn cash >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D= DEVDEV >-- >_______________________________________________ >Dri-devel mailing list >Dri...@li... >https://lists.sourceforge.net/lists/listinfo/dri-devel > =20 > |