From: <bug...@fr...> - 2005-08-28 14:07:45
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 Summary: via_dri.h out of sync with DDX driver. Product: Mesa Version: CVS Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Drivers/DRI/Unichrome AssignedTo: dri...@li... ReportedBy: li...@sk... CC: li...@sk... A recent fix to the DDX in Xorg HEAD broke dri. via_dri.h, shared by both the DDX and the DRI, have historically not been kept in sync. via_dri.h will now get a comment telling that this file should be kept synced at all times. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-28 14:10:36
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 ------- Additional Comments From li...@sk... 2005-08-28 07:10 ------- Created an attachment (id=3075) --> (https://bugs.freedesktop.org/attachment.cgi?id=3075&action=view) DRI: Sync via_dri.h Was diffed against X.org HEAD. Apply to Mesa/src/mesa/drivers/dri/unichrome/ directly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-28 14:12:14
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 ------- Additional Comments From li...@sk... 2005-08-28 07:12 ------- Created an attachment (id=3076) --> (https://bugs.freedesktop.org/attachment.cgi?id=3076&action=view) DDX: make via_dri.h more acceptable for DRI inclusion. diffed against current Xorg HEAD. Apply locally. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-28 14:14:11
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 ------- Additional Comments From li...@sk... 2005-08-28 07:14 ------- Created an attachment (id=3077) --> (https://bugs.freedesktop.org/attachment.cgi?id=3077&action=view) DRI: fix 2 issue with the unichrome DRI driver. - via_screen.c: attempts to use a variable after it getting freed. - via_screen.c: passed wrong size to drmUnMap. - via_texcombine.c: fix dual const warning. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-30 19:46:58
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 al...@fa... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From al...@fa... 2005-08-30 12:46 ------- Thanks Luc. Committed. I've changed a few other things to ease building in solo and X builds too. Let me know if something doesn't work correctly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-31 14:46:27
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 li...@sk... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From li...@sk... 2005-08-31 07:46 ------- Fallout from previous commits: grep -n "viaScreen->reg" via_context.c:564: vmesa->regMMIOBase = (GLuint *)((GLuint)viaScreen->reg); via_context.c:565: vmesa->pnGEMode = (GLuint *)((GLuint)viaScreen->reg + 0x4); via_context.c:566: vmesa->regEngineStatus = (GLuint *)((GLuint)viaScreen->reg + 0x400); via_context.c:567: vmesa->regTranSet = (GLuint *)((GLuint)viaScreen->reg + 0x43C); via_context.c:568: vmesa->regTranSpace = (GLuint *)((GLuint)viaScreen->reg + 0x440); via_screen.c:166: drmUnmap(viaScreen->reg, gDRIPriv->regs.size); via_screen.c:197: drmUnmap(viaScreen->reg, gDRIPriv->regs.size); viaScreen->reg is never assigned anymore. I'm not certain why the drmAddress map change was necessary, but it will have broken something, even though i'm seeing no adverse effects in running glxgears. But then, i didn't see anything with Bool as char either, amazingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-08-31 15:20:49
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 al...@fa... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED ------- Additional Comments From al...@fa... 2005-08-31 08:20 ------- Sorry, that was an change in my local tree that made it into the Mesa 6.4 branch, but it never got to the Mesa trunk code. I've backed that out. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 18:13:28
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 li...@sk... changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3075 is|0 |1 obsolete| | Attachment #3076 is|0 |1 obsolete| | Attachment #3077 is|0 |1 obsolete| | ------- Additional Comments From li...@sk... 2005-10-23 11:13 ------- Created an attachment (id=3604) --> (https://bugs.freedesktop.org/attachment.cgi?id=3604&action=view) Resync with DDX and fix DDX versioning. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 18:12:16
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 li...@sk... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From li...@sk... 2005-10-23 11:12 ------- Resync with DDX via_dri.h, and properly updating DDX version. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 19:10:28
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 uni...@sh... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED ------- Additional Comments From uni...@sh... 2005-10-23 12:10 ------- The via Xorg DDX version is still 4.1.31, and given the proximity of the Xorg 6.9/7.0 release, I dont't expect that to change? Your proposed minor version bump is incompatible with that, and Mesa will return an error when started with the Xorg DDX. I suggest we keep the Mesa versions in sync with whatever is currently in Xorg CVS, which means that as soon as the 4.2 bump is commited to Xorg, The Mesa trunk can be updated. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 21:52:07
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 ------- Additional Comments From li...@sk... 2005-10-23 14:52 ------- Wake up and smell the coffee. http://cvs.freedesktop.org/xorg/xc/lib/GL/mesa/drivers/dri/unichrome/Imakefile.inc?rev=1.5&view=log http://cvs.freedesktop.org/xorg/xc/programs/Xserver/hw/xfree86/drivers/via/via_dri.c?rev=1.20&view=log http://cvs.freedesktop.org/xorg/xc/programs/Xserver/hw/xfree86/drivers/via/via_dri.h?rev=1.11&view=log The version bump should've happened when the first commits from this bug were made. It should've happened when Egbert strayed over via_dri.h and fixed it. But there was nothing there to warn him. The mesa side and the DDX side were grossly out of sync then. It just hadn't been turned into a problem yet. And it's not as if this version has anything to do with the actual DDX version. It is only concerned about DRI DDX interaction. If you don't succeed in separating this, you'll end up changing versions across the whole range of drivers all the time. What you're saying is; "Don't update the version as this will break things, which broke because the version wasn't properly updated". -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 22:09:38
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 anholt@FreeBSD.org changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major ------- Additional Comments From anholt@FreeBSD.org 2005-10-23 15:09 ------- If a field was removed from the ddx struct, the major version of that interface will need to be bumped so old released versions of the client-side driver will fail cleanly. This needs to get fixed quickly since Mesa's about to be released and the newly-released Mesa driver needs to be expecting the bumped major version. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 22:32:30
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 li...@sk... changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal ------- Additional Comments From li...@sk... 2005-10-23 15:32 ------- Then, in server/via_dri.h MAJOR should be set 5, MINOR should be set 0. And via_dri.h in the ddx should be altered to match. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-23 22:37:38
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 li...@sk... changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2005-10-24 07:30:18
|
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4277 uni...@sh... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From uni...@sh... 2005-10-24 00:30 ------- Hi. OK, sorry, I missed that. I've updated Mesa-6.4 branch AND Xorg DDX versions to 5.0.0. Mesa trunk will follow later hopefully today. Xorg Mesa is not updated due to Xorg policy, http://xorg.freedesktop.org/wiki/CvsPolicy but I guess mesa 6.4 will soon be imported. I'm closing this. Please reopen if there are remaining problems. /Thomas -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |