From: Charl P. B. <c.p...@it...> - 2002-12-10 09:31:29
|
Dear list, In spite of some issues with binary snapshots, the DRI resume patches seem to work well. They have been available and in use on several different kinds of laptops for a few months now. What are the chances of this patch being accepted into the DRI CVS repository? How should I go about getting these small changes off my hands and eventually into XFree86? Thanks, Charl -- charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/ |
From: Keith W. <ke...@tu...> - 2002-12-10 10:52:13
|
Charl P. Botha wrote: > Dear list, > > In spite of some issues with binary snapshots, the DRI resume patches > seem to work well. They have been available and in use on several > different kinds of laptops for a few months now. > > What are the chances of this patch being accepted into the DRI CVS > repository? How should I go about getting these small changes off my > hands and eventually into XFree86? As I recall the X people on this list had some specific issues with the patches (David? Alan?) Resolving these would be the first step. Or am I lagging behind actual events? Keith |
From: Alan H. <al...@fa...> - 2002-12-10 12:21:25
|
On Tue, Dec 10, 2002 at 10:51:20AM +0000, Keith Whitwell wrote: > Charl P. Botha wrote: > >Dear list, > > > >In spite of some issues with binary snapshots, the DRI resume patches > >seem to work well. They have been available and in use on several > >different kinds of laptops for a few months now. > > > >What are the chances of this patch being accepted into the DRI CVS > >repository? How should I go about getting these small changes off my > >hands and eventually into XFree86? > > As I recall the X people on this list had some specific issues with the > patches (David? Alan?) Ah, just found a link. Looks o.k. to me now, maybe it wasn't this clean in previous attempts. Alan. |
From: Alan H. <al...@fa...> - 2002-12-10 12:41:43
|
On Tue, Dec 10, 2002 at 12:17:05PM +0000, Alan Hourihane wrote: > On Tue, Dec 10, 2002 at 10:51:20AM +0000, Keith Whitwell wrote: > > Charl P. Botha wrote: > > >Dear list, > > > > > >In spite of some issues with binary snapshots, the DRI resume patches > > >seem to work well. They have been available and in use on several > > >different kinds of laptops for a few months now. > > > > > >What are the chances of this patch being accepted into the DRI CVS > > >repository? How should I go about getting these small changes off my > > >hands and eventually into XFree86? > > > > As I recall the X people on this list had some specific issues with the > > patches (David? Alan?) > > Ah, just found a link. > > Looks o.k. to me now, maybe it wasn't this clean in previous attempts. One thing though. It doesn't look like it's hooked to any APM events. It's just run generically everytime on ModeInit. What happens when you VT switch - does it handle them cases too ? Alan. |
From: Charl P. B. <c.p...@it...> - 2002-12-10 12:46:25
|
On Tue, 2002-12-10 at 13:36, Alan Hourihane wrote: > One thing though. It doesn't look like it's hooked to any APM events. > > It's just run generically everytime on ModeInit. What happens when you > VT switch - does it handle them cases too ? At the moment it's called from RADEONEnterVT() in radeon_driver.c - so the code is called after every VT switch. During normal operation this doesn't cause any problems as it's idempotent. I would prefer hooking it more specifically to a power event... however, last time I checked the infrastructure for non-APM power events didn't seem to be ready. Many people are using this on ACPI-only laptops with swsusp for software suspension. Thanks, Charl -- charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/ |
From: Michel <mi...@da...> - 2002-12-10 15:07:59
|
On Die, 2002-12-10 at 13:45, Charl P. Botha wrote: > On Tue, 2002-12-10 at 13:36, Alan Hourihane wrote: > > One thing though. It doesn't look like it's hooked to any APM events. > >=20 > > It's just run generically everytime on ModeInit. What happens when you > > VT switch - does it handle them cases too ? >=20 > At the moment it's called from RADEONEnterVT() in radeon_driver.c - so > the code is called after every VT switch. During normal operation this > doesn't cause any problems as it's idempotent. I would prefer hooking > it more specifically to a power event... however, last time I checked > the infrastructure for non-APM power events didn't seem to be ready. Which likely won't change all by itself. ;) Anyway, I think the power management code basically emulates a VT switch for suspend/resume, so doing it in EnterVT() makes sense. --=20 Earthling Michel D=E4nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast |
From: David D. <dawes@XFree86.Org> - 2002-12-11 02:09:53
|
On Tue, Dec 10, 2002 at 01:45:09PM +0100, Charl P. Botha wrote: >On Tue, 2002-12-10 at 13:36, Alan Hourihane wrote: >> One thing though. It doesn't look like it's hooked to any APM events. >> >> It's just run generically everytime on ModeInit. What happens when you >> VT switch - does it handle them cases too ? > >At the moment it's called from RADEONEnterVT() in radeon_driver.c - so >the code is called after every VT switch. During normal operation this >doesn't cause any problems as it's idempotent. I would prefer hooking >it more specifically to a power event... however, last time I checked >the infrastructure for non-APM power events didn't seem to be ready. >Many people are using this on ACPI-only laptops with swsusp for software >suspension. If you're restoring HW state required for the correct operation of the driver, and especially if it's state that something else driving the video card might change while the X server doesn't have control over it, then it should be done from EnterVT(). As a general rule, any HW state that's set in ScreenInit() should also be set in EnterVT(). By default, XFree86 handles APM events via EnterVT/LeaveVT. It's possible for a driver to provide a separate function to handle PM events, but in most cases it shouldn't be needed. I just had another look at your patch, and I didn't see any obvious problem with the way it's structured. Send it to fi...@xf..., and Kevin Martin can review it. David -- David Dawes Release Engineer/Architect The XFree86 Project www.XFree86.org/~dawes |
From: Jens O. <je...@tu...> - 2002-12-10 15:09:13
|
Keith Whitwell wrote: > Charl P. Botha wrote: > >> Dear list, >> >> In spite of some issues with binary snapshots, the DRI resume patches >> seem to work well. They have been available and in use on several >> different kinds of laptops for a few months now. >> >> What are the chances of this patch being accepted into the DRI CVS >> repository? How should I go about getting these small changes off my >> hands and eventually into XFree86? > > > As I recall the X people on this list had some specific issues with the > patches (David? Alan?) > > Resolving these would be the first step. Or am I lagging behind actual > events? I have no concerns about the implications on the DRI with Charl's approach. He's kept everything in the driver at the mode init level, which I think is good. I'll defer any review of the actual Radeon specifics to the Radeon maintainers. -- /\ Jens Owen / \/\ _ je...@tu... / \ \ \ Steamboat Springs, Colorado |
From: Alan H. <al...@fa...> - 2002-12-10 12:17:33
|
On Tue, Dec 10, 2002 at 10:51:20AM +0000, Keith Whitwell wrote: > Charl P. Botha wrote: > >Dear list, > > > >In spite of some issues with binary snapshots, the DRI resume patches > >seem to work well. They have been available and in use on several > >different kinds of laptops for a few months now. > > > >What are the chances of this patch being accepted into the DRI CVS > >repository? How should I go about getting these small changes off my > >hands and eventually into XFree86? > > As I recall the X people on this list had some specific issues with the > patches (David? Alan?) I haven't looked at it in a while. Is there a link to it ? Alan. |
From: Charl P. B. <c.p...@it...> - 2002-12-10 12:20:32
|
On Tue, 2002-12-10 at 13:13, Alan Hourihane wrote: > I haven't looked at it in a while. Is there a link to it ? http://cpbotha.net/files/dri_resume/xfree86-dri-resume-v6.patch applies cleanly to current DRI CVS. http://cpbotha.net/dri_resume.html has some miscellaneous information. Thanks, Charl -- charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/ |
From: Ian R. <id...@us...> - 2002-12-10 20:54:28
|
On Tue, Dec 10, 2002 at 10:31:08AM +0100, Charl P. Botha wrote: > Dear list, > > In spite of some issues with binary snapshots, the DRI resume patches > seem to work well. They have been available and in use on several > different kinds of laptops for a few months now. > > What are the chances of this patch being accepted into the DRI CVS > repository? How should I go about getting these small changes off my > hands and eventually into XFree86? My memory is a little bit fuzzy on this. Did this patch also allow users to change their DRM module and radeon_dri.so file while vt switched? That is, update drivers w/o restarting X? -- Smile! http://antwrp.gsfc.nasa.gov/apod/ap990315.html |
From: Charl P. B. <c.p...@it...> - 2002-12-10 21:12:42
|
On Tue, Dec 10, 2002 at 12:53:51PM -0800, Ian Romanick wrote: > On Tue, Dec 10, 2002 at 10:31:08AM +0100, Charl P. Botha wrote: > > Dear list, > > > > In spite of some issues with binary snapshots, the DRI resume patches > > seem to work well. They have been available and in use on several > > different kinds of laptops for a few months now. > > > > What are the chances of this patch being accepted into the DRI CVS > > repository? How should I go about getting these small changes off my > > hands and eventually into XFree86? > > My memory is a little bit fuzzy on this. Did this patch also allow users to > change their DRM module and radeon_dri.so file while vt switched? That is, > update drivers w/o restarting X? No. You're thinking of the DRI ReInit patches which I started with an ugly kludge and Michel Dänzer subsequently turned into a very good solution for swapping out agpgart and the radeon DRM without restarting X. As a side-advantage, it also allows suspending/resuming, at least if no DRI-clients are running. The patch I'm talking about above is much simpler however. It performs a hardware-only re-initialisation at VT entry so that suspend/resume works even with running DRI-clients and Xv applications. Thanks, Charl -- charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/ |