#4 Some modifier and button emu fixes

[Wout Mertens]

Hi,

the attached patch has these fixes:

+ pressing a normal key stops button emulation mode

+ switch button emulation mode 2->3 and vice versa without
dropping out of emulation first

+ ignore button emulation when sending mouse buttons 2-5

+ check keyboard modifiers on focusout/focusin

Right now I'm trying to get scaling support in there.

Question: in drawRect in the FramebufferDrawing.h file, it uses a
scratch area to paint the window if possible. Why? Doesn't that
mean you copy those pixels twice?

Cheers,

Wout.

[Wout Mertens]

Latest patch against current CVS

[Wout Mertens]

Logged In: YES
user_id=238228

In the mean time, I found another bug: When you click the mouse
buttons real fast, and you release a button before the 3button emulation
timer goes off, it will only send the release on the next mouse event.

The net result is that when you are in another window, click on cotvnc to
activate it and then move your mouse, you end up selecting a bunch of
text. I fixed this by adding a timer call that releases the button
immediately afterwards.

BTW, two quick bug reports: in zrle mode, it crashes when the server
sends a null cursor image. Also, blue and red are reversed when going to
my Solaris VNC session.

[Jason Harris]

Logged In: YES
user_id=351330

Hi wmertens,

First off, thanks very much for the patches. I haven't yet had the time to
look at them, but will ASAP.

In the meantime, can you please make sure you're pulling your code
from the GEN_2_GUI branch of CVS? That's where current development
lives, and we've done quite a few bug fixes to everything you're talking
about on that branch. Some of it may negate your patches.

Thanks again!

[Wout Mertens]

Logged In: YES
user_id=238228

Hi smeger,

I just updated my CVS sandbox to GEN_2_CVS. I like the interface
improvements a lot! Very nice!

The only conflicts I got were for things you changed, so my patches
should still apply without a problem. Let me know if I should generate
new ones. Please apply, it really makes a difference in useability. And
the comments in the patch clarify the emulation code as well :)

I haven't worked on the scaling any more though. I came as far as
changing the FrameBufferDrawing.h file so that it used the scaling done
by NSDrawBitmap, which works nice for the initial load, but for some
reason, the cursor updates are not drawn. Still more looking needed.

Question: Why did you write your own frame buffer drawing code instead
of using an NSImage subclass? Just wondering, since that seems to have
everything you need?

Cheers,

Wout.

[Wout Mertens]

Logged In: YES
user_id=238228

Just wondering if you will apply. My changes work perfectly in the new
branch...

[Wout Mertens]

Logged In: YES
user_id=238228

Just to make sure, I made a new patch that applies cleanly against the
GEN_2_CVS tree.

Please apply :)

Is this project still maintained? If not, what do you suggest we use
otherwise?

Thanks!

Wout.

[Jason Harris]

Logged In: YES
user_id=351330

Applied by Jared and assigned to him. Sorry for the delay!